-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi all,
Bug #2974687 [0] originates from a bug in the PHPExcel library, which will be solved in a future release of that library. What do you think is the best way to incorporate this fix in our codebase? 1) Apply only the patch needed to fix this bug to our version of the PHPExcel library? 2) Or wait for a new release of that library, and upgrade the PHPExcel library in our codebase?
2) Seems the better thing to do, because we avoid to have to maintain a seperate version of PHPExcel, and in a future release some bugs other bugs are probably solved. But it is also a big change to the code, so it might require some testing. Hence the bug will only be fixed in 3.4-dev 1) will fix the bug faster and requires less testing, has less impact, hence it can be solved in 3.3.3-dev, but we'll miss out on other bugfixes in the library and have a PHPExcel-version that differs from the original project.
Or both 1) and 2) can be done.
What do you think?
[0] http://sourceforge.net/tracker/?func=detail&aid=2974687&group_id=230...
- -- Groetjes,
Dieter Adriaenssens
Dieter Adriaenssens a écrit :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi all,
Bug #2974687 [0] originates from a bug in the PHPExcel library, which will be solved in a future release of that library. What do you think is the best way to incorporate this fix in our codebase?
- Apply only the patch needed to fix this bug to our version of the
PHPExcel library? 2) Or wait for a new release of that library, and upgrade the PHPExcel library in our codebase?
- Seems the better thing to do, because we avoid to have to maintain
a seperate version of PHPExcel, and in a future release some bugs other bugs are probably solved. But it is also a big change to the code, so it might require some testing. Hence the bug will only be fixed in 3.4-dev
- will fix the bug faster and requires less testing, has less impact,
hence it can be solved in 3.3.3-dev, but we'll miss out on other bugfixes in the library and have a PHPExcel-version that differs from the original project.
Or both 1) and 2) can be done.
What do you think?
[0] http://sourceforge.net/tracker/?func=detail&aid=2974687&group_id=230...
Hi Dieter,
Probably 3.4.0 will be released after merging GSoC 2010 code, which means about 9 to 11 months from today (based on what happened for 3.3). So please apply the patch to QA_3_3 for 3.3.3 (possible release in a few weeks).
Things look good for 3.3.2 in a few days.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi
Dne Sun, 11 Apr 2010 14:29:17 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
Bug #2974687 [0] originates from a bug in the PHPExcel library, which will be solved in a future release of that library. What do you think is the best way to incorporate this fix in our codebase?
- Apply only the patch needed to fix this bug to our version of the
PHPExcel library? 2) Or wait for a new release of that library, and upgrade the PHPExcel library in our codebase?
- Seems the better thing to do, because we avoid to have to maintain
a seperate version of PHPExcel, and in a future release some bugs other bugs are probably solved. But it is also a big change to the code, so it might require some testing. Hence the bug will only be fixed in 3.4-dev
- will fix the bug faster and requires less testing, has less impact,
hence it can be solved in 3.3.3-dev, but we'll miss out on other bugfixes in the library and have a PHPExcel-version that differs from the original project.
Or both 1) and 2) can be done.
What do you think?
Apply the patch for 3.3 branch and wait for new upstream version for master (I expect the release will happen earlier than we will be able to release 3.4). Meanwhile you can try to upgrade PHPExcel to current version to see if there are any problems introduced by this.
- -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
-
Dieter Adriaenssens -
Marc Delisle -
Michal Čihař