[Phpmyadmin-devel] true number of rows for tables
Hi, Here is a recent change in db_details_structure.php, line 351: <td class="value"><?php echo PMA_formatNumber( $display_rows ); ?></td> I think we should not use PMA_formatNumber(), because we lose the exact count of rows when it's available (for example, MyISAM). Marc
Marc Delisle wrote:
Hi,
Here is a recent change in db_details_structure.php, line 351:
<td class="value"><?php echo PMA_formatNumber( $display_rows ); ?></td>
I think we should not use PMA_formatNumber(), because we lose the exact count of rows when it's available (for example, MyISAM).
it was to save screen space, how about: <abbr title="12467">12 k</abbr> ? -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
Sebastian Mendel a écrit :
Marc Delisle wrote:
Hi,
Here is a recent change in db_details_structure.php, line 351:
<td class="value"><?php echo PMA_formatNumber( $display_rows ); ?></td>
I think we should not use PMA_formatNumber(), because we lose the exact count of rows when it's available (for example, MyISAM).
it was to save screen space, how about:
<abbr title="12467">12 k</abbr>
?
Ok for me, but I don't think it saves anything, due to the width of this column's title (Records and the light bulb). The save would be only for monster tables. Marc
On Fri 21. 10. 2005 15:52, Marc Delisle wrote:
Sebastian Mendel a écrit :
Marc Delisle wrote:
Hi,
Here is a recent change in db_details_structure.php, line 351:
<td class="value"><?php echo PMA_formatNumber( $display_rows ); ?></td>
I think we should not use PMA_formatNumber(), because we lose the exact count of rows when it's available (for example, MyISAM).
it was to save screen space, how about:
<abbr title="12467">12 k</abbr>
?
Ok for me, but I don't think it saves anything, due to the width of this column's title (Records and the light bulb). The save would be only for monster tables.
I agree, losing precision doesn't make much sense here. -- Michal Čihař | http://cihar.com
Michal Čihař schrieb:
On Fri 21. 10. 2005 15:52, Marc Delisle wrote:
Sebastian Mendel a écrit :
Marc Delisle wrote:
Hi,
Here is a recent change in db_details_structure.php, line 351:
<td class="value"><?php echo PMA_formatNumber( $display_rows ); ?></td>
I think we should not use PMA_formatNumber(), because we lose the exact count of rows when it's available (for example, MyISAM).
it was to save screen space, how about:
<abbr title="12467">12 k</abbr>
?
Ok for me, but I don't think it saves anything, due to the width of this column's title (Records and the light bulb). The save would be only for monster tables.
I agree, losing precision doesn't make much sense here.
sorry for late answer, i reverted this, Sebastian
participants (3)
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel