[Phpmyadmin-devel] fixing code style warnings by changing messages?
Hi, I think we had this discussion, but if so, I could not find the outcome in [0]. Is it a good idea to wrap long messages like Bin is doing in [1], to fix code style warnings? I believe that this would produce new messages for our translators. [0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers [1] https://github.com/xmujay/phpmyadmin/commit/239067f35ff67bc2d707054ed17bc490... -- Marc Delisle http://infomarc.info
Hi Marc,
Hi, I think we had this discussion, but if so, I could not find the outcome in [0].
Is it a good idea to wrap long messages like Bin is doing in [1], to fix code style warnings? I believe that this would produce new messages for our translators.
[0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers
[1] https://github.com/xmujay/phpmyadmin/commit/239067f35ff67bc2d707054ed17bc490...
In fact, I don't change the messages. I just split the long message(one line) to serveral line and join them. so the message are same as before. Because the messages are too long. just like this: - __('When Host table is used, this field is ignored and values stored in Host table are used instead.') + __( + 'When Host table is used, this field is ignored ' + . 'and values stored in Host table are used instead.' + ) please advise~thanks Bin Zu
On 06/22/2013 03:43 PM, Bin Zu wrote:
Hi Marc,
Hi, I think we had this discussion, but if so, I could not find the outcome in [0].
Is it a good idea to wrap long messages like Bin is doing in [1], to fix code style warnings? I believe that this would produce new messages for our translators.
[0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers
[1] https://github.com/xmujay/phpmyadmin/commit/239067f35ff67bc2d707054ed17bc490...
In fact, I don't change the messages. I just split the long message(one line) to serveral line and join them. so the message are same as before. Because the messages are too long.
just like this: - __('When Host table is used, this field is ignored and values stored in Host table are used instead.') + __( + 'When Host table is used, this field is ignored ' + . 'and values stored in Host table are used instead.' + )
please advise~thanks
Marc, no new messages will be produced for the translator, gettext is relatively smart about this. Bye, Rouslan
Hi Dne Sat, 22 Jun 2013 22:43:00 +0800 "Bin Zu" <xmujay@gmail.com> napsal(a):
In fact, I don't change the messages. I just split the long message(one line) to serveral line and join them. so the message are same as before. Because the messages are too long.
just like this: - __('When Host table is used, this field is ignored and values stored in Host table are used instead.') + __( + 'When Host table is used, this field is ignored ' + . 'and values stored in Host table are used instead.' + )
please advise~thanks
This should not cause message change, xgettext should handle this safely. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (4)
-
Bin Zu -
Marc Delisle -
Michal Čihař -
Rouslan Placella