18 Jun
2013
18 Jun
'13
6:51 a.m.
Hi devs,
I am refactoring sql.php and I realized in line 389 of file the check for
a call to a stored procedure is done by using regexp. I would like to know
is it ok to keep it like that or is there any better approach to handle
that.
Regards Supun.
18 Jun
18 Jun
3:13 p.m.
Supun Nakandala a écrit :
Hi devs,
I am refactoring sql.php and I realized in line 389 of file the check for
a call to a stored procedure is done by using regexp. I would like to know
is it ok to keep it like that or is there any better approach to handle
that.
Regards Supun.
Hi Supun,
the better approach is to move this test to the SQL analyzer, like you
did a few days ago for other cases.
Using preg_match() can lead to mistake (for example, a SQL comment
located in the query and containing the word "call").
--
Marc Delisle
http://infomarc.info
19 Jun
19 Jun
8:57 a.m.
On Tue, Jun 18, 2013 at 5:43 PM, Marc Delisle <marc(a)infomarc.info> wrote:
Supun Nakandala a écrit :
I checked PMA_SQP_analyze() method with a test query calling a stored
procedure. But it didn't returned any information. Can you guide me how to
implement the required behavior in PMA_SQP_analyze() method such that it
can identify a call to a stored procedure.
Hi devs,
I am refactoring sql.php and I realized in line 389 of file the check
for
a call to a stored procedure is done by using
regexp. I would like to
know
is it ok to keep it like that or is there any
better approach to handle
that.
Regards Supun.
Hi Supun,
the better approach is to move this test to the SQL analyzer, like you
did a few days ago for other cases.
Hi Marc, Using preg_match() can lead to mistake (for example, a
SQL comment
located in the query and containing the word "call").
--
Marc Delisle
http://infomarc.info
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
--
Thank you
Supun Nakandala
Dept. Computer Science and Engineering
University of Moratuwa
2:02 p.m.
Supun Nakandala a écrit :
On Tue, Jun 18, 2013 at 5:43 PM, Marc Delisle
<marc(a)infomarc.info> wrote:
Hi Supun,
first I must ask whether you passed your query to PMA_SQP_parse() and
used the output to feed PMA_SQP_analyze().
Supun Nakandala a écrit :
I checked PMA_SQP_analyze() method with a test query calling a stored
procedure. But it didn't returned any information. Can you guide me how to
implement the required behavior in PMA_SQP_analyze() method such that it
can identify a call to a stored procedure. Hi devs,
I am refactoring sql.php and I realized in line 389 of file the check
for
a call to a stored procedure is done by using
regexp. I would like to
know
is it ok to keep it like that or is there any
better approach to handle
that.
Regards Supun.
Hi Supun,
the better approach is to move this test to the SQL analyzer, like you
did a few days ago for other cases.
Hi Marc,
> Using preg_match() can lead to mistake (for example, a SQL comment
> located in the query and containing the word "call").
--
Marc Delisle
http://infomarc.info
3:37 p.m.
On Wed, Jun 19, 2013 at 4:32 PM, Marc Delisle <marc(a)infomarc.info> wrote:
--
Thank you
Supun Nakandala
Dept. Computer Science and Engineering
University of Moratuwa
Supun Nakandala a écrit :
to
Hi Marc,
Yes I did that way.
On Tue, Jun 18, 2013 at 5:43 PM, Marc Delisle
<marc(a)infomarc.info>
wrote:
Supun Nakandala a écrit :
I checked PMA_SQP_analyze() method with a test query calling a stored
procedure. But it didn't returned any information. Can you guide me how Hi devs,
I am refactoring sql.php and I realized in line 389 of file the check
for
a call to a stored procedure is done by using
regexp. I would like to
know
is it ok to keep it like that or is there any
better approach to handle
that.
Regards Supun.
Hi Supun,
the better approach is to move this test to the SQL analyzer, like you
did a few days ago for other cases.
Hi Marc, implement the required behavior in
PMA_SQP_analyze() method such that it
can identify a call to a stored procedure.
Hi Supun,
first I must ask whether you passed your query to PMA_SQP_parse() and
used the output to feed PMA_SQP_analyze().
> Using preg_match() can lead to mistake (for example, a SQL comment
> located in the query and containing the word "call").
--
Marc Delisle
http://infomarc.info
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
3:44 p.m.
Supun Nakandala a écrit :
On Wed, Jun 19, 2013 at 4:32 PM, Marc Delisle
<marc(a)infomarc.info> wrote:
In sqlparser.lib.php there are a few DEBUG comments that deactivate some
echo statements. When activated, these will show you what the parser did
up to this point; this should show you what's going on in the parsing
phase.
--
Marc Delisle
http://infomarc.info
Supun Nakandala a écrit :
to
Hi Marc,
Yes I did that way. On Tue, Jun 18, 2013 at 5:43 PM, Marc Delisle
<marc(a)infomarc.info>
wrote:
Supun
Nakandala a écrit :
> Hi devs,
> I am refactoring sql.php and I realized in line 389 of file the check
for
> a call to a stored procedure is done by using regexp. I would like to
know
> is it ok to keep it like that or is there any better approach to handle
> that.
>
> Regards Supun.
Hi Supun,
the better approach is to move this test to the SQL analyzer, like you
did a few days ago for other cases.
Hi Marc,
I checked PMA_SQP_analyze() method with a test query calling a stored
procedure. But it didn't returned any information. Can you guide me how implement the required behavior in
PMA_SQP_analyze() method such that it
can identify a call to a stored procedure.
Hi Supun,
first I must ask whether you passed your query to PMA_SQP_parse() and
used the output to feed PMA_SQP_analyze().
4107
days inactive
4108
days old
5 comments
2 participants
participants (2)
-
Marc Delisle -
Supun Nakandala