26 Feb
2014
26 Feb
'14
3:15 p.m.
Hi,
I was looking into the bug http://sourceforge.net/p/phpmyadmin/bugs/4040/ ,
I am able to reproduce it, I get the fatal error in apache error log saying
"
PHP Fatal error: Call to a member function getPath() on a non-object in
/var/www/phpmyadmin/libraries/Util.class.php on line 184"
Though there is no error shown on UI, at the user interface I get the
expected message "Configuration has been saved" .
Also the error comes only when active theme is "pmahomme". Because in the
code we are unsetting the SESSION['PMA_Theme_Manager'] and
$_SESSION['PMA_Theme'] if the current theme is not "original".
So I have a Question:
Currently when we reset the settings, active theme doesn't reset to default
one, which is "pmahomme", it remains same. Is it the correct behaviour or
should it reset the current theme to default one?
So if we don't need to reset the theme to default one, then just removing
the unset statement which is unsetting themes session variables should fix
the issue. Otherwise instead of unsetting, setting the themes session
variables to default theme will fix the issue.
Please let me know if any concerns, so that I can proceed with fixing this
bug.
Thanks and Regards
Smita Kumari
26 Feb
26 Feb
7:38 p.m.
Smita a écrit :
Hi,
I was looking into the bug http://sourceforge.net/p/phpmyadmin/bugs/4040/ ,
I am able to reproduce it, I get the fatal error in apache error log saying
"
PHP Fatal error: Call to a member function getPath() on a non-object in
/var/www/phpmyadmin/libraries/Util.class.php on line 184"
Though there is no error shown on UI, at the user interface I get the
expected message "Configuration has been saved" .
Also the error comes only when active theme is "pmahomme". Because in the
code we are unsetting the SESSION['PMA_Theme_Manager'] and
$_SESSION['PMA_Theme'] if the current theme is not "original".
So I have a Question:
Currently when we reset the settings, active theme doesn't reset to default
one, which is "pmahomme", it remains same. Is it the correct behaviour or
should it reset the current theme to default one?
So if we don't need to reset the theme to default one, then just removing
the unset statement which is unsetting themes session variables should fix
the issue. Otherwise instead of unsetting, setting the themes session
variables to default theme will fix the issue.
Please let me know if any concerns, so that I can proceed with fixing this
bug.
Thanks and Regards
Smita Kumari
Smita,
I'm not sure that it will help, but when someone chooses a theme
different than the default one, a persistent cookie named "pma_theme" is
sent to the browser. Therefore, this user choice should be respected.
--
Marc Delisle
http://infomarc.info | http://phpmyadmin.net
10:05 p.m.
On Wed, Feb 26, 2014 at 10:08 PM, Marc Delisle <marc(a)infomarc.info> wrote:
Smita a écrit :
So in that case when we reset the settings, we should not unset the
SESSION['PMA_Theme_Manager'] and
$_SESSION['PMA_Theme'] variables If I get it right ? What do you think ?
Thanks
Smita Kumari
Hi,
I was looking into the bug
http://sourceforge.net/p/phpmyadmin/bugs/4040/ ,
I am able to reproduce it, I get the fatal error
in apache error log
saying
"
PHP Fatal error: Call to a member function getPath() on a non-object in
/var/www/phpmyadmin/libraries/Util.class.php on line 184"
Though there is no error shown on UI, at the user interface I get the
expected message "Configuration has been saved" .
Also the error comes only when active theme is "pmahomme". Because in the
code we are unsetting the SESSION['PMA_Theme_Manager'] and
$_SESSION['PMA_Theme'] if the current theme is not "original".
So I have a Question:
Currently when we reset the settings, active theme doesn't reset to
default
one, which is "pmahomme", it remains
same. Is it the correct behaviour or
should it reset the current theme to default one?
So if we don't need to reset the theme to default one, then just removing
the unset statement which is unsetting themes session variables should
fix
the issue. Otherwise instead of unsetting,
setting the themes session
variables to default theme will fix the issue.
Please let me know if any concerns, so that I can proceed with fixing
this
bug.
Thanks and Regards
Smita Kumari
Smita,
I'm not sure that it will help, but when someone chooses a theme
different than the default one, a persistent cookie named "pma_theme" is
sent to the browser. Therefore, this user choice should be respected.
--
Marc Delisle
http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.c…
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
27 Feb
27 Feb
3:42 p.m.
Le 2014-02-26 14:05, Smita a écrit :
On Wed, Feb 26, 2014 at 10:08 PM, Marc Delisle <marc(a)infomarc.info
<mailto:marc@infomarc.info>> wrote:
Smita a écrit :
Smita,
this looks like the correct solution.
--
Marc Delisle
http://infomarc.info | http://phpmyadmin.net
Hi,
I was looking into the bug
http://sourceforge.net/p/phpmyadmin/bugs/4040/ ,
I am able to reproduce it, I get the fatal error
in apache error
log saying
"
PHP Fatal error: Call to a member function getPath() on a
non-object in
/var/www/phpmyadmin/libraries/Util.class.php on
line 184"
Though there is no error shown on UI, at the user interface I get the
expected message "Configuration has been saved" .
Also the error comes only when active theme is "pmahomme". Because
in the
code we are unsetting the
SESSION['PMA_Theme_Manager'] and
$_SESSION['PMA_Theme'] if the current theme is not "original".
So I have a Question:
Currently when we reset the settings, active theme doesn't reset
to
default
one, which is "pmahomme", it remains
same. Is it the correct
behaviour or
should it reset the current theme to default
one?
So if we don't need to reset the theme to default one, then just
removing
the unset statement which is unsetting themes
session variables
should fix
the issue. Otherwise instead of unsetting,
setting the themes session
variables to default theme will fix the issue.
Please let me know if any concerns, so that I can proceed with
fixing this
bug.
Thanks and Regards
Smita Kumari
Smita,
I'm not sure that it will help, but when someone chooses a theme
different than the default one, a persistent cookie named "pma_theme" is
sent to the browser. Therefore, this user choice should be respected.
--
Marc Delisle
http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.c…
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
<mailto:Phpmyadmin-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
So in that case when we reset the settings, we should not unset the
SESSION['PMA_Theme_Manager'] and
$_SESSION['PMA_Theme'] variables If I get it right ? What do you think ?
Thanks
Smita Kumari
3854
days inactive
3855
days old
3 comments
2 participants
participants (2)
-
Marc Delisle -
Smita