[Phpmyadmin-devel] Refactoring tbl_replace_fields.inc.php
Hi Marc. Above file is not a huge file. And it includes only in tbl_replace.php script. (if I wrong, please correct me) So we can implement above file as a function in insert_edit.lib.php file. Is it ok? (The bug you mentioned yesterday not fixed yet. I'm looking at that also) -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
Le 2012-06-12 12:57, Thilina Buddika Abeyrathna a écrit :
Hi Marc. Above file is not a huge file. And it includes only in tbl_replace.php script. (if I wrong, please correct me) So we can implement above file as a function in insert_edit.lib.php file. Is it ok?
Yes.
(The bug you mentioned yesterday not fixed yet. I'm looking at that also)
Great! -- Marc Delisle http://infomarc.info
On Fri, Jun 15, 2012 at 6:07 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-12 12:57, Thilina Buddika Abeyrathna a écrit :
Hi Marc. Above file is not a huge file. And it includes only in tbl_replace.php script. (if I wrong, please correct me) So we can implement above file as a function in insert_edit.lib.php file. Is it ok?
Yes.
(The bug you mentioned yesterday not fixed yet. I'm looking at that also)
Great!
Apart from that bug I saw another bug in the action panel. (actions did not work correctly) I'll look at that also.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
On Fri, Jun 15, 2012 at 6:14 PM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Fri, Jun 15, 2012 at 6:07 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-12 12:57, Thilina Buddika Abeyrathna a écrit :
Hi Marc. Above file is not a huge file. And it includes only in tbl_replace.php script. (if I wrong, please correct me) So we can implement above file as a function in insert_edit.lib.php file. Is it ok?
Yes.
(The bug you mentioned yesterday not fixed yet. I'm looking at that also)
Great!
Apart from that bug I saw another bug in the action panel. (actions did not work correctly) I'll look at that also.
--
Hi Marc, I implemented a function in insert_edit.lib.php for replace the above file (subject) and committed the changes. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
Le 2012-06-17 05:46, Thilina Buddika Abeyrathna a écrit :
On Fri, Jun 15, 2012 at 6:14 PM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Fri, Jun 15, 2012 at 6:07 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-12 12:57, Thilina Buddika Abeyrathna a écrit :
Hi Marc. Above file is not a huge file. And it includes only in tbl_replace.php script. (if I wrong, please correct me) So we can implement above file as a function in insert_edit.lib.php file. Is it ok?
Yes.
(The bug you mentioned yesterday not fixed yet. I'm looking at that also)
Great!
Apart from that bug I saw another bug in the action panel. (actions did not work correctly) I'll look at that also.
--
Hi Marc, I implemented a function in insert_edit.lib.php for replace the above file (subject) and committed the changes.
Hi Thilina, ok I'm testing it and will add comments to github. -- Marc Delisle http://infomarc.info
On Sun, Jun 17, 2012 at 4:51 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-17 05:46, Thilina Buddika Abeyrathna a écrit :
On Fri, Jun 15, 2012 at 6:14 PM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Fri, Jun 15, 2012 at 6:07 PM, Marc Delisle <marc@infomarc.info>
wrote:
Le 2012-06-12 12:57, Thilina Buddika Abeyrathna a écrit :
Hi Marc. Above file is not a huge file. And it includes only in tbl_replace.php script. (if I wrong, please correct me) So we can implement above file as a function in insert_edit.lib.php file. Is it ok?
Yes.
(The bug you mentioned yesterday not fixed yet. I'm looking at that also)
Great!
Apart from that bug I saw another bug in the action panel. (actions did not work correctly) I'll look at that also.
--
Hi Marc, I implemented a function in insert_edit.lib.php for replace the above file (subject) and committed the changes.
Hi Thilina, ok I'm testing it and will add comments to github.
Ok Marc, Thanks. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
participants (2)
-
Marc Delisle -
Thilina Buddika Abeyrathna