Hi Marc,

yes, I know and I would be happy if the new visual query builder is moved to our "standard" theming.

What are you and other's thinking about this point and my follow idea? Would it be better to use visual query builder as a type of plugin, so users can choose if they want to use and install or not? Because I think, the basic query builder 'db_qbe.php' should still usable especially for browser which don't support javascripts.

Michael

Am 28.04.2010 20:24, schrieb Marc Delisle:

Michael Keck a écrit :

...

Hi Ankit,

welcome to phpMyAdmin and happy coding :) If you've any question feel free to ask.

I've some questions to you:

• would your visual query builder written/use in jQuery? phpMyAdmin uses jQuery and jQuery UI as javascript framework.
• would you style it with CSS

Regards

Michael Keck

Hi Michael, your question reminded me of another point regarding CSS. Currently, the Designer feature does not use the "standard" theming system but its own. See pmd/styles/default/style1.css and pmd/styles/default/images/*.

Michael Keck a écrit :

Hi Marc,

yes, I know and I would be happy if the new visual query builder is moved to our "standard" theming.

What are you and other's thinking about this point and my follow idea? Would it be better to use visual query builder as a type of plugin, so users can choose if they want to use and install or not? Because I think, the basic query builder 'db_qbe.php' should still usable especially for browser which don't support javascripts.

... and yes, db_qbe.php should stay for non-js browsers; but IMO, in this case we should offer both already installed, like we do for "Relation view" and "Designer" (but these don't have the same set of sub-features).

Hi Ankit,

Am 29.04.2010 06:27, schrieb ANKIT GUPTA:

Hi,

Is there any documentation for the coding style/standards used for phpMyadmin, i want to get used to these standards. also if there are other important points,things which i should know before starting code please do tell .

Coding Standards as described under http://phpmyadmin.net/home_page/improve.php.

My additional wish: Please comment your PHP Code and Javascript Code with standard doc-blocks:

* for php with PHP-Doc * for Javascript with JS-Doc.

So it's possible to generate on the fly with some tools a documentation from your source code ;)

i agree with marc,we should not keep visual query builder as a separate plugin and offer both as already installed. we can provide an option to users to switch between db_qbe.php and visual query builder inside the "Query" tab.

Or would it be better: if Javascript and jQuery running using yours, else using db_qbe.php?

Yes i will be using JQuery,i was planning to use some features from the Designer part, for the styling use of standard styling will be better.

Okay, that's good.

Reagrds Michael

Regards, Ankit

On Thu, Apr 29, 2010 at 12:38 AM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:

Michael Keck a écrit :
> Hi Marc,
>
> yes, I know and I would be happy if the new visual query builder is
> moved to our "standard" theming.
>
> What are you and other's thinking about this point and my follow
idea?
> Would it be better to use visual query builder as a type of
plugin, so
> users can choose if they want
> to use and install or not? Because I think, the basic query builder
> 'db_qbe.php' should still usable
> especially for browser which don't support javascripts.

... and yes, db_qbe.php should stay for non-js browsers; but IMO, in
this case we should offer both already installed, like we do for
"Relation view" and "Designer" (but these don't have the same set of
sub-features).

--
Marc Delisle
http://infomarc.info

------------------------------------------------------------------------------
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
<mailto:Phpmyadmin-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Michael Keck a écrit :

My additional wish: Please comment your PHP Code and Javascript Code with standard doc-blocks:

* for php with PHP-Doc
* for Javascript with JS-Doc.

So it's possible to generate on the fly with some tools a documentation from your source code ;)

The output from phpDocumentor is available at http://www.phpmyadmin.net/phpdoc/

Hi

Dne Thu, 29 Apr 2010 14:03:06 +0200 Michal Čihař michal@cihar.com napsal(a):

Dne Thu, 29 Apr 2010 07:48:37 -0400 Marc Delisle marc@infomarc.info napsal(a):

...

The output from phpDocumentor is available at http://www.phpmyadmin.net/phpdoc/

Which seems to be quite outdated :-). Looking into that.

The reason is that phpDocumentator consumes way too much memory while generating our documentation (1GiB is not enough). I'm currently looking for some alternative.

ANKIT GUPTA a écrit :

Hi michael,

My additional wish:
Please comment your PHP Code and Javascript Code with standard
doc-blocks:

    * for php with PHP-Doc
    * for Javascript with JS-Doc.

So it's possible to generate on the fly with some tools a
documentation from your
source code ;)

Ok thanks for the info will take care of it.

...

i agree with marc,we should not keep visual query builder as a
separate plugin and offer both as already installed.
we can provide an option to users to switch between  db_qbe.php
and visual query builder
inside the "Query" tab.

Or would it be better: if Javascript and jQuery running using yours,
else using db_qbe.php?

sorry i didn't get your question, I was suggesting to provide an option to the users to switch between 'visual query builder' and the current version.

I think this is better, as the two interfaces will probably not offer the exact same features.

in the 'Query'(multi-table query generator) tab. i will be using code from db_qbe.php.

If possible, use refactoring methods to avoid cutting&pasting code.