[Phpmyadmin-devel] Github Fork+Clone = PHP Error. Also Status Monitor.
Heya. Haven't written in a while. This appears when I browse a table from my forked github pma of today: *Parse error*: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in * E:\htdocs\nikolaus\pma\phpmyadmin\libraries\DisplayResults.class.php* on line *3879* The seems to be a lot of new bugs + glitchy behavior in the Status monitor, since the transition to jqplot. Here are a few i could pin down:* * - roccivic for some reason deletes the local storage when the page unloads, though it's intention was for storing settings: https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a86... - Reloading the page while in the monitor will result in a js error in jqpload and not load the charts - The query analyzer dialog doesn't show the profiling chart anymore. For this however I took the freedom to fix this + graphical glitches myself and send a pull request on github: https://github.com/phpmyadmin/phpmyadmin/pull/113 On another note: - Mousewheel scrolling doesn't work in the left pane when I 1. Expand a DB with many tables 2. Expand the tables 3. Switch to page 2 - Also the left pane scroll bar is so massively fat, is that intended? Sorry for throwing these bug reports out so chaotically. Thanks for reading anyway! -- *Tyron Madlener* *Anego Web Development* * * *www.tyron.at* *T: +43 650 5950596* *E: office@tyron.at*
Sadly there also seems to be a big memory leak with jqplot. Letting the monitor run for a longer time causes my Chrome consume 1-2 GB of memory. Maybe old data values are not being deleted? On Mon, Dec 3, 2012 at 6:29 PM, Tyron Madlener <tyronx@gmail.com> wrote:
Heya. Haven't written in a while. This appears when I browse a table from my forked github pma of today:
*Parse error*: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in * E:\htdocs\nikolaus\pma\phpmyadmin\libraries\DisplayResults.class.php* on line *3879*
The seems to be a lot of new bugs + glitchy behavior in the Status monitor, since the transition to jqplot. Here are a few i could pin down:* *
- roccivic for some reason deletes the local storage when the page unloads, though it's intention was for storing settings: https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a86...
- Reloading the page while in the monitor will result in a js error in jqpload and not load the charts
- The query analyzer dialog doesn't show the profiling chart anymore. For this however I took the freedom to fix this + graphical glitches myself and send a pull request on github: https://github.com/phpmyadmin/phpmyadmin/pull/113
On another note: - Mousewheel scrolling doesn't work in the left pane when I 1. Expand a DB with many tables 2. Expand the tables 3. Switch to page 2
- Also the left pane scroll bar is so massively fat, is that intended?
Sorry for throwing these bug reports out so chaotically. Thanks for reading anyway!
-- *Tyron Madlener* *Anego Web Development* * * *www.tyron.at* *T: +43 650 5950596* *E: office@tyron.at*
-- *Tyron Madlener* *Anego Web Development* * * *www.tyron.at* *T: +43 650 5950596* *E: office@tyron.at*
On 03/12/12 18:39, Tyron Madlener wrote:
Sadly there also seems to be a big memory leak with jqplot. Letting the monitor run for a longer time causes my Chrome consume 1-2 GB of memory. Maybe old data values are not being deleted?
On Mon, Dec 3, 2012 at 6:29 PM, Tyron Madlener <tyronx@gmail.com <mailto:tyronx@gmail.com>> wrote:
Heya. Haven't written in a while. This appears when I browse a table from my forked github pma of today:
*Parse error*: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in *E:\htdocs\nikolaus\pma\phpmyadmin\libraries\DisplayResults.class.php* on line *3879*
The seems to be a lot of new bugs + glitchy behavior in the Status monitor, since the transition to jqplot. Here are a few i could pin down:*
- roccivic for some reason deletes the local storage when the page unloads, though it's intention was for storing settings: https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a86...
Yep, my bad. I'll put that back some time soon.
- Reloading the page while in the monitor will result in a js error in jqpload and not load the charts
- The query analyzer dialog doesn't show the profiling chart anymore. For this however I took the freedom to fix this + graphical glitches myself and send a pull request on github: https://github.com/phpmyadmin/phpmyadmin/pull/113
There are several other things that aren't right with the server status pages. In general I find that there are many problems related to the tabbed navigation, so I'm splitting the different server status features into separate pages. This should also improve further maintainability of the system. By the way, will you be hacking the server status pages any time soon? We might want to try and avoid any merge conflicts, if you do...
On another note: - Mousewheel scrolling doesn't work in the left pane when I 1. Expand a DB with many tables 2. Expand the tables 3. Switch to page 2
- Also the left pane scroll bar is so massively fat, is that intended?
Yes, that's how I intended it to be. JM, had provided a thinner replacement version, but that also came with a list of bugs that IMO didn't justify the benefits.
Sorry for throwing these bug reports out so chaotically. Thanks for reading anyway!
There are several other things that aren't right with the server status pages. In general I find that there are many problems related to the tabbed navigation, so I'm splitting the different server status features into separate pages. This should also improve further maintainability of the system.
Oh yes. That's probably a good idea.
By the way, will you be hacking the server status pages any time soon? We might want to try and avoid any merge conflicts, if you do...
The only thing I might do is fix some of the bugs and glitches that I notice, which however should be only very local changes. If I do, I'll make it as a pull request on github. I'll leave a note here if I plan to make any bigger changes :-) On Mon, Dec 3, 2012 at 11:45 PM, Rouslan Placella <rouslan@placella.com>wrote:
On 03/12/12 18:39, Tyron Madlener wrote:
Sadly there also seems to be a big memory leak with jqplot. Letting the monitor run for a longer time causes my Chrome consume 1-2 GB of memory. Maybe old data values are not being deleted?
On Mon, Dec 3, 2012 at 6:29 PM, Tyron Madlener <tyronx@gmail.com <mailto:tyronx@gmail.com>> wrote:
Heya. Haven't written in a while. This appears when I browse a table from my forked github pma of today:
*Parse error*: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in
*E:\htdocs\nikolaus\pma\phpmyadmin\libraries\DisplayResults.class.php* on
line *3879*
The seems to be a lot of new bugs + glitchy behavior in the Status monitor, since the transition to jqplot. Here are a few i could pin down:*
- roccivic for some reason deletes the local storage when the page unloads, though it's intention was for storing settings:
https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a86...
Yep, my bad. I'll put that back some time soon.
- Reloading the page while in the monitor will result in a js error in jqpload and not load the charts
- The query analyzer dialog doesn't show the profiling chart anymore. For this however I took the freedom to fix this + graphical glitches myself and send a pull request on github: https://github.com/phpmyadmin/phpmyadmin/pull/113
There are several other things that aren't right with the server status pages. In general I find that there are many problems related to the tabbed navigation, so I'm splitting the different server status features into separate pages. This should also improve further maintainability of the system.
By the way, will you be hacking the server status pages any time soon? We might want to try and avoid any merge conflicts, if you do...
On another note: - Mousewheel scrolling doesn't work in the left pane when I 1. Expand a DB with many tables 2. Expand the tables 3. Switch to page 2
- Also the left pane scroll bar is so massively fat, is that
intended?
Yes, that's how I intended it to be. JM, had provided a thinner replacement version, but that also came with a list of bugs that IMO didn't justify the benefits.
Sorry for throwing these bug reports out so chaotically. Thanks for reading anyway!
------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- *Tyron Madlener* *Anego Web Development* * * *www.tyron.at* *T: +43 650 5950596* *E: office@tyron.at*
On 04/12/12 08:53, Tyron Madlener wrote:
There are several other things that aren't right with the server status pages. In general I find that there are many problems related to the tabbed navigation, so I'm splitting the different server status features into separate pages. This should also improve further maintainability of the system.
Oh yes. That's probably a good idea.
By the way, will you be hacking the server status pages any time soon? We might want to try and avoid any merge conflicts, if you do...
The only thing I might do is fix some of the bugs and glitches that I notice, which however should be only very local changes. If I do, I'll make it as a pull request on github. I'll leave a note here if I plan to make any bigger changes :-)
Feel free to directly assign any pull requests relative to the server status pages to me. I'll look into integrating those with my changes.
On Mon, Dec 3, 2012 at 11:45 PM, Rouslan Placella <rouslan@placella.com <mailto:rouslan@placella.com>> wrote:
On 03/12/12 18:39, Tyron Madlener wrote: > Sadly there also seems to be a big memory leak with jqplot. Letting the > monitor run for a longer time causes my Chrome consume 1-2 GB of memory. > Maybe old data values are not being deleted? > > > On Mon, Dec 3, 2012 at 6:29 PM, Tyron Madlener <tyronx@gmail.com <mailto:tyronx@gmail.com> > <mailto:tyronx@gmail.com <mailto:tyronx@gmail.com>>> wrote: > > Heya. Haven't written in a while. This appears when I browse a table > from my forked github pma of today: > > *Parse error*: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in > *E:\htdocs\nikolaus\pma\phpmyadmin\libraries\DisplayResults.class.php* on > line *3879* > > > The seems to be a lot of new bugs + glitchy behavior in the Status > monitor, since the transition to jqplot. Here are a few i could pin > down:* > > - roccivic for some reason deletes the local storage when the page > unloads, though it's intention was for storing settings: > https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a86...
Yep, my bad. I'll put that back some time soon.
> - Reloading the page while in the monitor will result in a js error > in jqpload and not load the charts > > - The query analyzer dialog doesn't show the profiling chart > anymore. For this however I took the freedom to fix this + graphical > glitches myself and send a pull request on github: > https://github.com/phpmyadmin/phpmyadmin/pull/113
There are several other things that aren't right with the server status pages. In general I find that there are many problems related to the tabbed navigation, so I'm splitting the different server status features into separate pages. This should also improve further maintainability of the system.
By the way, will you be hacking the server status pages any time soon? We might want to try and avoid any merge conflicts, if you do...
> On another note: > - Mousewheel scrolling doesn't work in the left pane when I > 1. Expand a DB with many tables > 2. Expand the tables > 3. Switch to page 2 > > - Also the left pane scroll bar is so massively fat, is that intended?
Yes, that's how I intended it to be. JM, had provided a thinner replacement version, but that also came with a list of bugs that IMO didn't justify the benefits.
> Sorry for throwing these bug reports out so chaotically. Thanks for > reading anyway!
On 12/04/2012 08:53 AM, Tyron Madlener wrote:
> - roccivic for some reason deletes the local storage when the page > unloads, though it's intention was for storing settings: > https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a86...
Yep, my bad. I'll put that back some time soon.
And here's the real reason I had disabled the localStorage feature: http://sourceforge.net/tracker/?func=detail&aid=3596070&group_id=23067&atid=... Bye, Rouslan
Ok, did some Research and found it. Someone added new Properties to the defaultChartGrid variable which were missed out when saving the grid to localStorage. Here's the fix: https://github.com/phpmyadmin/phpmyadmin/pull/119 On Sun, Dec 16, 2012 at 5:33 PM, Rouslan Placella <rouslan@placella.com>wrote:
On 12/04/2012 08:53 AM, Tyron Madlener wrote:
> - roccivic for some reason deletes the local storage when the page > unloads, though it's intention was for storing settings: > https://github.com/phpmyadmin/**phpmyadmin/commit/** 9d4799e6728adf792dc955a59a868d**61adad2be6#commitcomment-**2243979<https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a868d61adad2be6#commitcomment-2243979>
Yep, my bad. I'll put that back some time soon.
And here's the real reason I had disabled the localStorage feature:
http://sourceforge.net/**tracker/?func=detail&aid=** 3596070&group_id=23067&atid=**377408<http://sourceforge.net/tracker/?func=detail&aid=3596070&group_id=23067&atid=377408>
Bye, Rouslan
-- *Tyron Madlener* *Anego Web Development* * * *www.tyron.at* *T: +43 650 5950596* *E: office@tyron.at*
On 12/17/2012 02:34 PM, Tyron Madlener wrote:
Ok, did some Research and found it. Someone added new Properties to the defaultChartGrid variable which were missed out when saving the grid to localStorage.
Here's the fix: https://github.com/phpmyadmin/phpmyadmin/pull/119
Hi Tyron, Thanks for the fix. Applied to QA_3_5 and master. Bye, Rouslan
On Tue, Dec 4, 2012 at 12:09 AM, Tyron Madlener <tyronx@gmail.com> wrote:
Sadly there also seems to be a big memory leak with jqplot. Letting the monitor run for a longer time causes my Chrome consume 1-2 GB of memory. Maybe old data values are not being deleted?
Thanks Tyron for pointing out, certainly I forgot to free old series data, I am going to look into it. And yeah many glitches got introduced into server=>status while migrating the live charts to jqplot, some due to its limitations, and improvements are needed :)
On Mon, Dec 3, 2012 at 6:29 PM, Tyron Madlener <tyronx@gmail.com> wrote:
Heya. Haven't written in a while. This appears when I browse a table from my forked github pma of today:
*Parse error*: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in * E:\htdocs\nikolaus\pma\phpmyadmin\libraries\DisplayResults.class.php* on line *3879*
The seems to be a lot of new bugs + glitchy behavior in the Status monitor, since the transition to jqplot. Here are a few i could pin down: * *
- roccivic for some reason deletes the local storage when the page unloads, though it's intention was for storing settings: https://github.com/phpmyadmin/phpmyadmin/commit/9d4799e6728adf792dc955a59a86...
- Reloading the page while in the monitor will result in a js error in jqpload and not load the charts
- The query analyzer dialog doesn't show the profiling chart anymore. For this however I took the freedom to fix this + graphical glitches myself and send a pull request on github: https://github.com/phpmyadmin/phpmyadmin/pull/113
On another note: - Mousewheel scrolling doesn't work in the left pane when I 1. Expand a DB with many tables 2. Expand the tables 3. Switch to page 2
- Also the left pane scroll bar is so massively fat, is that intended?
Sorry for throwing these bug reports out so chaotically. Thanks for reading anyway!
-- *Tyron Madlener* *Anego Web Development* * * *www.tyron.at* *T: +43 650 5950596* *E: office@tyron.at*
-- *Tyron Madlener* *Anego Web Development* * * *www.tyron.at* *T: +43 650 5950596* *E: office@tyron.at*
------------------------------------------------------------------------------ Keep yourself connected to Go Parallel: BUILD Helping you discover the best ways to construct your parallel projects. http://goparallel.sourceforge.net _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh http://blog.atulsisodia.in/
participants (3)
-
Atul Pratap Singh -
Rouslan Placella -
Tyron Madlener