21 Mar
2007
21 Mar
'07
6:02 a.m.
Hi,
i am not sure, but was/is there any reason why $sql_query is not always
properly initilized? or is it just missing?
i think it should happen in common.inc.php on line #429
with $GLOBALS['sql_query'] = '';
like it is done with $GLOBALS['db'] and $GLOBALS['table'] some lines
above
--
Sebastian Mendel
www.sebastianmendel.de
21 Mar
21 Mar
10:23 a.m.
Sebastian Mendel a écrit :
Hi,
i am not sure, but was/is there any reason why $sql_query is not always
properly initilized? or is it just missing?
i think it should happen in common.inc.php on line #429
with $GLOBALS['sql_query'] = '';
like it is done with $GLOBALS['db'] and $GLOBALS['table'] some lines
above
Sounds to me like it is missing indeed.
10:34 a.m.
Marc Delisle schrieb:
Sebastian Mendel a écrit :
there are some "isset($sql_query)" that needs to be replaced by
"! empty($sql_query)"
--
Sebastian Mendel
www.sebastianmendel.de
Hi,
i am not sure, but was/is there any reason why $sql_query is not always
properly initilized? or is it just missing?
i think it should happen in common.inc.php on line #429
with $GLOBALS['sql_query'] = '';
like it is done with $GLOBALS['db'] and $GLOBALS['table'] some lines
above
Sounds to me like it is missing indeed. 
31 Mar
31 Mar
9:04 a.m.
Marc Delisle wrote:
Sebastian Mendel a écrit :
common.lib.php revision 10231:
988...
strlen($GLOBALS['sql_query']) && $GLOBALS['sql_query'] ==
'TRUNCATE TABLE '
strlen is always >0 if $GLOBALS['sql_query'] == 'TRUNCATE TABLE '
so "strlen($GLOBALS['sql_query']) &&" is not needed here or did
i overlook
something?
--
View this message in context:
http://www.nabble.com/%24sql_query-not-initilized-tf3439288.html#a9766616
Sent from the phpmyadmin-devel mailing list archive at Nabble.com.
Hi,
i am not sure, but was/is there any reason why $sql_query is not always
properly initilized? or is it just missing?
i think it should happen in common.inc.php on line #429
with $GLOBALS['sql_query'] = '';
like it is done with $GLOBALS['db'] and $GLOBALS['table'] some lines
above
Sounds to me like it is missing indeed.
9:27 a.m.
Jürgen Wind a écrit :
Marc Delisle wrote:
Right, I'll remove it.
Sebastian Mendel a écrit :
common.lib.php revision 10231:
988...
strlen($GLOBALS['sql_query']) && $GLOBALS['sql_query'] ==
'TRUNCATE TABLE '
strlen is always >0 if $GLOBALS['sql_query'] == 'TRUNCATE TABLE '
so "strlen($GLOBALS['sql_query']) &&" is not needed here or did
i overlook
something?
Hi,
i am not sure, but was/is there any reason why $sql_query is not always
properly initilized? or is it just missing?
i think it should happen in common.inc.php on line #429
with $GLOBALS['sql_query'] = '';
like it is done with $GLOBALS['db'] and $GLOBALS['table'] some lines
above
Sounds to me like it is missing indeed.
9:30 a.m.
Jürgen Wind wrote:
Marc Delisle wrote:
if i reorder the code
if (
strlen($GLOBALS['table']) &&
isset($GLOBALS['sql_query']) &&
strlen($GLOBALS['sql_query']) &&
$GLOBALS['sql_query'] == 'TRUNCATE TABLE ' .
PMA_backquote($GLOBALS['table'])
)
{
a opening "(" seems to be missing before "$GLOBALS['sql_query'] ==
'TRUNCATE... " ???
--
View this message in context:
http://www.nabble.com/%24sql_query-not-initilized-tf3439288.html#a9766814
Sent from the phpmyadmin-devel mailing list archive at Nabble.com.
Sebastian Mendel a écrit :
common.lib.php revision 10231:
988...
strlen($GLOBALS['sql_query']) && $GLOBALS['sql_query'] ==
'TRUNCATE TABLE
'
strlen is always >0 if $GLOBALS['sql_query'] == 'TRUNCATE TABLE '
so "strlen($GLOBALS['sql_query']) &&" is not needed here or did
i overlook
something?
Hi,
i am not sure, but was/is there any reason why $sql_query is not always
properly initilized? or is it just missing?
i think it should happen in common.inc.php on line #429
with $GLOBALS['sql_query'] = '';
like it is done with $GLOBALS['db'] and $GLOBALS['table'] some lines
above
Sounds to me like it is missing indeed.
9:38 a.m.
Jürgen Wind a écrit :
Jürgen Wind wrote:
Nope. Maybe you are confusing the ending ")" of PMA_backquote.
Note that
strlen($GLOBALS['sql_query'])
is no longer in trunk.
Marc Delisle wrote:
if i reorder the code
if (
strlen($GLOBALS['table']) &&
isset($GLOBALS['sql_query']) &&
strlen($GLOBALS['sql_query']) &&
$GLOBALS['sql_query'] == 'TRUNCATE TABLE ' .
PMA_backquote($GLOBALS['table'])
)
{
a opening "(" seems to be missing before "$GLOBALS['sql_query']
==
'TRUNCATE... " ??? Sebastian Mendel a écrit :
common.lib.php revision 10231:
988...
strlen($GLOBALS['sql_query']) && $GLOBALS['sql_query'] ==
'TRUNCATE TABLE
'
strlen is always >0 if $GLOBALS['sql_query'] == 'TRUNCATE TABLE '
so "strlen($GLOBALS['sql_query']) &&" is not needed here or did
i overlook
something?
Hi,
i am not sure, but was/is there any reason why $sql_query is not always
properly initilized? or is it just missing?
i think it should happen in common.inc.php on line #429
with $GLOBALS['sql_query'] = '';
like it is done with $GLOBALS['db'] and $GLOBALS['table'] some lines
above
Sounds to me like it is missing indeed.
6370
days inactive
6380
days old
6 comments
3 participants
participants (3)
-
Jürgen Wind -
Marc Delisle -
Sebastian Mendel