11 Feb
2003
11 Feb
'03
2:24 p.m.
Hi,
currently in tbl_change, we display a file selector to upload
into a field, when it's a BLOB or has the attribute Binary.
According to the MySQL doc:
"The BINARY attribute means that column values are sorted and
compared in case-sensitive fashion according to the ASCII order
of the machine where the MySQL server is running.
BINARY doesn't affect how the column is stored or retrieved."
If we take this to the letter, we should offer a file selector
for every field, because they all can have binary contents.
But I don't think it's a good idea!
However, I guess that most users choose the "binary" attribute
for a field to put some binary contents in it.
The bug 682346 occured first because his mysql.user file has
the binary attribute on some fields, like host.
So, do we still offer an upload choice for "binary" fields?
Marc
12 Feb
12 Feb
6:55 a.m.
Hi
On Tue, Feb 11, 2003 at 02:23:33PM -0500, Marc Delisle wrote:
currently in tbl_change, we display a file selector to
upload
into a field, when it's a BLOB or has the attribute Binary.
According to the MySQL doc:
"The BINARY attribute means that column values are sorted and
compared in case-sensitive fashion according to the ASCII order
of the machine where the MySQL server is running.
BINARY doesn't affect how the column is stored or retrieved."
If we take this to the letter, we should offer a file selector
for every field, because they all can have binary contents.
But I don't think it's a good idea!
However, I guess that most users choose the "binary" attribute
for a field to put some binary contents in it.
The bug 682346 occured first because his mysql.user file has
the binary attribute on some fields, like host.
So, do we still offer an upload choice for "binary" fields?
I thing for blob it would be enough... In fact I don't know for what
would I use small binary field but maybe somebody could need to put
there some data and there is no other way than uploading... Maybe it
would be better to put uploading stuff on separate page and add on
tbl_change (and maybe also on display_tbl where [binary] is being shown)
only link to that.
--
Regards
Michal Cihar
http://cihar.liten.cz
7:32 a.m.
New subject: [Phpmyadmin-devel] about 'binary' attribute
Hi!
I thing for blob it would be enough... In fact I
don't know for what
would I use small binary field but maybe somebody could need to put
there some data and there is no other way than uploading...
I also would think it suffices to upload data to blob fields. Maybe we
could put in a configuration directive to enable upload to binary fields
disabled by default? So anybody who's willing to clutter his interface
with many upload-buttons, he can make it so.
Maybe it
would be better to put uploading stuff on separate page and add on
tbl_change (and maybe also on display_tbl where [binary] is being shown)
only link to that.
I don't like the idea to split up the interface to another part. I find it
quite intuitive to have the upload stuff where I want to alter or insert
data. Linking to another page is discomforting for me, and maybe also
other users.
I think the 'edit' button on display_tbl should be enough to alter the
data. Another direct link - if I understand your approach - to upload is
in my opinion too cluttering.
$0.02 :)
--
Bye,
Garvin.
9:54 a.m.
New subject: [Phpmyadmin-devel] about 'binary' attribute
Hi Garvin, Marc & list,
-----Original Message-----
From: Garvin Hicking
Imho, we should make this configurable for the user.
The easiest way would be to use $cfg['ProtectBinary'] to decide wheather
we display the upload field or not.
In this case, I'd suggest to display the upload box inside the reqular
edit column, where now only display the message "Binary - do not edit (X
Bytes)" - for cosmetical reasons, mainly: I currently have to scroll
vertically in order to use the upload field.
By the way, what do we need this binary checkbox for?
Additionally we could optionally let the user store information about
wheather a fild should contain real binary data or not in the PMA
database, e.g. in the same table that stores the column comments.
I fully agree with Garvin in this point
Regards,
Alexander M. Turek
<alex(a)bugfixes.info>
+-----------------------------+
| The phpMyAdmin Project |
| http://www.phpmyadmin.net |
| rabus(a)users.sourceforge.net |
+-----------------------------+
| [bugfixes.info] |
| http://www.bugfixes.info |
| rabus(a)bugfixes.info |
+-----------------------------+
I thing for blob it would be enough... In fact I
don't know
for what would I use small binary field but maybe somebody
could need to put there some data and there is no other way
than uploading...
I also would think it suffices to upload data to blob fields.
Maybe we could put in a configuration directive to enable
upload to binary fields disabled by default? So anybody who's
willing to clutter his interface with many upload-buttons, he
can make it so. Maybe it
would be better to put uploading stuff on separate page and add on
tbl_change (and maybe also on display_tbl where [binary] is being
shown) only link to that.
I don't like the idea to split up the interface to another
part. I find it quite intuitive to have the upload stuff
where I want to alter or insert data. Linking to another page
is discomforting for me, and maybe also other users.
I think the 'edit' button on display_tbl should be enough to
alter the data. Another direct link - if I understand your
approach - to upload is in my opinion too cluttering.
14 Feb
14 Feb
10:58 a.m.
New subject: [Phpmyadmin-devel] about 'binary' attribute
Rabus wrote:
Hi Garvin, Marc & list,
-----Original Message-----
From: Garvin Hicking
Imho, we should make this configurable for the user.
The easiest way would be to use $cfg['ProtectBinary'] to decide wheather
we display the upload field or not.
In this case, I'd suggest to display the upload box inside the reqular
edit column, where now only display the message "Binary - do not edit (X
Bytes)" - for cosmetical reasons, mainly: I currently have to scroll
vertically in order to use the upload field.
Good idea, will you do it? :)
I thing
for blob it would be enough... In fact I don't know
for what would I use small binary field but maybe somebody
could need to put there some data and there is no other way
than uploading...
I also would think it suffices to upload data to blob fields.
Maybe we could put in a configuration directive to enable
upload to binary fields disabled by default? So anybody who's
willing to clutter his interface with many upload-buttons, he
can make it so.
By the way, what do we need this binary checkbox for?
To transform the data for a safer INSERT. But I don't know the impact
if we were transforming even the non-binary data.
Additionally we could optionally let the user store information about
wheather a fild should contain real binary data or not in the PMA
database, e.g. in the same table that stores the column comments.
I fully agree with Garvin in this point
Regards,
Alexander M. Turek
<alex(a)bugfixes.info>
Maybe it
would be better to put uploading stuff on separate page and add on
tbl_change (and maybe also on display_tbl where [binary] is being
shown) only link to that.
I don't like the idea to split up the interface to another
part. I find it quite intuitive to have the upload stuff
where I want to alter or insert data. Linking to another page
is discomforting for me, and maybe also other users.
I think the 'edit' button on display_tbl should be enough to
alter the data. Another direct link - if I understand your
approach - to upload is in my opinion too cluttering.
16 Feb
16 Feb
4:19 p.m.
New subject: [Phpmyadmin-devel] about 'binary' attribute
On Friday 14 February 2003 16:56, Marc Delisle wrote:
Probably none, I just wanted to keep old behaviour ;-). The only thing where
it could hurt is uploading text file and you want to convert its charset, but
it doesn't seem to be much useful. As I think more about the checkbox, it
will probably only cause problems... Okay to remove it?
--
Regards
Michal Cihar
nijel at users dot sourceforge dot net
http://cihar.liten.cz
By the way,
what do we need this binary checkbox for?
To transform the data for a safer INSERT. But I don't know the impact
if we were transforming even the non-binary data.
5:04 p.m.
New subject: [Phpmyadmin-devel] about 'binary' attribute
I am ok to remove it.
Marc
Michal Cihar wrote:
On Friday 14 February 2003 16:56, Marc Delisle wrote:
Probably none, I just wanted to keep old behaviour ;-). The only thing where
it could hurt is uploading text file and you want to convert its charset, but
it doesn't seem to be much useful. As I think more about the checkbox, it
will probably only cause problems... Okay to remove it?
By the
way, what do we need this binary checkbox for?
To transform the data for a safer INSERT. But I don't know the impact
if we were transforming even the non-binary data.
12 Feb
12 Feb
8:56 a.m.
Ok, for now, upload fields only to BLOBs. Merged in cvs.
Marc
Marc Delisle wrote:
Hi,
currently in tbl_change, we display a file selector to upload
into a field, when it's a BLOB or has the attribute Binary.
According to the MySQL doc:
"The BINARY attribute means that column values are sorted and
compared in case-sensitive fashion according to the ASCII order
of the machine where the MySQL server is running.
BINARY doesn't affect how the column is stored or retrieved."
If we take this to the letter, we should offer a file selector
for every field, because they all can have binary contents.
But I don't think it's a good idea!
However, I guess that most users choose the "binary" attribute
for a field to put some binary contents in it.
The bug 682346 occured first because his mysql.user file has
the binary attribute on some fields, like host.
So, do we still offer an upload choice for "binary" fields?
Marc
-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
7883
days inactive
7888
days old
7 comments
5 participants
participants (5)
-
Garvin Hicking -
Marc Delisle -
Marc Delisle
-
Michal Cihar -
Rabus