Hi Dne Mon, 21 Apr 2014 19:22:58 +0530 Minhaz A V <minhazav(a)gmail.com> napsal(a): No it does not work well - it asks for confirmation whenever there is something filled in in the form. What is true for many of our forms without user doing anything. Also it seems to ask for confirmation even when user is submitting form which he has just filled in (try something on table's Operations tab). I've just reverted commit causing these. PS: All the Jenkins failures were also caused by this, is anybody paying attention to these mails or they are just being ignored? -- Michal Čihař | http://cihar.com | http://phpmyadmin.net ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

On Tue, Apr 22, 2014 at 5:16 PM, Minhaz A V <minhazav(a)gmail.com> wrote: repository, instead you can create a new branch out of master in your local repo and push it to your github account for public review, then you can open a pull request from your branch to the main PMA repo's master branch when it's all done. -- Atul Pratap Singh http://blog.atulsisodia.in/ ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

I was thinking this code could be modified to check if any input field was changed from the value it was loaded with if some user try to perform ajax operation or any operation that triggers onbeforeunload event.

AJAX code will go well in ajax.js while for onbeforeunload section, I'd add an event listener to it in common.js as mentioned by Atul. If you guys feel this feature should not exist in pma, I'd stop here on this. Kindly let me know by night or I'll start writing :D, as I feel this feature should be there.

Also, is it possible to add a branch for this in pma, till this feature is working well or I should come up with a whole working one in my fork before I pull.

I have a better approach, We'll count the no of characters before an ajax load, and on event request count again and compare.

But should this cause selenium test to fail? is there any test case which should trigger the dialog where it is expected to trigger?

Hi Dne Mon, 21 Apr 2014 19:22:58 +0530 Minhaz A V <minhazav(a)gmail.com> napsal(a): No it does not work well - it asks for confirmation whenever there is something filled in in the form. What is true for many of our forms without user doing anything. Also it seems to ask for confirmation even when user is submitting form which he has just filled in (try something on table's Operations tab). I've just reverted commit causing these. PS: All the Jenkins failures were also caused by this, is anybody paying attention to these mails or they are just being ignored?

Hi Dne Tue, 22 Apr 2014 08:17:07 -0400 Marc Delisle <marc(a)infomarc.info> napsal(a): How you define real bugs? If you mean bugs in our code, then almost all bugs are real (basically all with exception of timeouts when talking with Selenium server), however some of these are bugs in our Selenium tests. Most of these are some timing issues like the Selenium driver is clicking on elements too early (eg. before Javascript initialization is completed).

These are less visible (happen less often) on Jenkins and more visible on Travis (due to higher latencies caused by local proxy used for testing). I've already fixed many of such errors, but I somehow ran out of time I can spend on this, so any help is welcome here. The ideal situation would be to fix these tests completely and do strict Selenium testing in Travis as well to have checked all pull requests with it...