13 Oct
2006
13 Oct
'06
4:34 a.m.
Hi
with SVN it is less painful to rename files, so I'd like to make file
naming in top level directory a bit systematic. I really don't see
reason why SQL tab on database should lead to db_details.php :-).
So what to change?
Shorten tbl_properties_ and db_details_ to tbl_ and db_ and rename
tbl_properties.php and db_details.php to *_sql.
Any other ideas, comments, refusals? :-)
If no objections will appear, I'm going to change this sometimes next
week (probably weekend, but I'll maybe find time sooner to do that).
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
13 Oct
13 Oct
4:44 a.m.
Michal Čihař schrieb:
Any other ideas, comments, refusals? :-)
left.php -> navigation.php
--
Sebastian Mendel
www.sebastianmendel.de
8:41 a.m.
Michal Čihař a écrit :
Hi
with SVN it is less painful to rename files, so I'd like to make file
naming in top level directory a bit systematic. I really don't see
reason why SQL tab on database should lead to db_details.php :-).
So what to change?
Shorten tbl_properties_ and db_details_ to tbl_ and db_ and rename
tbl_properties.php and db_details.php to *_sql.
Any other ideas, comments, refusals? :-)
Good idea, but,
1. I assume you'll do this only in trunk :)
2. Watch out, some logic is based on the script names.
If no objections will appear, I'm going to change this sometimes next
week (probably weekend, but I'll maybe find time sooner to do that).
9:27 a.m.
On Fri, 13 Oct 2006 07:41:00 -0400
Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote:
Good idea, but,
1. I assume you'll do this only in trunk :)
Of course.
2. Watch out, some logic is based on the script names.
I will use grep, don't be afraid :-).
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
9:36 a.m.
Michal Čihař a écrit :
On Fri, 13 Oct 2006 07:41:00 -0400
Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote:
I meant partial script names like
preg_match('@^(tbl_properties|tbl_select)@', $goto))
(strpos(' ' . $action, 'tbl_properties') == 1
Good idea, but,
1. I assume you'll do this only in trunk :)
Of course.
2. Watch out, some logic is based on the script
names.
I will use grep, don't be afraid :-).
9:41 a.m.
On Fri, 13 Oct 2006 08:36:49 -0400
Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote:
I meant partial script names like
preg_match('@^(tbl_properties|tbl_select)@', $goto))
(strpos(' ' . $action, 'tbl_properties') == 1
I know, I will try to handle that, thanks for reminder.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
9:39 a.m.
Michal Čihař schrieb:
search also for something like 'tbl_' . $string
--
Sebastian Mendel
www.sebastianmendel.de
2. Watch out,
some logic is based on the script names.
I will use grep, don't be afraid :-).
25 Oct
25 Oct
9:26 a.m.
Hi all
On Fri, 13 Oct 2006 09:34:05 +0200
Michal Čihař <michal(a)cihar.com> wrote:
Shorten tbl_properties_ and db_details_ to tbl_ and
db_ and rename
tbl_properties.php and db_details.php to *_sql.
I just commited those changes. Please test carefully, I might have
missed some piece of code.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
10:39 a.m.
Michal Čihař a écrit :
Hi all
On Fri, 13 Oct 2006 09:34:05 +0200
Michal Čihař <michal(a)cihar.com> wrote:
There will be a problem for upgrading since we tell users:
"Simply copy ./config.inc.php from your previous installation into the
newly unpacked one."
In older config.inc.php, these directives might be present and if so,
contain the old script name:
$cfg['DefaultTabDatabase']
$cfg['DefaultTabTable']
Do we just warn users about this?
Marc
Shorten tbl_properties_ and db_details_ to tbl_
and db_ and rename
tbl_properties.php and db_details.php to *_sql.
I just commited those changes. Please test carefully, I might have
missed some piece of code.
10:41 a.m.
On Wed, 25 Oct 2006 09:39:16 -0400
Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote:
There will be a problem for upgrading since we tell
users:
"Simply copy ./config.inc.php from your previous installation into the
newly unpacked one."
In older config.inc.php, these directives might be present and if so,
contain the old script name:
$cfg['DefaultTabDatabase']
$cfg['DefaultTabTable']
Do we just warn users about this?
We could add a translation for those...
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
10:56 a.m.
On Wed, 25 Oct 2006 15:41:37 +0200
Michal Čihař <michal(a)cihar.com> wrote:
On Wed, 25 Oct 2006 09:39:16 -0400
Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote:
What about something like attached patch? Anyway do we somewhere check
content of those configuration settings?
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
There will be a problem for upgrading since we
tell users:
"Simply copy ./config.inc.php from your previous installation into the
newly unpacked one."
In older config.inc.php, these directives might be present and if so,
contain the old script name:
$cfg['DefaultTabDatabase']
$cfg['DefaultTabTable']
Do we just warn users about this?
We could add a translation for those...
11:04 a.m.
Michal Čihař a écrit :
On Wed, 25 Oct 2006 15:41:37 +0200
Michal Čihař <michal(a)cihar.com> wrote:
Ok for me. But our initial mistake was to use script names there instead
of a content that describes the functionality needed, and to map
parameter to a script name somewhere in the code, not in the config.
For your other question, we don't check the contents of these directives
but we still need BC.
Marc
On Wed, 25 Oct 2006 09:39:16 -0400
Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote:
What about something like attached patch? Anyway do we somewhere check
content of those configuration settings?
------------------------------------------------------------------------
Index: libraries/Config.class.php
===================================================================
--- libraries/Config.class.php (revision 9597)
+++ libraries/Config.class.php (working copy)
@@ -384,6 +384,16 @@
}
/**
+ * Backward compatibility code
+ */
+ if (!empty($cfg['DefaultTabTable'])) {
+ $cfg['DefaultTabTable'] = str_replace('_properties',
'', str_replace('tbl_properties.php', 'tbl_sql.php',
$cfg['DefaultTabTable']));
+ }
+ if (!empty($cfg['DefaultTabDatabase'])) {
+ $cfg['DefaultTabDatabase'] = str_replace('_details',
'', str_replace('db_details.php', 'db_sql.php',
$cfg['DefaultTabDatabase']));
+ }
+
+ /**
* @todo check validity of $_COOKIE['pma_collation_connection']
*/
if (! empty($_COOKIE['pma_collation_connection'])) { There will be a problem for upgrading since we
tell users:
"Simply copy ./config.inc.php from your previous installation into the
newly unpacked one."
In older config.inc.php, these directives might be present and if so,
contain the old script name:
$cfg['DefaultTabDatabase']
$cfg['DefaultTabTable']
Do we just warn users about this?
We could add a translation for those...
10:56 a.m.
Michal Čihař a écrit :
Hi all
On Fri, 13 Oct 2006 09:34:05 +0200
Michal Čihař <michal(a)cihar.com> wrote:
By the way, testing looks good :)
Marc
Shorten tbl_properties_ and db_details_ to tbl_
and db_ and rename
tbl_properties.php and db_details.php to *_sql.
I just commited those changes. Please test carefully, I might have
missed some piece of code.
6527
days inactive
6539
days old
12 comments
3 participants
participants (3)
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel