On 21 July 2011 17:51, Rouslan Placella rouslan@placella.com wrote:

On Thu, 2011-07-21 at 13:17 +0200, Michal Čihař wrote:

...

Hi all

I've setup continuous testing of phpMyAdmin's code base on http://ci.phpmyadmin.net/.

It is configured to send mails to all people who have commited code while the tests broke. This email is sent to devel mailing list as well.

You can find more details (well not that much right now) on wiki page:

https://wiki.phpmyadmin.net/pma/Continuous_Integration

Which Git repository/branch does this server work from? Is it 'master' or 'unittesting' from sourceforge, or something else completely? Thanks.

Rouslan.

According to logs this is 'origin/master'. git://phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin

-- Zarubin Stas

---

5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

On Fri, 2011-07-22 at 07:24 +0200, Michal Čihař wrote:

Hi

Dne Thu, 21 Jul 2011 15:51:34 +0100 Rouslan Placella rouslan@placella.com napsal(a):

...

On Thu, 2011-07-21 at 13:17 +0200, Michal Čihař wrote:

...

Hi all

I've setup continuous testing of phpMyAdmin's code base on http://ci.phpmyadmin.net/.

It is configured to send mails to all people who have commited code while the tests broke. This email is sent to devel mailing list as well.

You can find more details (well not that much right now) on wiki page:

https://wiki.phpmyadmin.net/pma/Continuous_Integration

Which Git repository/branch does this server work from? Is it 'master' or 'unittesting' from sourceforge, or something else completely?

It's testing master, unittesting is anyway merged to master, it should be probably deleted.

I wrote some unit tests for my features, but I'm not too sure what to do with them. They work fine, but that's my first time writing unit tests, so I'm not too sure if I used all the best practices for them. Should I check them into master? Something else?

Rouslan

On Fri, 2011-07-22 at 12:01 +0200, Michal Čihař wrote:

Hi

Dne Fri, 22 Jul 2011 10:37:42 +0100 Rouslan Placella rouslan@placella.com napsal(a):

...

I wrote some unit tests for my features, but I'm not too sure what to do with them. They work fine, but that's my first time writing unit tests, so I'm not too sure if I used all the best practices for them. Should I check them into master? Something else?

I see you have some changes in testing_rte branch, which definitely should not be merged (like changes in build.xml). Otherwise the tests look okay and IMHO could be merged.

OK, I pushed the tests and deleted my testing_rte branch (it was a mess anyway).

Now, as far as the tests themselves, there is an issue in a few tests where I had to use some hackish code to get the tests to run. For example, in PMA_RTN_getQueryFromRequest_test.php I have this piece of art:

------ >% ------ $cfg['ShowFunctionFields'] = false; eval(substr(file_get_contents('libraries/data_mysql.inc.php'), 5, -3)); ------ >% ------

Here's what I think is the problem here: data_mysql.inc.php is included in some other file before this test is run and then $cfg['ColumnTypes'] is also unset in some other test. So when it's my turn to run a test, simply using require_once does nothing since that file was already executed before :(

Again, not sure if this can/should be fixed, but I thought that it's worth a mention.

Rouslan