2013/12/16 Marc Delisle &lt;marc(a)infomarc.info <mailto:marc@infomarc.info>> Le 2013-12-15 14:36, Hugues Peccatte a écrit : like: rewrite. Good idea but how many levels is considered "too many"? Can you give an example of nesting levels you found? -- Marc Delisle http://infomarc.info | http://phpmyadmin.net ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.cl… _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net <mailto:Phpmyadmin-devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel Hi, To add this new rule won't add to many PHPCS errors. I already test this rule and there are currently not so much this errors in the sources. (I don't have an exact count. I would say around 20-30.) See: http://www.squizlabs.com/php-codesniffer/php_codesniffer-ruleset.xml-suppor… See: http://pear.php.net/manual/en/package.php.php-codesniffer.annotated-ruleset… The rule could be: <rule ref="Generic.Metrics.NestingLevel"> <properties> <property name="nestingLevel" value="2" /> <property name="absoluteNestingLevel" value="5" /> </properties> </rule> We don't need to define both properties. "nestingLevel" is the number of nested level which throw a warning. (default = 5) "absoluteNestingLevel" is the maximum of allowed nested levels. (default = 10) I think that the default values don't need to be overridden, so the rule would be: <rule ref="Generic.Metrics.NestingLevel" /> Hugues.

2013/12/16 Marc Delisle &lt;marc(a)infomarc.info&gt; Hi, I just committed the add of the new rule. Jenkins should find new errors now. [ ... wait for Jenkins result ... ] My estimate was almost good. There are 27 new errors because of the nested levels. I think that many of them could be fixed. I'll look at this. Hugues.

Ok, thanks, I'll look at this and see if new rules seem useful. I didn't think to look in PMD. In my job, all this work is done by PHPCS and I didn't know PMD could do the same... So... I'll look at PMD to see what I could "improve" in the source code.

Hi, 2013/12/20 Michal Čihař &lt;michal(a)cihar.com&gt; Michal, could you please tell me where are defined the rules used by PMD please ?

I'm still thinking about PHPCS and PMD and I've some questions: - would you agree to only use PHPCS if possible ? I would like to see if it's possible to use all the PMD rules (or equivalent) in PHPCS.

- how could you not have this error http://phpmd.org/rules/controversial.html#camelcasepropertyname on Jenkins ? On my IDE, I activated all PMD rules and I've the error in file /libraries/config/ConfigFile.class.php because of property $_defaultCfg (and others which have a leading underscore).

Thanks for your answer. Where do you (de)activate the rules please ? Directly in Jenkins ?

Hi Dne Tue, 24 Dec 2013 17:20:42 +0100 Hugues Peccatte &lt;hugues.peccatte(a)gmail.com&gt; napsal(a): For me it's perfectly fine, not sure if somebody else has other opinion.

Because we don't run controversial rule set (we only run codesize,design,naming,unusedcode). -- Michal Čihař | http://cihar.com | http://blog.cihar.com