Hi Marc & list,
-----Original Message----- From: Rabus [mailto:rabus@bugfixes.info]
Hi Marc,
-----Original Message----- From: Marc Delisle [mailto:DelislMa@CollegeSherbrooke.qc.ca]
Hi Alexander,
https://sourceforge.net/forum/forum.php?thread_id=821146&forum _id=72909
maybe on a version of MySQL that does not support backquotes?
...! The reason for this might be, that I forgot to check for magic_quotes_gpc. Please open a bug report and assign it to me.
This bug should be fixed now. Since I went very deep into the code, I hope that I did not break anything. Happy testing,
Alexander M. Turek alex@bugfixes.info
+-----------------------------+ | The phpMyAdmin Project | | http://www.phpmyadmin.net | | rabus@users.sourceforge.net | +-----------------------------+ | [bugfixes.info] | | http://www.bugfixes.info | | rabus@bugfixes.info | +-----------------------------+
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Rabus [mailto:rabus@bugfixes.info]
Hi Marc,
-----Original Message----- From: Marc Delisle [mailto:DelislMa@CollegeSherbrooke.qc.ca]
Hi Alexander,
https://sourceforge.net/forum/forum.php?thread_id=821146&forum _id=72909
maybe on a version of MySQL that does not support backquotes?
...! The reason for this might be, that I forgot to check for magic_quotes_gpc. Please open a bug report and assign it to me.
This bug should be fixed now. Since I went very deep into the code, I hope that I did not break anything. Happy testing,
Alexander,
After the change, cannot insert a value with a quote in it.
Marc
Hi Marc & list,
-----Original Message----- From: Marc Delisle
After the change, cannot insert a value with a quote in it.
Should be fixed in CVS, now. Regards,
Alexander M. Turek alex@bugfixes.info
+-----------------------------+ | The phpMyAdmin Project | | http://www.phpmyadmin.net | | rabus@users.sourceforge.net | +-----------------------------+ | [bugfixes.info] | | http://www.bugfixes.info | | rabus@bugfixes.info | +-----------------------------+
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Marc Delisle
After the change, cannot insert a value with a quote in it.
Should be fixed in CVS, now. Regards,
Thanks.
Now trying to edit the newly inserted row containing a quote, in the "showing rows" box I get Array Array.
Marc
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:DelislMa@CollegeSherbrooke.qc.ca]
Now trying to edit the newly inserted row containing a quote, in the "showing rows" box I get Array Array.
I cannot reproduce this issue. Editing rows works fine here, with magic_quotes_gpc as well as without.
Alexander M. Turek alex@bugfixes.info
+-----------------------------+ | The phpMyAdmin Project | | http://www.phpmyadmin.net | | rabus@users.sourceforge.net | +-----------------------------+ | [bugfixes.info] | | http://www.bugfixes.info | | rabus@bugfixes.info | +-----------------------------+
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:DelislMa@CollegeSherbrooke.qc.ca]
Now trying to edit the newly inserted row containing a quote, in the "showing rows" box I get Array Array.
I cannot reproduce this issue. Editing rows works fine here, with magic_quotes_gpc as well as without.
Reproduceable on our demo at phpmyadmin.net, see table "marc".
Marc
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:delislma@CollegeSherbrooke.qc.ca]
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:DelislMa@CollegeSherbrooke.qc.ca]
Now trying to edit the newly inserted row containing a quote, in the "showing rows" box I get Array Array.
I cannot reproduce this issue. Editing rows works fine here, with magic_quotes_gpc as well as without.
Reproduceable on our demo at phpmyadmin.net, see table "marc".
I exported your table, tried it on my machine and got the same error here.
I noticed that, in the first box, the pretty-printer appears to be deaktivated automatically somehow. It seems as if the query of the second box has been parsed (the parser returns an array with the tokenized query), but hasn't been passed to the pretty-printer afterwards.
Robin, since you know your code better than me, could you help me with that? I don't want to break more than I already have...
Regards,
Alexander M. Turek alex@bugfixes.info
+-----------------------------+ | The phpMyAdmin Project | | http://www.phpmyadmin.net | | rabus@users.sourceforge.net | +-----------------------------+ | [bugfixes.info] | | http://www.bugfixes.info | | rabus@bugfixes.info | +-----------------------------+
Alexander, in version 2.4.0, I would get this output from the pretty parser showing the UPDATE statement:
UPDATE `marc` SET `c1` = 'L'amie'' WHERE `c1` = 'L'amie' LIMIT 1
and this, for the following SELECT: SELECT * FROM `marc`
In current 2.4.1-dev, I get this: UPDATE `marc` SET `c1` = 'L'amie'' WHERE `c1` = 'L'amie' LIMIT 1; with no pretty colors. Note the unescaped quotes.
And then, calling again the parser in common.lib.php3 line 1297, makes the parser choke. $GLOBALS['SQP_errorString'] contains the error message for unbalanced quote, but the error message is not shown, instead Array Array is displayed.
Marc
What happens is that
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:delislma@CollegeSherbrooke.qc.ca]
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:DelislMa@CollegeSherbrooke.qc.ca]
Now trying to edit the newly inserted row containing a quote, in the "showing rows" box I get Array Array.
I cannot reproduce this issue. Editing rows works fine here, with magic_quotes_gpc as well as without.
Reproduceable on our demo at phpmyadmin.net, see table "marc".
I exported your table, tried it on my machine and got the same error here.
I noticed that, in the first box, the pretty-printer appears to be deaktivated automatically somehow. It seems as if the query of the second box has been parsed (the parser returns an array with the tokenized query), but hasn't been passed to the pretty-printer afterwards.
Robin, since you know your code better than me, could you help me with that? I don't want to break more than I already have...
Regards,
Alexander M. Turek alex@bugfixes.info
+-----------------------------+ | The phpMyAdmin Project | | http://www.phpmyadmin.net | | rabus@users.sourceforge.net | +-----------------------------+ | [bugfixes.info] | | http://www.bugfixes.info | | rabus@bugfixes.info | +-----------------------------+
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger for complex code. Debugging C/C++ programs can leave you feeling lost and disoriented. TotalView can help you find your way. Available on major UNIX and Linux platforms. Try it free. www.etnus.com _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Now fixed, thanks Garvin!
Marc
Marc Delisle wrote:
Alexander, in version 2.4.0, I would get this output from the pretty parser showing the UPDATE statement:
UPDATE `marc` SET `c1` = 'L'amie'' WHERE `c1` = 'L'amie' LIMIT 1
and this, for the following SELECT: SELECT * FROM `marc`
In current 2.4.1-dev, I get this: UPDATE `marc` SET `c1` = 'L'amie'' WHERE `c1` = 'L'amie' LIMIT 1; with no pretty colors. Note the unescaped quotes.
And then, calling again the parser in common.lib.php3 line 1297, makes the parser choke. $GLOBALS['SQP_errorString'] contains the error message for unbalanced quote, but the error message is not shown, instead Array Array is displayed.
Marc
What happens is that
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:delislma@CollegeSherbrooke.qc.ca]
Rabus wrote:
Hi Marc & list,
-----Original Message----- From: Marc Delisle [mailto:DelislMa@CollegeSherbrooke.qc.ca]
Now trying to edit the newly inserted row containing a quote, in the "showing rows" box I get Array Array.
I cannot reproduce this issue. Editing rows works fine here, with magic_quotes_gpc as well as without.
Reproduceable on our demo at phpmyadmin.net, see table "marc".
I exported your table, tried it on my machine and got the same error here.
I noticed that, in the first box, the pretty-printer appears to be deaktivated automatically somehow. It seems as if the query of the second box has been parsed (the parser returns an array with the tokenized query), but hasn't been passed to the pretty-printer afterwards.
Robin, since you know your code better than me, could you help me with that? I don't want to break more than I already have...
Regards,
Alexander M. Turek alex@bugfixes.info
-
Marc Delisle -
Marc Delisle
-
Rabus