Hi Michal and List!
Oops, It seems I didn't read your message before Michal, sorry...
I've tested version in cvs and there are still some problems while adding fields to existing index. Tomorrow I'll have a look at it and probably make some fix of it.
What are these problems and do you manage to fix them?
And there also could be some JavaScript that would disable non-text fields, while selecting index type "FULLTEXT".
Hum, I'll try to have a look at this tomorrow.
To all: two questions about indexes...
1. Do we still need "Primary, Index...." to be displayed in the table properties for each colums? IMHO the patch from Michal is enough and those features are deprecated.
2. What to do whith indexes while creating a table? Should we keep this feature as is (maybe just replace the three checkboxes by a combo) or extend the index creation so it looks like the patch from Michal?
... and one more: what do you think of a 2.2.2-rc1 tomorrow (or maybe a 2.3.0-rc1 since there are a bunch of new functionnalities ?)?
Regards, Loïc
______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif
Hi Loic and list,
I've tested version in cvs and there are still some problems while adding fields to existing index. Tomorrow I'll have a look at it and probably make some fix of it.
What are these problems and do you manage to fix them?
It's a bit unusual, but unfortunately it was the first thing I tried: When I edit any index and I change it's name (also when I change PRIMARY key type to anything else) and then when adding field(s), old index parts get lost. This should be fixed by attached patch.
And there also could be some JavaScript that would disable non-text fields, while selecting index type "FULLTEXT".
Hum, I'll try to have a look at this tomorrow.
Great
To all: two questions about indexes...
- Do we still need "Primary, Index...." to be displayed in the table
properties for each colums? IMHO the patch from Michal is enough and those features are deprecated.
I thing that these actions are not needed anymore, but it is easiest to create index on one field using these actions than using advanced editing...
- What to do whith indexes while creating a table? Should we keep this feature as is (maybe just replace the three checkboxes by a combo) or extend the index creation so it looks like the patch from Michal?
At least there should stay checkbox for primary key.
.. and one more: what do you think of a 2.2.2-rc1 tomorrow (or maybe a 2.3.0-rc1 since there are a bunch of new functionnalities ?)?
I don'k know, whether there is enough new features to 2.3.0 ;o)
But there is at least one bug in current cvs version: when dumping table I get empty inserts, even if table contains some data:
INSERT INTO test VALUES ('', '', '', '', ''); INSERT INTO test VALUES ('', '', '', '', ''); INSERT INTO test VALUES ('', '', '', '', ''); INSERT INTO test VALUES ('', '', '', '', ''); INSERT INTO test VALUES ('', '', '', '', ''); INSERT INTO test VALUES ('', '', '', '', ''); INSERT INTO test VALUES ('', '', '', '', ''); INSERT INTO test VALUES ('', '', '', '', '');
Regards Michal Cihar nijel at users dot sourceforge dot net
Loïc a écrit :
To all: two questions about indexes...
- Do we still need "Primary, Index...." to be displayed in the table
properties for each colums? IMHO the patch from Michal is enough and those features are deprecated.
Difficult question :) For developers it would be easier to maintain only the new style of index creation.
For experimented users, I think it would be cleaner to remove the links and always use the new index module.
However, beginners (and maybe pros) will prefer some quick links to click, than go to a separate index page.
- What to do whith indexes while creating a table? Should we keep this feature as is (maybe just replace the three checkboxes by a combo) or extend the index creation so it looks like the patch from Michal?
I would prefer to remove completely the links and put a message saying that now, phase 1 is fields creation and phase 2 is index creation, available on the properties page.
Maybe go automatically to phase 2!
The new index module needs to have the fields already created, so we will have to have 2 phases.
But there will be complaints :)
If we keep the current checkboxes, users will think that the index possibilities in phpMyAdmin are quite limited. If we remove them, they will see the complete index module on a separate page.
Marc
-
Loïc -
Marc Delisle -
Michal Cihar