Re: [Phpmyadmin-devel] [Phpmyadmin] Interested in Participating in GSoC 2010
Hi, because of the size limit , i am resending the my previous mail but this time in place of attaching the image i am providing a URL URL for image: http://dl.dropbox.com/u/1008346/mock_schema.jpg PFA with this mail as marc Suggested that we should discuss the design with the help of an example, so i have made a mock schema with three tables artist,song and sings.details u can see in the diagram with this mail. i know The Design which i have developed till now is just the beginning draft , lot of discussion and thought has to be put to finalize the design with functionality. Its my Bad to miss the having clause,we can put it in with the Group By option in menu bar(see the diagram). I got a comment from Michal cihar that this time phpMyadmin is selecting only those students who have contributed something before,but i have not contributed to phpmyadmin till now. But i am willing to contribute can anyone please suggest me some bugs to fix and which can be done in the given timeline also please tell where to find documentation for developers,explaining overall structure Thanks, Ankit Gupta 2010/3/31 ANKIT GUPTA <ankitatbits@gmail.com>
Hi,
PFA with this mail as marc Suggested that we should discuss the design with the help of an example, so i have made a mock schema with three tables artist,song and sings.details u can see in the diagram with this mail.
i know The Design which i have developed till now is just the beginning draft , lot of discussion and thought has to be put to finalize the design with functionality.
Its my Bad to miss the having clause,we can put it in with the Group By option in menu bar(see the diagram).
I got a comment from Michal cihar that this time phpMyadmin is selecting only those students who have contributed something before,but i have not contributed to phpmyadmin till now. But i am willing to contribute can anyone please suggest me some bugs to fix and which can be done in the given timeline also please tell where to find documentation for developers,explaining overall structure
Thanks, Ankit Gupta
---------- Forwarded message ---------- From: Michal Čihař <michal@cihar.com> Date: Wed, Mar 31, 2010 at 7:39 PM Subject: Re: [Phpmyadmin-devel] [Phpmyadmin] Interested in Participating in GSoC 2010 To: phpmyadmin-devel@lists.sourceforge.net
Hi
Dne Tue, 30 Mar 2010 23:06:43 +0530 ANKIT GUPTA <ankitatbits@gmail.com> napsal(a):
i have already tried that command but it is also not working,i am getting following error fatal:unable to connect a socket (connection timed out).
See
http://wiki.phpmyadmin.net/pma/Devel:Git#Accessing_Git_repository_from_behin...
I also want to discuss about the design for visual query designer,i have thought of some points like to add an option button with each selected attribute of table where we will have a menu bar with following fields GROUP ,ORDER ,Rename and Where. As user selects option from this menu bar other boxes/options will appear as the case is.
i am planing to implement select from clause,joins,group by order by and various aggregate function in query builder.you can check further details in my Gscoc Application .
please suggest any other functionality which we can add or any additional features in the design.
You did not explicitely mention HAVING clause...
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi, On 3/31/2010 12:43 PM, ANKIT GUPTA wrote: [snip]
I got a comment from Michal cihar that this time phpMyadmin is selecting only those students who have contributed something before,but i have not contributed to phpmyadmin till now. But i am willing to contribute can anyone please suggest me some bugs to fix and which can be done in the given timeline also please tell where to find documentation for developers,explaining overall structure
A good place to start is http://wiki.phpmyadmin.net/pma/Devel:Junior for small code contribution ideas and http://wiki.phpmyadmin.net/pma/Devel:Main and http://www.phpmyadmin.net/phpdoc/ for documentation
ANKIT GUPTA a écrit :
Hi,
because of the size limit , i am resending the my previous mail but this time in place of attaching the image i am providing a URL
URL for image: http://dl.dropbox.com/u/1008346/mock_schema.jpg
PFA with this mail as marc Suggested that we should discuss the design with the help of an example, so i have made a mock schema with three tables artist,song and sings.details u can see in the diagram with this mail.
i know The Design which i have developed till now is just the beginning draft , lot of discussion and thought has to be put to finalize the design with functionality.
Hi Ankit, I had a look at your image. I'm not sure what you mean by "select the relations arrows which we need for the query". I think that in a query builder, the user should be able to specify what he needs just in terms of tables and columns, and the product should build the correct joins. -- Marc Delisle http://infomarc.info
Hello marc, yes you are right,that there is no need to explicitly ask the user to "select relation arrows", but i want to provide users with an option to select the Join type(inner,outer,left,right). i have not mentioned any details for writing Nested Sub queries.till now i don't have a good design to implement them......and am still working on it. Thanks Ankit 2010/4/1 Marc Delisle <marc@infomarc.info>
ANKIT GUPTA a écrit :
Hi,
because of the size limit , i am resending the my previous mail but this time in place of attaching the image i am providing a URL
URL for image: http://dl.dropbox.com/u/1008346/mock_schema.jpg
PFA with this mail as marc Suggested that we should discuss the design with the help of an example, so i have made a mock schema with three tables artist,song and sings.details u can see in the diagram with this mail.
i know The Design which i have developed till now is just the beginning draft , lot of discussion and thought has to be put to finalize the design with functionality.
Hi Ankit,
I had a look at your image. I'm not sure what you mean by "select the relations arrows which we need for the query". I think that in a query builder, the user should be able to specify what he needs just in terms of tables and columns, and the product should build the correct joins.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
hi, I have improved the previous design check the image: http://dl.dropbox.com/u/1008346/schema.jpg examples: For the example in image we will select name checkbox. and then select S_LANG in song table there we will go to the option and click on the where button a small where window will come here we will use the drop down menu to select = and in the textbox we will write English,and press Ok one entry will be added to the history table,repeat the process to for HINDI. after all this we will select the AND rule by writing (1 and 2).and then submit . Problems The Sub-query option provided with where and having,here user has to type in the sub query no visual building options. please discuss this design and share your thoughts and suggestion . we can discuss by taking any other query of your choice. Thanks, Ankit On Thu, Apr 1, 2010 at 6:36 PM, ANKIT GUPTA <ankitatbits@gmail.com> wrote:
Hello marc,
yes you are right,that there is no need to explicitly ask the user to "select relation arrows", but i want to provide users with an option to select the Join type(inner,outer,left,right).
i have not mentioned any details for writing Nested Sub queries.till now i don't have a good design to implement them......and am still working on it.
Thanks Ankit
2010/4/1 Marc Delisle <marc@infomarc.info>
ANKIT GUPTA a écrit :
Hi,
because of the size limit , i am resending the my previous mail but this time in place of attaching the image i am providing a URL
URL for image: http://dl.dropbox.com/u/1008346/mock_schema.jpg
PFA with this mail as marc Suggested that we should discuss the design with the help of an example, so i have made a mock schema with three tables artist,song and sings.details u can see in the diagram with this mail.
i know The Design which i have developed till now is just the beginning draft , lot of discussion and thought has to be put to finalize the design with functionality.
Hi Ankit,
I had a look at your image. I'm not sure what you mean by "select the relations arrows which we need for the query". I think that in a query builder, the user should be able to specify what he needs just in terms of tables and columns, and the product should build the correct joins.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
ANKIT GUPTA a écrit :
hi,
I have improved the previous design check the image:
http://dl.dropbox.com/u/1008346/schema.jpg
examples: For the example in image we will select name checkbox. and then select S_LANG in song table there we will go to the option and click on the where button a small where window will come here we will use the drop down menu to select = and in the textbox we will write English,and press Ok one entry will be added to the history table,repeat the process to for HINDI. after all this we will select the AND rule by writing (1 and 2).and then submit .
Yes, this is better. I'm not sure about the joins; I appreciate to have the choice of join type but I hope that your project will take care of generating by default some correct left joins. Please update your proposal on http://socghop.appspot.com. Note: their interface adds white lines, please remove them during your editing session. -- Marc Delisle http://infomarc.info
Hi, will update my proposal. for the sub query option with "where" we still don't have any visual builder............... one way which i thought was having a link ->"build query" which will open a complete new query building window . but this will make thing complex and i don't want to show a new window. what you think?? also i have started looking through the code for phpMyadmin , can u suggest me what all sections in present code are related and can be used for visual query building this will be of great help . Thanks, On Sat, Apr 3, 2010 at 6:35 PM, Marc Delisle <marc@infomarc.info> wrote:
ANKIT GUPTA a écrit :
hi,
I have improved the previous design check the image:
http://dl.dropbox.com/u/1008346/schema.jpg
examples: For the example in image we will select name checkbox. and then select S_LANG in song table there we will go to the option and click on the where button a small where window will come here we will use the drop down menu to select = and in the textbox we will write English,and press Ok one entry will be added to the history table,repeat the process to for HINDI. after all this we will select the AND rule by writing (1 and 2).and then submit .
Yes, this is better. I'm not sure about the joins; I appreciate to have the choice of join type but I hope that your project will take care of generating by default some correct left joins.
Please update your proposal on http://socghop.appspot.com.
Note: their interface adds white lines, please remove them during your editing session.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
ANKIT GUPTA a écrit :
Hi,
will update my proposal.
for the sub query option with "where" we still don't have any visual builder............... one way which i thought was having a link ->"build query" which will open a complete new query building window . but this will make thing complex and i don't want to show a new window. what you think??
also i have started looking through the code for phpMyadmin , can u suggest me what all sections in present code are related and can be used for visual query building this will be of great help .
The current multi-tables query builder is located in db_qbe.php. -- Marc Delisle http://infomarc.info
ANKIT GUPTA wrote:
Hi,
will update my proposal.
for the sub query option with "where" we still don't have any visual builder............... one way which i thought was having a link ->"build query" which will open a complete new query building window . but this will make thing complex and i don't want to show a new window. what you think??
Making this nestable might add a natural force to write clean re-usable code. But the risk of making this to complex seems very serious.
also i have started looking through the code for phpMyadmin , can u suggest me what all sections in present code are related and can be used for visual query building this will be of great help . Besides the Designer I'd look at the relational code for innodb and the internally stored relations for myisam. And obviously the Query tab.
-- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions
Hi, I also think that making a separate window will make things complex. so i think we will stick to the present design as of now, until something new comes. i have almost fixed the bug *Sync S + D : only S - ID: 2981127* now am just doing the testing. I found one more bug in the synchronization tab. once the "Apply Selected button" is pressed. we see extra "G" button for empty tables also.which was not coming before this button click. i will fix this as a separate bug. Regards, Ankit *** * On Tue, Apr 6, 2010 at 8:15 PM, Herman van Rink <rink@initfour.nl> wrote:
ANKIT GUPTA wrote:
Hi,
will update my proposal.
for the sub query option with "where" we still don't have any visual builder............... one way which i thought was having a link ->"build query" which will open a complete new query building window . but this will make thing complex and i don't want to show a new window. what you think??
Making this nestable might add a natural force to write clean re-usable code. But the risk of making this to complex seems very serious.
also i have started looking through the code for phpMyadmin , can u suggest me what all sections in present code are related and can be used for visual query building this will be of great help .
Besides the Designer I'd look at the relational code for innodb and the internally stored relations for myisam. And obviously the Query tab.
-- Met vriendelijke groet / Regards,
Herman van Rink Initfour websolutions
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi, i have fixed the bug http://sourceforge.net/tracker/?func=detail&aid=2981127&group_id=23067&atid=... . a small change in the file "server_synchronize_lib.php " . Thanks, Ankit On Wed, Apr 7, 2010 at 3:24 AM, ANKIT GUPTA <ankitatbits@gmail.com> wrote:
Hi,
I also think that making a separate window will make things complex. so i think we will stick to the present design as of now, until something new comes.
i have almost fixed the bug *Sync S + D : only S - ID: 2981127* now am just doing the testing.
I found one more bug in the synchronization tab. once the "Apply Selected button" is pressed. we see extra "G" button for empty tables also.which was not coming before this button click.
i will fix this as a separate bug.
Regards, Ankit ***
* On Tue, Apr 6, 2010 at 8:15 PM, Herman van Rink <rink@initfour.nl> wrote:
ANKIT GUPTA wrote:
Hi,
will update my proposal.
for the sub query option with "where" we still don't have any visual builder............... one way which i thought was having a link ->"build query" which will open a complete new query building window . but this will make thing complex and i don't want to show a new window. what you think??
Making this nestable might add a natural force to write clean re-usable code. But the risk of making this to complex seems very serious.
also i have started looking through the code for phpMyadmin , can u suggest me what all sections in present code are related and can be used for visual query building this will be of great help .
Besides the Designer I'd look at the relational code for innodb and the internally stored relations for myisam. And obviously the Query tab.
-- Met vriendelijke groet / Regards,
Herman van Rink Initfour websolutions
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
ANKIT GUPTA a écrit :
Hi, i have fixed the bug http://sourceforge.net/tracker/?func=detail&aid=2981127&group_id=23067&atid=... <http://sourceforge.net/tracker/?func=detail&aid=2981127&group_id=23067&atid=377408>.
a small change in the file "server_synchronize_lib.php " .
Thanks, Ankit
Please upload your patch to the Patches tracker : https://sourceforge.net/tracker/?func=browse&group_id=23067&atid=377410 -- Marc Delisle http://infomarc.info
Hi, i still have problems with downloading git on my college network i am trying to find a solution for that. hopefully by tomorrow i will find a machine with git. to solve the bug i have made some changes in the file "server_synchronize_lib.php ". if u want i can send u this file on mail or can tell u all the changes (there are not many changes). as you say Regards, Ankit On Thu, Apr 8, 2010 at 2:38 AM, Marc Delisle <marc@infomarc.info> wrote:
ANKIT GUPTA a écrit :
Hi, i have fixed the bug
http://sourceforge.net/tracker/?func=detail&aid=2981127&group_id=23067&atid=...
< http://sourceforge.net/tracker/?func=detail&aid=2981127&group_id=23067&atid=... .
a small change in the file "server_synchronize_lib.php " .
Thanks, Ankit
Please upload your patch to the Patches tracker : https://sourceforge.net/tracker/?func=browse&group_id=23067&atid=377410
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
ANKIT GUPTA a écrit :
Hi,
i still have problems with downloading git on my college network i am trying to find a solution for that. hopefully by tomorrow i will find a machine with git. to solve the bug i have made some changes in the file "server_synchronize_lib.php ". if u want i can send u this file on mail or can tell u all the changes (there are not many changes). as you say
Do you have access to the diff command? If not, mail me the file, I'll generate the diff and mail it back to you :) -- Marc Delisle http://infomarc.info
Hi, sorry for the trouble. i am sending u one file "server_synchronize_lib.php" with this mail. also as mentioned in my previous mail there is one more bug in the synchronization section. now i have started working on it. Thanks Ankit Gupta On Thu, Apr 8, 2010 at 2:56 AM, Marc Delisle <marc@infomarc.info> wrote:
ANKIT GUPTA a écrit :
Hi,
i still have problems with downloading git on my college network i am trying to find a solution for that. hopefully by tomorrow i will find a machine with git. to solve the bug i have made some changes in the file "server_synchronize_lib.php ". if u want i can send u this file on mail or can tell u all the changes (there are not many changes). as you say
Do you have access to the diff command? If not, mail me the file, I'll generate the diff and mail it back to you :)
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
ANKIT GUPTA a écrit :
Hi, sorry for the trouble. i am sending u one file "server_synchronize_lib.php" with this mail.
also as mentioned in my previous mail there is one more bug in the synchronization section. now i have started working on it.
Thanks Ankit Gupta
The attached file would be your patch, look at it to confirm that these are your changes. If it's ok, upload it to the Patches tracker. P.S. you'll need to find a way to generate patches... -- Marc Delisle http://infomarc.info *** pma-git/phpmyadmin/libraries/server_synchronize.lib.php 2010-04-07 17:31:22.665485919 -0400 --- server_synchronize.lib.php 2010-04-07 17:40:36.395117798 -0400 *************** *** 671,681 **** function PMA_populateTargetTables($src_db, $trg_db, $src_link, $trg_link, $uncommon_tables, $table_index, $uncommon_tables_fields, $display) { $display = false; // todo: maybe display some of the queries if they are not too numerous - $unbuffered_result = PMA_DBI_try_query('SELECT * FROM ' . PMA_backquote($src_db) . '.' . PMA_backquote($uncommon_tables[$table_index]), $src_link, PMA_DBI_QUERY_UNBUFFERED); if (false !== $unbuffered_result) { ! while ($one_row = PMA_DBI_fetch_row($unbuffered_result)) { ! $insert_query = 'INSERT INTO ' . PMA_backquote($trg_db) . '.' .PMA_backquote($uncommon_tables[$table_index]) . ' VALUES('; $key_of_last_value = count($one_row) - 1; foreach($one_row as $key => $value) { $insert_query .= "'" . PMA_sqlAddslashes($value) . "'"; --- 671,681 ---- function PMA_populateTargetTables($src_db, $trg_db, $src_link, $trg_link, $uncommon_tables, $table_index, $uncommon_tables_fields, $display) { $display = false; // todo: maybe display some of the queries if they are not too numerous $unbuffered_result = PMA_DBI_try_query('SELECT * FROM ' . PMA_backquote($src_db) . '.' . PMA_backquote($uncommon_tables[$table_index]), $src_link, PMA_DBI_QUERY_UNBUFFERED); if (false !== $unbuffered_result) { ! $insert_query = 'INSERT INTO ' . PMA_backquote($trg_db) . '.' .PMA_backquote($uncommon_tables[$table_index]) . ' VALUES'; ! while ($one_row = PMA_DBI_fetch_row($unbuffered_result)) { ! $insert_query.='('; $key_of_last_value = count($one_row) - 1; foreach($one_row as $key => $value) { $insert_query .= "'" . PMA_sqlAddslashes($value) . "'"; *************** *** 683,694 **** $insert_query .= ","; } } ! $insert_query .= ');'; ! if ($display == true) { ! PMA_displayQuery($insert_query); ! } ! PMA_DBI_try_query($insert_query, $trg_link, 0); } } } /** --- 683,696 ---- $insert_query .= ","; } } ! $insert_query .= '),'; ! } ! $insert_query=substr($insert_query,0,-1); ! $insert_query.=';'; ! if ($display == true) { ! PMA_displayQuery($insert_query); } + PMA_DBI_try_query($insert_query, $trg_link, 0); } } /**
Hi, yes those were the changes, thank you for the patch file. by the next time i will make sure to have a git machine and will generate patches by myself. i have uploaded my patch https://sourceforge.net/tracker/?func=detail&aid=2983492&group_id=23067&atid... Thanks, Ankit On Thu, Apr 8, 2010 at 3:15 AM, Marc Delisle <marc@infomarc.info> wrote:
ANKIT GUPTA a écrit :
Hi,
sorry for the trouble. i am sending u one file "server_synchronize_lib.php" with this mail.
also as mentioned in my previous mail there is one more bug in the synchronization section. now i have started working on it.
Thanks Ankit Gupta
The attached file would be your patch, look at it to confirm that these are your changes.
If it's ok, upload it to the Patches tracker.
P.S. you'll need to find a way to generate patches...
-- Marc Delisle http://infomarc.info
*** pma-git/phpmyadmin/libraries/server_synchronize.lib.php 2010-04-07 17:31:22.665485919 -0400 --- server_synchronize.lib.php 2010-04-07 17:40:36.395117798 -0400 *************** *** 671,681 **** function PMA_populateTargetTables($src_db, $trg_db, $src_link, $trg_link, $uncommon_tables, $table_index, $uncommon_tables_fields, $display) { $display = false; // todo: maybe display some of the queries if they are not too numerous - $unbuffered_result = PMA_DBI_try_query('SELECT * FROM ' . PMA_backquote($src_db) . '.' . PMA_backquote($uncommon_tables[$table_index]), $src_link, PMA_DBI_QUERY_UNBUFFERED); if (false !== $unbuffered_result) { ! while ($one_row = PMA_DBI_fetch_row($unbuffered_result)) { ! $insert_query = 'INSERT INTO ' . PMA_backquote($trg_db) . '.' .PMA_backquote($uncommon_tables[$table_index]) . ' VALUES('; $key_of_last_value = count($one_row) - 1; foreach($one_row as $key => $value) { $insert_query .= "'" . PMA_sqlAddslashes($value) . "'"; --- 671,681 ---- function PMA_populateTargetTables($src_db, $trg_db, $src_link, $trg_link, $uncommon_tables, $table_index, $uncommon_tables_fields, $display) { $display = false; // todo: maybe display some of the queries if they are not too numerous $unbuffered_result = PMA_DBI_try_query('SELECT * FROM ' . PMA_backquote($src_db) . '.' . PMA_backquote($uncommon_tables[$table_index]), $src_link, PMA_DBI_QUERY_UNBUFFERED); if (false !== $unbuffered_result) { ! $insert_query = 'INSERT INTO ' . PMA_backquote($trg_db) . '.' .PMA_backquote($uncommon_tables[$table_index]) . ' VALUES'; ! while ($one_row = PMA_DBI_fetch_row($unbuffered_result)) { ! $insert_query.='('; $key_of_last_value = count($one_row) - 1; foreach($one_row as $key => $value) { $insert_query .= "'" . PMA_sqlAddslashes($value) . "'"; *************** *** 683,694 **** $insert_query .= ","; } } ! $insert_query .= ');'; ! if ($display == true) { ! PMA_displayQuery($insert_query); ! } ! PMA_DBI_try_query($insert_query, $trg_link, 0); } } } /** --- 683,696 ---- $insert_query .= ","; } } ! $insert_query .= '),'; ! } ! $insert_query=substr($insert_query,0,-1); ! $insert_query.=';'; ! if ($display == true) { ! PMA_displayQuery($insert_query); } + PMA_DBI_try_query($insert_query, $trg_link, 0); } } /**
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi, On 4/7/2010 6:11 PM, ANKIT GUPTA wrote: [snip]
by the next time i will make sure to have a git machine and will generate patches by myself.
Even without git you can generate patch files -- on Windows use the graphical WinMerge [1] or command-line based GnuWin32 [2] or unxutils [3] ports of diffutils. For *nix, *bsd, etc just use your distribution's flavor of diffutils or install it yourself for that matter. [snip] ~isaac 1 - http://winmerge.org/ 2 - http://gnuwin32.sourceforge.net/packages/diffutils.htm 3 - http://unxutils.sourceforge.net/
participants (4)
-
ANKIT GUPTA -
Herman van Rink -
Isaac Bennetch -
Marc Delisle