Hi,
i've done a little rewriting of all this qerywindow javascript stuff, coming with this is
* XHTML comlinace at least in index.php and left.php * more semantic XHTML * moved all styling into css * url param support for index.php (index.php?db=mysql) * less JavaScript * better support for non JS Browsers * ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&gr...
Sebastian Mendel wrote:
Hi,
i've done a little rewriting of all this qerywindow javascript stuff, coming with this is
- XHTML comlinace at least in index.php and left.php
- more semantic XHTML
- moved all styling into css
- url param support for index.php (index.php?db=mysql)
- less JavaScript
- better support for non JS Browsers
- ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&gr...
i would like to commit this into CVS, if no one is against.
Marc? Michal?
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i would like to commit this into CVS, if no one is against.
I just quickly looked at the patch, My comments follow. The all do not address new code, however when the code is being touched, it could be cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css - do not change error reporting - you can rely on fact that all cfg parameters are set, this includes PmaAbsoluteUri - I'm absolutely not sure about browser dependant css you removed from theme - did you intentionally remove +/- signs in front of expanded/non expanded database in left frame? - tables and databases are now printed same colour in left frame, I think different colour was better - frameset contains urls like left.php?&lang=cs-utf-8, there is extra &
Michal Čihař wrote:
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i would like to commit this into CVS, if no one is against.
I just quickly looked at the patch, My comments follow. The all do not address new code, however when the code is being touched, it could be cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css
i will take a look at this,
- do not change error reporting
fixed lokaly, forgot to remove before creating the patch file
- you can rely on fact that all cfg parameters are set, this includes
PmaAbsoluteUri
changed in index.php and left.php
- I'm absolutely not sure about browser dependant css you removed from
theme
tested with IE 6, 5.5, 5, Opera, Firefox and complies with my experience with CSS
- did you intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded and needs no +/-, or is this missing anywhere else?
- tables and databases are now printed same colour in left frame, I
think different colour was better
i will take a look at this
- frameset contains urls like left.php?&lang=cs-utf-8, there is
extra &
for sure? i cant reproduce
On Tue 4. 10. 2005 11:59, Sebastian Mendel wrote:
Michal Čihař wrote:
- I'm absolutely not sure about browser dependant css you removed
from theme
tested with IE 6, 5.5, 5, Opera, Firefox and complies with my experience with CSS
Well there were some hacks for IE 4, however I don't know whether it is still necessary to support this.
- did you intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded and needs no +/-, or is this missing anywhere else?
Maybe you miss $cfg['LeftFrameLight'] = FALSE; or I don't understand your question.
- frameset contains urls like left.php?&lang=cs-utf-8, there is
extra &
for sure? i cant reproduce
Sure, just copy and paste from generated source ;-). It comes from $url_query = implode( '&', $url_querys ) . '&'; if $url_querys is empty.
You also dropped support for LeftPointerEnable (I didn't notice it yet, as I disabled it anyway :-))
Michal Čihař wrote:
On Tue 4. 10. 2005 11:59, Sebastian Mendel wrote:
Michal Čihař wrote:
- I'm absolutely not sure about browser dependant css you removed
from theme
tested with IE 6, 5.5, 5, Opera, Firefox and complies with my experience with CSS
Well there were some hacks for IE 4, however I don't know whether it is still necessary to support this.
IE 4 works 'well', except that you have an intended html unordered list (as the unordered list layout cant be changed by CSS on IE 4)
- did you intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded and needs no +/-, or is this missing anywhere else?
Maybe you miss $cfg['LeftFrameLight'] = FALSE; or I don't understand your question.
i did not intentionally removed any +/-, only where only one db is available, so this db is always expanded - just to clear out, send me a screenshot
- frameset contains urls like left.php?&lang=cs-utf-8, there is
extra &
for sure? i cant reproduce
Sure, just copy and paste from generated source ;-). It comes from $url_query = implode( '&', $url_querys ) . '&'; if $url_querys is empty.
oh, ok, fixed ;-)
You also dropped support for LeftPointerEnable (I didn't notice it yet, as I disabled it anyway :-))
this JavaScript simulated hover effect? yes i dropped it
- i will add a css based hover effect
anyone against this?
On Tue 4. 10. 2005 12:30, Sebastian Mendel wrote:
- did you intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded and needs no +/-, or is this missing anywhere else?
Maybe you miss $cfg['LeftFrameLight'] = FALSE; or I don't understand your question.
i did not intentionally removed any +/-, only where only one db is available, so this db is always expanded - just to clear out, send me a screenshot
Attached. I also see you changed separator behaviour as you do not stript it, this should work as before.
You also dropped support for LeftPointerEnable (I didn't notice it yet, as I disabled it anyway :-))
this JavaScript simulated hover effect? yes i dropped it
- i will add a css based hover effect
anyone against this?
Yes, I do not like it, do not add it to default themes ;-). Just remove the config option and documentation for it.
Michal Čihař wrote:
On Tue 4. 10. 2005 12:30, Sebastian Mendel wrote:
- did you intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded and needs no +/-, or is this missing anywhere else?
Maybe you miss $cfg['LeftFrameLight'] = FALSE; or I don't understand your question.
i did not intentionally removed any +/-, only where only one db is available, so this db is always expanded - just to clear out, send me a screenshot
Attached.
the icon has a size of 0.9em (90% of font size), as your font is very small the icon is scaled down ... i will look into this
I also see you changed separator behaviour as you do not stript it, this should work as before.
ok
Michal Čihař wrote:
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i would like to commit this into CVS, if no one is against.
I just quickly looked at the patch, My comments follow. The all do not address new code, however when the code is being touched, it could be cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css
- do not change error reporting
- you can rely on fact that all cfg parameters are set, this includes
PmaAbsoluteUri
also $GLOBALS['cfg']['Bookmark']['db'] ?
if ( ! empty( $GLOBALS['cfg']['Bookmark'] ) && $GLOBALS['cfg']['Bookmark']['db'] && $GLOBALS['cfg']['Bookmark']['table'] ) {
can become
if ( $GLOBALS['cfg']['Bookmark']['db'] && $GLOBALS['cfg']['Bookmark']['table'] ) {
?
On Tue 4. 10. 2005 13:04, Sebastian Mendel wrote:
Michal Čihař wrote:
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i would like to commit this into CVS, if no one is against.
I just quickly looked at the patch, My comments follow. The all do not address new code, however when the code is being touched, it could be cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css
- do not change error reporting
- you can rely on fact that all cfg parameters are set, this
includes PmaAbsoluteUri
also $GLOBALS['cfg']['Bookmark']['db'] ?
If there is server selected PMA_getBookmarksParam will fill it.
Sebastian Mendel a écrit :
Sebastian Mendel wrote:
Hi,
i've done a little rewriting of all this qerywindow javascript stuff, coming with this is
- XHTML comlinace at least in index.php and left.php
- more semantic XHTML
- moved all styling into css
- url param support for index.php (index.php?db=mysql)
- less JavaScript
- better support for non JS Browsers
- ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&gr...
i would like to commit this into CVS, if no one is against.
Marc? Michal?
A few comments (as a user) under Firefox:
- In the left panel, I no longer see the number of rows for each table. When hovering the small icon, I only see "Browse:".
- when creating/dropping a table, the left frame does not refresh
Marc
Marc Delisle wrote:
Sebastian Mendel a écrit :
Sebastian Mendel wrote:
Hi,
i've done a little rewriting of all this qerywindow javascript stuff, coming with this is
- XHTML comlinace at least in index.php and left.php
- more semantic XHTML
- moved all styling into css
- url param support for index.php (index.php?db=mysql)
- less JavaScript
- better support for non JS Browsers
- ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&gr...
i would like to commit this into CVS, if no one is against.
Marc? Michal?
A few comments (as a user) under Firefox:
- In the left panel, I no longer see the number of rows for each table.
When hovering the small icon, I only see "Browse:".
yes, i noticed this yesterday fixed locally ...
- when creating/dropping a table, the left frame does not refresh
looking into this ...
Sebastian Mendel wrote:
Hi,
i've done a little rewriting of all this qerywindow javascript stuff, coming with this is
- XHTML comlinace at least in index.php and left.php
- more semantic XHTML
- moved all styling into css
- url param support for index.php (index.php?db=mysql)
- less JavaScript
- better support for non JS Browsers
- ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&gr...
ok, i think i have adressed all issues mentioned here, i will check in in now ...
Hi!
ok, i think i have adressed all issues mentioned here, i will check in in now ...
The tabs still look broken like the screenshot I posted a week ago, with misaligned borders on the "Search" tab and the CSS for one of the nested tables ("backup") of the HTML source I posted you some time ago is still formated differently than the other tables?
(Just wanted to drop those two issues - if they're not related to what you meant, please disregard this posting. The refresh of the left frame after selecting a table is gone now, thanks a lot! :-)
Best regards, Garvin
Garvin Hicking wrote:
Hi!
ok, i think i have adressed all issues mentioned here, i will check in in now ...
The tabs still look broken like the screenshot I posted a week ago, with misaligned borders on the "Search" tab
The 'tabs' in the server/db/table navigation?
and the CSS for one of the nested tables ("backup") of the HTML source I posted you some time ago is still formated differently than the other tables?
'differently formated' means it have a different color? font size and type should be the same.
(Just wanted to drop those two issues - if they're not related to what you meant, please disregard this posting. The refresh of the left frame after selecting a table is gone now, thanks a lot! :-)
-
Garvin Hicking -
Marc Delisle -
Michal Čihař -
Sebastian Mendel