[Phpmyadmin-devel] Drop flashcanvas
Hi all After seeing [Debian bug about sourceless flash file][1], I went to looking why do we have this at all. It seems to be used for IE 8 and older to render charts as the browser does not have native support for canvas. I've done a little bit of testing with IE 8 (using Browser Stack) and none of the rendering seems to work properly there: - the GIS rendering ends up with javascript error showing nothing [*] - the pie chart for profiling does not show areas - other charts show different level of corruption As nobody has complained about this so far, I believe it's better to simply drop this code than trying to fix it to work with this ancient browser. So here is [my pull request to do so][2]. [1]:http://bugs.debian.org/737432 [2]:https://github.com/phpmyadmin/phpmyadmin/pull/887 [*]: What revealed that javascript error reporting is broken in IE 8 as I was not able to see the report details and submit it. So maybe it's really time to say we do not support IE 8 as there might be more of so broken things... -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
On Mon, Feb 3, 2014 at 6:09 PM, Michal Čihař <michal@cihar.com> wrote:
Hi all
After seeing [Debian bug about sourceless flash file][1], I went to looking why do we have this at all. It seems to be used for IE 8 and older to render charts as the browser does not have native support for canvas.
I've done a little bit of testing with IE 8 (using Browser Stack) and none of the rendering seems to work properly there:
- the GIS rendering ends up with javascript error showing nothing [*] - the pie chart for profiling does not show areas - other charts show different level of corruption
As nobody has complained about this so far, I believe it's better to simply drop this code than trying to fix it to work with this ancient browser. So here is [my pull request to do so][2].
+1
-- Thanks and Regards, Madhura Jayaratne
Michal Čihař a écrit :
Hi all
After seeing [Debian bug about sourceless flash file][1], I went to looking why do we have this at all. It seems to be used for IE 8 and older to render charts as the browser does not have native support for canvas.
I've done a little bit of testing with IE 8 (using Browser Stack) and none of the rendering seems to work properly there:
- the GIS rendering ends up with javascript error showing nothing [*] - the pie chart for profiling does not show areas - other charts show different level of corruption
As nobody has complained about this so far, I believe it's better to simply drop this code than trying to fix it to work with this ancient browser. So here is [my pull request to do so][2].
[1]:http://bugs.debian.org/737432 [2]:https://github.com/phpmyadmin/phpmyadmin/pull/887
[*]: What revealed that javascript error reporting is broken in IE 8 as I was not able to see the report details and submit it. So maybe it's really time to say we do not support IE 8 as there might be more of so broken things...
Ok for dropping the code, but we did not mention dropping support for IE 8 when releasing 4.1.0. Can we wait announcing that until the 4.2.0 release? -- Marc Delisle http://infomarc.info | http://phpmyadmin.net
Hi Dne Mon, 03 Feb 2014 08:52:29 -0500 Marc Delisle <marc@infomarc.info> napsal(a):
Ok for dropping the code, but we did not mention dropping support for IE 8 when releasing 4.1.0. Can we wait announcing that until the 4.2.0 release?
Well as functionality using flashcanvas is broken anyway, I don't think dropping it makes any difference to current state :-). But this can be still considered minor feature which is not really needed to make use of phpMyAdmin in IE 8. -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
On 2/3/14 9:10 AM, Michal Čihař wrote:
Hi
Dne Mon, 03 Feb 2014 08:52:29 -0500 Marc Delisle <marc@infomarc.info> napsal(a):
Ok for dropping the code, but we did not mention dropping support for IE 8 when releasing 4.1.0. Can we wait announcing that until the 4.2.0 release?
Well as functionality using flashcanvas is broken anyway, I don't think dropping it makes any difference to current state :-). But this can be still considered minor feature which is not really needed to make use of phpMyAdmin in IE 8.
Perhaps we strive to make most functionality work on IE8 but don't jump through hoops to make something like flashcanvas work. So the requirements section could read something like "To access phpMyAdmin you need a modern web browser with cookies and javascript enabled. <br> Not all features may work with Internet Explorer 8 or older or Firefox 2.0 and older."
Hi Dne Mon, 03 Feb 2014 09:15:16 -0500 Isaac Bennetch <bennetch@gmail.com> napsal(a):
Perhaps we strive to make most functionality work on IE8 but don't jump through hoops to make something like flashcanvas work. So the requirements section could read something like "To access phpMyAdmin you need a modern web browser with cookies and javascript enabled. <br> Not all features may work with Internet Explorer 8 or older or Firefox 2.0 and older."
Yes, this sounds fair. -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Michal Čihař a écrit :
Hi all
After seeing [Debian bug about sourceless flash file][1], I went to looking why do we have this at all. It seems to be used for IE 8 and older to render charts as the browser does not have native support for canvas.
I've done a little bit of testing with IE 8 (using Browser Stack) and none of the rendering seems to work properly there:
- the GIS rendering ends up with javascript error showing nothing [*] - the pie chart for profiling does not show areas - other charts show different level of corruption
I confirm the problems on a real IE 8. -- Marc Delisle http://infomarc.info | http://phpmyadmin.net
Hi Dne Mon, 3 Feb 2014 13:39:24 +0100 Michal Čihař <michal@cihar.com> napsal(a):
As nobody has complained about this so far, I believe it's better to simply drop this code than trying to fix it to work with this ancient browser. So here is [my pull request to do so][2].
As there seem to be no objection to doing this, I've merged the pull request. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (4)
-
Isaac Bennetch -
Madhura Jayaratne -
Marc Delisle -
Michal Čihař