[Phpmyadmin-devel] font-size and theme-right

Hi, in revision 11014, why was the html font-size moved from phpmyadmin.css.php to each theme's theme-right.css.php? See also bug #1959855. Marc

Marc Delisle wrote:
Hi, in revision 11014, why was the html font-size moved from phpmyadmin.css.php to each theme's theme-right.css.php?
See also bug #1959855.
Marc
btw., all the old "...->checkVersion('2.x ..." css chunks should be removed from the 3.0 trunk version of phpmyadmin.css.php YMMV -- View this message in context: http://www.nabble.com/font-size-and-theme-right-tp18172975p18173811.html Sent from the phpmyadmin-devel mailing list archive at Nabble.com.

Jürgen Wind a écrit :
Marc Delisle wrote:
Hi, in revision 11014, why was the html font-size moved from phpmyadmin.css.php to each theme's theme-right.css.php?
See also bug #1959855.
Marc
btw., all the old "...->checkVersion('2.x ..." css chunks should be removed from the 3.0 trunk version of phpmyadmin.css.php
YMMV
Hmmm, I see nothing like that in phpmyadmin.css.php from trunk.

Marc Delisle wrote:
Jürgen Wind a écrit :
Marc Delisle wrote:
Hi, in revision 11014, why was the html font-size moved from phpmyadmin.css.php to each theme's theme-right.css.php?
See also bug #1959855.
Marc
btw., all the old "...->checkVersion('2.x ..." css chunks should be removed from the 3.0 trunk version of phpmyadmin.css.php
YMMV
Hmmm, I see nothing like that in phpmyadmin.css.php from trunk.
oh, sorry, must have looked into the wrong file :( but any how : html{font-size ...} is common to all themes and should be moved back. just my 2cent -- View this message in context: http://www.nabble.com/font-size-and-theme-right-tp18172975p18180717.html Sent from the phpmyadmin-devel mailing list archive at Nabble.com.

Marc Delisle schrieb:
Hi, in revision 11014, why was the html font-size moved from phpmyadmin.css.php to each theme's theme-right.css.php?
See also bug #1959855.
it was gone the same way like any other styling information, i was not sure what is the right place to add this ... and i am still not sure, i feel like it is better in theme files ... but i have no odds with any other decision -- Sebastian Mendel

Sebastian Mendel a écrit :
Marc Delisle schrieb:
Hi, in revision 11014, why was the html font-size moved from phpmyadmin.css.php to each theme's theme-right.css.php?
See also bug #1959855.
it was gone the same way like any other styling information,
i was not sure what is the right place to add this ... and i am still not sure, i feel like it is better in theme files ... but i have no odds with any other decision
Ok, let's maintain it like you said (all CSS under /themes) I find it cleaner too. This means more work for custom themes to adapt them for 3.0.
participants (3)
-
Jürgen Wind
-
Marc Delisle
-
Sebastian Mendel