Hi, I feel we are near 4.0.0-beta1 (and the QA_4_0 branch?).
Let's have a look at the bug tracker; we should try to identify showstoppers for a beta1 (and raise their priority to 9 ?)
Comments?
Hi
Dne Wed, 06 Feb 2013 08:10:25 -0500 Marc Delisle marc@infomarc.info napsal(a):
Hi, I feel we are near 4.0.0-beta1 (and the QA_4_0 branch?).
Let's have a look at the bug tracker; we should try to identify showstoppers for a beta1 (and raise their priority to 9 ?)
I don't see any showstoppers in the bug tracker. Not sure about need for branch right now, do we plan any new development? Maybe starting at rc might be more reasonable in this case.
Michal Čihař a écrit :
Hi
Dne Wed, 06 Feb 2013 08:10:25 -0500 Marc Delisle marc@infomarc.info napsal(a):
Hi, I feel we are near 4.0.0-beta1 (and the QA_4_0 branch?).
Let's have a look at the bug tracker; we should try to identify showstoppers for a beta1 (and raise their priority to 9 ?)
I don't see any showstoppers in the bug tracker. Not sure about need for branch right now, do we plan any new development? Maybe starting at rc might be more reasonable in this case.
Agreed for the branch, but everyone should refrain from adding features or do cleanup (which can have an impact, as we have seen lately).
2013/2/7 Marc Delisle marc@infomarc.info:
Michal Čihař a écrit :
Hi
Dne Wed, 06 Feb 2013 08:10:25 -0500 Marc Delisle marc@infomarc.info napsal(a):
Hi, I feel we are near 4.0.0-beta1 (and the QA_4_0 branch?).
Let's have a look at the bug tracker; we should try to identify showstoppers for a beta1 (and raise their priority to 9 ?)
I don't see any showstoppers in the bug tracker. Not sure about need for branch right now, do we plan any new development? Maybe starting at rc might be more reasonable in this case.
Agreed for the branch, but everyone should refrain from adding features or do cleanup (which can have an impact, as we have seen lately).
Agreed! I'll refrain from cleanup at least until QA_4_0 is created.
Marc Delisle a écrit :
Hi, I feel we are near 4.0.0-beta1 (and the QA_4_0 branch?).
Let's have a look at the bug tracker; we should try to identify showstoppers for a beta1 (and raise their priority to 9 ?)
Comments?
Maybe this is a showstopper: https://sourceforge.net/p/phpmyadmin/bugs/3804/
Marc Delisle a écrit :
Marc Delisle a écrit :
Hi, I feel we are near 4.0.0-beta1 (and the QA_4_0 branch?).
Let's have a look at the bug tracker; we should try to identify showstoppers for a beta1 (and raise their priority to 9 ?)
Comments?
Maybe this is a showstopper: https://sourceforge.net/p/phpmyadmin/bugs/3804/
I would tend to close (wont-fix) #3804, especially after reading the comment [1]. Enabling Edit and Delete when we don't have a unique key on the row has caused the wrong row to be updated or deleted.
[1] https://github.com/phpmyadmin/phpmyadmin/commit/996232b21aa785a7d4a5123fa4f3...
Hi
Dne Thu, 07 Feb 2013 16:46:58 -0500 Marc Delisle marc@infomarc.info napsal(a):
I would tend to close (wont-fix) #3804, especially after reading the comment [1]. Enabling Edit and Delete when we don't have a unique key on the row has caused the wrong row to be updated or deleted.
Maybe just show error message, that tables without unique column are not supported for editing? (Something in sense of strAlertNonUnique).
2013/2/8 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 07 Feb 2013 16:46:58 -0500 Marc Delisle marc@infomarc.info napsal(a):
I would tend to close (wont-fix) #3804, especially after reading the comment [1]. Enabling Edit and Delete when we don't have a unique key on the row has caused the wrong row to be updated or deleted.
Maybe just show error message, that tables without unique column are not supported for editing? (Something in sense of strAlertNonUnique).
Sounds good.
Dieter Adriaenssens a écrit :
2013/2/8 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 07 Feb 2013 16:46:58 -0500 Marc Delisle marc@infomarc.info napsal(a):
I would tend to close (wont-fix) #3804, especially after reading the comment [1]. Enabling Edit and Delete when we don't have a unique key on the row has caused the wrong row to be updated or deleted.
Maybe just show error message, that tables without unique column are not supported for editing? (Something in sense of strAlertNonUnique).
Sounds good.
See [0]. I felt that the content of strAlertNonUnique was not exactly what we need in this case.
P.S. if someone agrees and merges, I'll update the po files.
[0] https://github.com/phpmyadmin/phpmyadmin/pull/154
Hi
Dne Fri, 08 Feb 2013 07:54:02 -0500 Marc Delisle marc@infomarc.info napsal(a):
See [0]. I felt that the content of strAlertNonUnique was not exactly what we need in this case.
P.S. if someone agrees and merges, I'll update the po files.
I've done both.
Michal Čihař a écrit :
Hi
Dne Fri, 08 Feb 2013 07:54:02 -0500 Marc Delisle marc@infomarc.info napsal(a):
See [0]. I felt that the content of strAlertNonUnique was not exactly what we need in this case.
P.S. if someone agrees and merges, I'll update the po files.
I've done both.
Any objection to -beta1 this weekend?
Hi
Dne Fri, 08 Feb 2013 08:37:25 -0500 Marc Delisle marc@infomarc.info napsal(a):
Any objection to -beta1 this weekend?
Fine for me.
2013/2/8 Marc Delisle marc@infomarc.info:
Michal Čihař a écrit :
Hi
Dne Fri, 08 Feb 2013 07:54:02 -0500 Marc Delisle marc@infomarc.info napsal(a):
See [0]. I felt that the content of strAlertNonUnique was not exactly what we need in this case.
P.S. if someone agrees and merges, I'll update the po files.
I've done both.
Any objection to -beta1 this weekend?
No objection.
On Feb 8, 2013 7:23 PM, "Dieter Adriaenssens" dieter.adriaenssens@gmail.com wrote:
2013/2/8 Marc Delisle marc@infomarc.info:
Michal Čihař a écrit :
Hi
Dne Fri, 08 Feb 2013 07:54:02 -0500 Marc Delisle marc@infomarc.info napsal(a):
See [0]. I felt that the content of strAlertNonUnique was not exactly what we need in this case.
P.S. if someone agrees and merges, I'll update the po files.
I've done both.
Any objection to -beta1 this weekend?
No objection.
-- Kind regards,
Dieter Adriaenssens
Fine by me too.
-- Madhura
-
Dieter Adriaenssens -
Madhura Jayaratne -
Marc Delisle -
Michal Čihař