[Phpmyadmin-devel] config settings for sysadmins
Hi, I am creating a configuration file to allow sysadmins to enable/disable permanently stored settings, or simply the entire permanent storage feature itself. Would it be a good idea to include these options in an already existing file? If so, which file? Or, I should create a new file (which is according to plan)? The file is currently in the root dir, and will be included in * libraries/header.inc.php. *Thanks! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info
Zeeshan Mughal a écrit :
Hi,
I am creating a configuration file to allow sysadmins to enable/disable permanently stored settings, or simply the entire permanent storage feature itself. Would it be a good idea to include these options in an already existing file? If so, which file?
Or, I should create a new file (which is according to plan)? The file is currently in the root dir, and will be included in /libraries/header.inc.php.
Please use the libraries/config.default.php + config.inc.php standard mechanism. -- Marc Delisle http://infomarc.info
Hi, I added configuration vars for all the settings currently under consideration. Please let me know if I am following the convention correctly, and/or if there is anything else. I decided to get this done first as I would need to access these vars for user interfaces. Thanks -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Thu, Jul 16, 2009 at 4:42 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan Mughal a écrit :
Hi,
I am creating a configuration file to allow sysadmins to enable/disable permanently stored settings, or simply the entire permanent storage feature itself. Would it be a good idea to include these options in an already existing file? If so, which file?
Or, I should create a new file (which is according to plan)? The file is currently in the root dir, and will be included in /libraries/header.inc.php.
Please use the libraries/config.default.php + config.inc.php standard mechanism.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Can anyone provide their feedback on this, please? -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Fri, Jul 17, 2009 at 1:27 AM, Zeeshan M. <zeeshan.jp@gmail.com> wrote:
Hi,
I added configuration vars for all the settings currently under consideration. Please let me know if I am following the convention correctly, and/or if there is anything else.
I decided to get this done first as I would need to access these vars for user interfaces.
Thanks
-------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info
On Thu, Jul 16, 2009 at 4:42 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan Mughal a écrit :
Hi,
I am creating a configuration file to allow sysadmins to enable/disable permanently stored settings, or simply the entire permanent storage feature itself. Would it be a good idea to include these options in an already existing file? If so, which file?
Or, I should create a new file (which is according to plan)? The file is currently in the root dir, and will be included in /libraries/header.inc.php.
Please use the libraries/config.default.php + config.inc.php standard mechanism.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. wrote:
Can anyone provide their feedback on this, please?
I only had time for a very quick look .... The use of $cfg['perm_storage'][$i]['root'] seems confusing. How about 'enable_perm_storage'? Herman
-------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org <mailto:zeeshanmughal@ieee.org> Web: http://www.zixan.info
On Fri, Jul 17, 2009 at 1:27 AM, Zeeshan M. <zeeshan.jp <http://zeeshan.jp>@gmail.com <http://gmail.com>> wrote:
Hi,
I added configuration vars for all the settings currently under consideration. Please let me know if I am following the convention correctly, and/or if there is anything else.
I decided to get this done first as I would need to access these vars for user interfaces.
Thanks
-------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org <mailto:zeeshanmughal@ieee.org> Web: http://www.zixan.info
On Thu, Jul 16, 2009 at 4:42 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote:
Zeeshan Mughal a écrit : > Hi, > > I am creating a configuration file to allow sysadmins to enable/disable > permanently stored settings, or simply the entire permanent storage > feature itself. Would it be a good idea to include these options in an > already existing file? If so, which file? > > Or, I should create a new file (which is according to plan)? The file > is currently in the root dir, and will be included in > /libraries/header.inc.php.
Please use the libraries/config.default.php + config.inc.php standard mechanism.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net <mailto:Phpmyadmin-devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge ------------------------------------------------------------------------
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions
Zeeshan M. a écrit :
Hi,
I added configuration vars for all the settings currently under consideration. Please let me know if I am following the convention correctly, and/or if there is anything else.
I decided to get this done first as I would need to access these vars for user interfaces.
Zeeshan, I don't understand why you are using a syntax like $cfg['perm_storage'][$i]['font_size'] = TRUE; As you are using $i it means this is a setting per server, right? So it should be, IMO, something like $cfg['Servers'][$i]['userprefs']['font_size']; which would follow the other $cfg['Servers'][$i] settings. And perm_storage is not meaningful, again IMO. I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['userprefs']['enable'] = true|false; By the way, I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one. -- Marc Delisle http://infomarc.info
* I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one. * Allowing sysadmins to enable/disable each setting does not make code either more complex, or trivial to write. I think that it would give them more options certainly; do they really need these options or not differs from person to person. What are your thoughts? *I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['**userprefs']['enable'] = true|false;* Sounds good. May be $cfg['Servers'][$i]['enable_userprefs'] would be better since enable is the only sub-array of "userprefs"? -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Fri, Jul 17, 2009 at 12:58 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
Hi,
I added configuration vars for all the settings currently under consideration. Please let me know if I am following the convention correctly, and/or if there is anything else.
I decided to get this done first as I would need to access these vars for user interfaces.
Zeeshan, I don't understand why you are using a syntax like $cfg['perm_storage'][$i]['font_size'] = TRUE;
As you are using $i it means this is a setting per server, right? So it should be, IMO, something like
$cfg['Servers'][$i]['userprefs']['font_size'];
which would follow the other $cfg['Servers'][$i] settings. And perm_storage is not meaningful, again IMO.
I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['userprefs']['enable'] = true|false;
By the way, I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
/ I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one. / Allowing sysadmins to enable/disable each setting does not make code either more complex, or trivial to write. I think that it would give them more options certainly; do they really need these options or not differs from person to person. What are your thoughts?
I favor the KISS principle, and I don't see who would need to fine-tune which parameter can be saved by user, or not. Keeping things more simple means less documentation to write, less parameters to worry about for sysadmins, etc. Not to mention less code bloat which leads to slower performance.
/I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['//userprefs']['enable'] = true|false;/
Sounds good. May be $cfg['Servers'][$i]['enable_userprefs'] would be better since enable is the only sub-array of "userprefs"?
Ok, especially if there are no other fine-tuning user prefs parameters ;)
-------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org <mailto:zeeshanmughal@ieee.org> Web: http://www.zixan.info
On Fri, Jul 17, 2009 at 12:58 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote:
Zeeshan M. a écrit : > Hi, > > I added configuration vars for all the settings currently under > consideration. Please let me know if I am following the convention > correctly, and/or if there is anything else. > > I decided to get this done first as I would need to access these vars > for user interfaces.
Zeeshan, I don't understand why you are using a syntax like $cfg['perm_storage'][$i]['font_size'] = TRUE;
As you are using $i it means this is a setting per server, right? So it should be, IMO, something like
$cfg['Servers'][$i]['userprefs']['font_size'];
which would follow the other $cfg['Servers'][$i] settings. And perm_storage is not meaningful, again IMO.
I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['userprefs']['enable'] = true|false;
By the way, I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one.
-- Marc Delisle http://infomarc.info
-- Marc Delisle http://infomarc.info
*I favor the KISS principle, and I don't see who would need to fine-tune which parameter can be saved by user, or not. Keeping things more simple means less documentation to write, less parameters to worry about for sysadmins, etc. Not to mention less code bloat which leads to slower performance.* Sure, sounds like a good idea. Let's keep it super simple. :) -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Fri, Jul 17, 2009 at 4:02 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
/ I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one. / Allowing sysadmins to enable/disable each setting does not make code either more complex, or trivial to write. I think that it would give them more options certainly; do they really need these options or not differs from person to person. What are your thoughts?
I favor the KISS principle, and I don't see who would need to fine-tune which parameter can be saved by user, or not.
Keeping things more simple means less documentation to write, less parameters to worry about for sysadmins, etc. Not to mention less code bloat which leads to slower performance.
/I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['//userprefs']['enable'] = true|false;/
Sounds good. May be $cfg['Servers'][$i]['enable_userprefs'] would be better since enable is the only sub-array of "userprefs"?
Ok, especially if there are no other fine-tuning user prefs parameters ;)
-------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org <mailto:zeeshanmughal@ieee.org> Web: http://www.zixan.info
On Fri, Jul 17, 2009 at 12:58 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote:
Zeeshan M. a écrit : > Hi, > > I added configuration vars for all the settings currently under > consideration. Please let me know if I am following the convention > correctly, and/or if there is anything else. > > I decided to get this done first as I would need to access these vars > for user interfaces.
Zeeshan, I don't understand why you are using a syntax like $cfg['perm_storage'][$i]['font_size'] = TRUE;
As you are using $i it means this is a setting per server, right? So it should be, IMO, something like
$cfg['Servers'][$i]['userprefs']['font_size'];
which would follow the other $cfg['Servers'][$i] settings. And perm_storage is not meaningful, again IMO.
I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['userprefs']['enable'] = true|false;
By the way, I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one.
-- Marc Delisle http://infomarc.info
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
participants (4)
-
Herman van Rink -
Marc Delisle -
Zeeshan M. -
Zeeshan Mughal