[Phpmyadmin-devel] Concatenating js files
Hi all, I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340. The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more... The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in. So the question is: are we willing to pay the price for this performance boost? Bye, Rouslan [0]: https://github.com/roccivic/phpmyadmin/tree/js-file-loader [1]: http://sourceforge.net/tracker/?func=detail&aid=3583340&group_id=23067&atid=... [2]: http://www.placella.com/temp/js-file-loader.png
Hi Dne Tue, 18 Dec 2012 14:34:00 +0000 Rouslan Placella <rouslan@placella.com> napsal(a):
I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340.
The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more...
The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in.
So the question is: are we willing to pay the price for this performance boost?
I think it would be good improvement. Have you checked if it works correctly with minified versions we ship? -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On 12/18/2012 03:07 PM, Michal Čihař wrote:
Hi
Dne Tue, 18 Dec 2012 14:34:00 +0000 Rouslan Placella <rouslan@placella.com> napsal(a):
I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340.
The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more...
The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in.
So the question is: are we willing to pay the price for this performance boost?
I think it would be good improvement. Have you checked if it works correctly with minified versions we ship?
Nope, not yet.
On 12/18/2012 03:14 PM, Rouslan Placella wrote:
On 12/18/2012 03:07 PM, Michal Čihař wrote:
Hi
Dne Tue, 18 Dec 2012 14:34:00 +0000 Rouslan Placella <rouslan@placella.com> napsal(a):
I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340.
The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more...
The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in.
So the question is: are we willing to pay the price for this performance boost?
I think it would be good improvement. Have you checked if it works correctly with minified versions we ship?
Nope, not yet.
Tested the release version on windows, no problems that I can see. Bye, Rouslan
2012/12/18 Rouslan Placella <rouslan@placella.com>
Hi all,
I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340.
The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more...
The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in.
So the question is: are we willing to pay the price for this performance boost?
Bye, Rouslan
[0]: https://github.com/roccivic/phpmyadmin/tree/js-file-loader [1]:
http://sourceforge.net/tracker/?func=detail&aid=3583340&group_id=23067&atid=... [2]: http://www.placella.com/temp/js-file-loader.png
How about making a switch for developers, which would allow for easier debugging in development environment? Could it work like that, or is it too complex to maintain two code paths? -- Regards, Piotr Przybylski
On 12/18/2012 03:57 PM, Piotr Przybylski wrote:
2012/12/18 Rouslan Placella <rouslan@placella.com <mailto:rouslan@placella.com>>
Hi all,
I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340.
The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more...
The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in.
So the question is: are we willing to pay the price for this performance boost?
Bye, Rouslan
[0]: https://github.com/roccivic/phpmyadmin/tree/js-file-loader [1]: http://sourceforge.net/tracker/?func=detail&aid=3583340&group_id=23067&atid=... [2]: http://www.placella.com/temp/js-file-loader.png
How about making a switch for developers, which would allow for easier debugging in development environment? Could it work like that, or is it too complex to maintain two code paths?
I certainly thought about it. Not sure how feasible it would be though... Bye, Rouslan
Rouslan Placella a écrit :
Hi all,
I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340.
The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more...
The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in.
If it's just a matter of grepping to find in which file some code is, I'm willing to pay this price. I assume that this big file would still be usable in Firebug's script debugger?
So the question is: are we willing to pay the price for this performance boost?
Bye, Rouslan
[0]: https://github.com/roccivic/phpmyadmin/tree/js-file-loader [1]: http://sourceforge.net/tracker/?func=detail&aid=3583340&group_id=23067&atid=... [2]: http://www.placella.com/temp/js-file-loader.png
------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
On 12/18/2012 05:16 PM, Marc Delisle wrote:
Rouslan Placella a écrit :
Hi all,
I've written a patch[0] that will concatenate js files on the server side before sending them to the client. This will reduce the number of http requests for js files to one per page. So, effectively, there will be one request for js files when a user first loads a pma page and subsequently there will 0 or 1 request (depending if we already have the needed js file already loaded client side) for any additional page the user navigates to. The patch would also close feature request[1] #3583340.
The performance benefits should be pretty obvious. You can see a screenshot[2] of the firebug network panel that I took before and after the patch. In the screenshot, I started on the main page and went to 4 different server status pages afterwards. This was on a local installation, remote installations should benefit even more...
The reason that I'm bringing this issue up on the mailing list is that there is also a drawback. Debugging js files will become somewhat more complex, since we would have to figure out which file a problem might be in.
If it's just a matter of grepping to find in which file some code is, I'm willing to pay this price.
I assume that this big file would still be usable in Firebug's script debugger?
Yes. There might be several "big files" loaded though after a long browsing session. Refreshing the page, will bring the number back down to 1.
So the question is: are we willing to pay the price for this performance boost?
Bye, Rouslan
[0]: https://github.com/roccivic/phpmyadmin/tree/js-file-loader [1]: http://sourceforge.net/tracker/?func=detail&aid=3583340&group_id=23067&atid=... [2]: http://www.placella.com/temp/js-file-loader.png
participants (4)
-
Marc Delisle -
Michal Čihař -
Piotr Przybylski -
Rouslan Placella