I have my own idea for increase the features of the PHPMyadmin. How can i tell them?
On Wed, Jan 16, 2013 at 7:31 PM, < phpmyadmin-devel-request@lists.sourceforge.net> wrote:
Send Phpmyadmin-devel mailing list submissions to phpmyadmin-devel@lists.sourceforge.net
To subscribe or unsubscribe via the World Wide Web, visit https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel or, via email, send a message with subject or body 'help' to phpmyadmin-devel-request@lists.sourceforge.net
You can reach the person managing the list at phpmyadmin-devel-owner@lists.sourceforge.net
When replying, please edit your Subject line so it is more specific than "Re: Contents of Phpmyadmin-devel digest..."
Today's Topics:
- Re: PHPUnit and our error handler (Marc Delisle)
- 4.0.0-alpha1, Alex M and Madhura (Marc Delisle)
- Re: 4.0.0-alpha1, Alex M and Madhura (Madhura Jayaratne)
- Re: 4.0.0-alpha1, Alex M and Madhura (Alex M)
- Re: 4.0.0-alpha1, Alex M and Madhura (Marc Delisle)
- Upgrade to the new SF.net interface (Marc Delisle)
- Re: 4.0.0-alpha1, Alex M and Madhura (Rouslan Placella)
Message: 1 Date: Tue, 15 Jan 2013 08:37:48 -0500 From: Marc Delisle marc@infomarc.info Subject: Re: [Phpmyadmin-devel] PHPUnit and our error handler To: phpmyadmin-devel@lists.sourceforge.net Message-ID: 50F55BAC.1010100@infomarc.info Content-Type: text/plain; charset=UTF-8; format=flowed
Michal ?iha? a ?crit :
Hi
Dne Mon, 14 Jan 2013 13:34:24 -0500 Marc Delisle marc@infomarc.info napsal(a):
Rouslan Placella a ?crit : Failed asserting that exception of type "PHPUnit_Framework_Error" is thrown. See attached patch.
[..]
diff --git a/libraries/core.lib.php b/libraries/core.lib.php index 93be5fe..eb698ff 100644 --- a/libraries/core.lib.php +++ b/libraries/core.lib.php @@ -277,7 +277,12 @@ function PMA_warnMissingExtension($extension,
$fatal = false, $extra = '')
if ($fatal) { PMA_fatalError($message); } else {
trigger_error($message, E_USER_WARNING);
$GLOBALS['error_handler']->addError(
$message,
E_USER_WARNING,
'',
'',
$escape=false);
You no longer trigger PHP error here.
}
}
diff --git a/test/libraries/core/PMA_warnMissingExtension_test.php
b/test/libraries/core/PMA_warnMissingExtension_test.php
index 1e11c73..661e6c7 100644 --- a/test/libraries/core/PMA_warnMissingExtension_test.php +++ b/test/libraries/core/PMA_warnMissingExtension_test.php @@ -15,6 +15,11 @@ require_once 'libraries/core.lib.php'; class PMA_warnMissingExtension_test extends PHPUnit_Framework_TestCase {
- protected function setUp() {
require_once './libraries/Error_Handler.class.php';
$GLOBALS['error_handler'] = new PMA_Error_Handler();
- }
- function testMissingExtention(){ $ext = 'php_ext'; $this->setExpectedException('PHPUnit_Framework_Error',
So it can not pop up as en error here. The addError method just adds it to list of errors in error handle for future display, but that does not trigger PHP error.
I think I understand now, working on it...
-- Marc Delisle http://infomarc.info
Message: 2 Date: Tue, 15 Jan 2013 16:02:18 -0500 From: Marc Delisle marc@infomarc.info Subject: [Phpmyadmin-devel] 4.0.0-alpha1, Alex M and Madhura To: phpmyadmin-devel@lists.sf.net Message-ID: 50F5C3DA.7050808@infomarc.info Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Hi, just to summarize, I would like to know from you guys:
- Do you have problems when pointing your browser to
http://demo.phpmyadmin.net/master/ or just when visiting your own server?
- Did you try disabling all browser extensions?
I'm puzzled by the fact that I cannot reproduce the problems, under Ubuntu or Windows 7, as I reported in the other thread.
By the way, one of the Chrome warnings should be solved when this pull request [0] is accepted for QA_3_5 then merged to master.
-- Marc Delisle http://infomarc.info
Message: 3 Date: Wed, 16 Jan 2013 06:29:11 +0530 From: Madhura Jayaratne madhura.cj@gmail.com Subject: Re: [Phpmyadmin-devel] 4.0.0-alpha1, Alex M and Madhura To: phpmyadmin-devel@lists.sourceforge.net Message-ID: <CAC5h4aPA3dJDaT5GRdMGTAmh5v= irpHmdKaOc9O6DUfueXjtZw@mail.gmail.com> Content-Type: text/plain; charset="iso-8859-1"
On Wed, Jan 16, 2013 at 2:32 AM, Marc Delisle marc@infomarc.info wrote:
Hi, just to summarize, I would like to know from you guys:
- Do you have problems when pointing your browser to
http://demo.phpmyadmin.net/master/ or just when visiting your own
server?
- Did you try disabling all browser extensions?
I'm puzzled by the fact that I cannot reproduce the problems, under Ubuntu or Windows 7, as I reported in the other thread.
By the way, one of the Chrome warnings should be solved when this pull request [0] is accepted for QA_3_5 then merged to master.
-- Marc Delisle http://infomarc.info
Hi,
- I have no problem when when pointing to the demo. Only the local server
gives trouble. 2. Yes, I tried disabling all browser extension, but it didn't help
-- Thanks and Regards,
Madhura Jayaratne
On 01/16/2013 04:10 PM, madura pradeep wrote:
I have my own idea for increase the features of the PHPMyadmin. How can i tell them?
Hi Madura,
thank you for your interest in contributing phpMyAdmin. The easiest way to contribute a new feature is to submit a pull request on github[0].
Also, please have a look out "contribute"[1] and "develop"[2] pages, they are quite comprehensive.
Bye, Rouslan
[0]: https://github.com/phpmyadmin/phpmyadmin [1]: http://www.phpmyadmin.net/home_page/improve.php [2]: http://www.phpmyadmin.net/home_page/devel.php
madura pradeep a écrit :
I have my own idea for increase the features of the PHPMyadmin. How can i tell them?
Hi, do you mean you have feature requests, or code to contribute?