Hi All!
I just had a go at the non-light left frame and grouped/nested tables. Formerly if you clicked on any of the groups you where taken to the full table properties overview. It would be nice to only see the tables in the group.
When I evaluated the functions which iterate through the available tables I found out that if the ToolTip-Function is enabled the SHOW TABLE STATUS is done twice, unneccesarily IMHO. I reduced that into one step and don't think that could break anything. But I would ask you to carefully revise if you see any issues with this.
At least on my setup with 300 tables this definitely speeds up my whole display.
I escaped the submitted $tbl_group variable to SHOW TABLE STATUS FROM ... LIKE '...' with no special escaping. Do you think this is needed? I only tested with common table names, to weird special characters used.
There is one thing, though: Previously the tooltips where evaluated from Tables in use. Now the tables in use are not getting a SHOW TABLE STATUS, but I think the new behaviour is more what is wanted.
If you feel somewhat unsafe with the patch please let me know. I definitely like the benefit. :-)
Regards, Garvin.
Garvin Hicking a écrit:
Hi All!
I just had a go at the non-light left frame and grouped/nested tables. Formerly if you clicked on any of the groups you where taken to the full table properties overview. It would be nice to only see the tables in the group.
Indeed this is a good improvement.
When I evaluated the functions which iterate through the available tables I found out that if the ToolTip-Function is enabled the SHOW TABLE STATUS is done twice, unneccesarily IMHO. I reduced that into one step and don't think that could break anything. But I would ask you to carefully revise if you see any issues with this.
Looks ok to me.
At least on my setup with 300 tables this definitely speeds up my whole display.
I escaped the submitted $tbl_group variable to SHOW TABLE STATUS FROM ... LIKE '...' with no special escaping. Do you think this is needed? I only tested with common table names, to weird special characters used.
Oops, I have a problem with this. Here is my test case: a db called b1, with some tables not part of a nested group and tables n1__a and n1__b.
When I rename n1_a to né1_a:
In Netscape 7.2, group né1 is ok including its table. But I lose n1__b.
In IE 6, the name né1 is broken.
Marc
There is one thing, though: Previously the tooltips where evaluated from Tables in use. Now the tables in use are not getting a SHOW TABLE STATUS, but I think the new behaviour is more what is wanted.
If you feel somewhat unsafe with the patch please let me know. I definitely like the benefit. :-)
Regards, Garvin.
Hi Marc!
Oops, I have a problem with this. Here is my test case: a db called b1, with some tables not part of a nested group and tables n1__a and n1__b.
When I rename n1_a to né1_a:
In Netscape 7.2, group né1 is ok including its table. But I lose n1__b.
In IE 6, the name né1 is broken.
I cannot reproduce this with PHP 4.3.5, MySQL 4.0.13 and the usual mysql extension, neither with $cfg['ShowTooltipAliasTB'] set to TRUE or FALSE. By renaiming n1_b to né1_b I get two groups called n1 and né1 where the two tables are contained. Both correct in IE6 and Mozilla.
Basically IE6 and Mozilla should not show different groupings because the groups are created server-side...?!
Regards, Garvin.
Garvin Hicking a écrit :
Hi Marc!
Oops, I have a problem with this. Here is my test case: a db called b1, with some tables not part of a nested group and tables n1__a and n1__b.
When I rename n1_a to né1_a:
In Netscape 7.2, group né1 is ok including its table. But I lose n1__b.
In IE 6, the name né1 is broken.
I cannot reproduce this with PHP 4.3.5, MySQL 4.0.13 and the usual mysql extension, neither with $cfg['ShowTooltipAliasTB'] set to TRUE or FALSE. By renaiming n1_b to né1_b I get two groups called n1 and né1 where the two tables are contained. Both correct in IE6 and Mozilla.
Basically IE6 and Mozilla should not show different groupings because the groups are created server-side...?!
Regards, Garvin.
Hi Garvin, tested again in Mozilla 1.6 under Linux. When I click on the + before n1, the other group (né1) opens.
When I click directly on the n1 label, the n1 group shows in the right panel.
$cfg['ShowTooltip'] = TRUE; $cfg['ShowTooltipAliasDB'] = FALSE; $cfg['ShowTooltipAliasTB'] = FALSE;
PHP 4.3.6, MySQL 4.0.16.
Marc
Hi Marc!
tested again in Mozilla 1.6 under Linux. When I click on the + before n1, the other group (né1) opens.
When I click directly on the n1 label, the n1 group shows in the right panel.
Ah, okay. You are right, I can confirm this; however this issue has been in PMA a bit longer than my patches...
Could you please try if this patch corrects the issue:
diff -r2.23 left.php 80c80 < $id = preg_replace('@[^a-z0-9]*@i', '', $baseid . $keyhistory . $key) . $indent; ---
$id = base64_encode($baseid . $keyhistory . $key) . $indent;
and if yes, please commit it, I currently have problems connecting to the SF.Net CVS.
Thanks, Garvin.
Fixed and committed, thanks.
Marc
Garvin Hicking a écrit:
Hi Marc!
tested again in Mozilla 1.6 under Linux. When I click on the + before n1, the other group (né1) opens.
When I click directly on the n1 label, the n1 group shows in the right panel.
Ah, okay. You are right, I can confirm this; however this issue has been in PMA a bit longer than my patches...
Could you please try if this patch corrects the issue:
diff -r2.23 left.php 80c80 < $id = preg_replace('@[^a-z0-9]*@i', '', $baseid . $keyhistory . $key) . $indent;
$id = base64_encode($baseid . $keyhistory . $key) . $indent;
and if yes, please commit it, I currently have problems connecting to the SF.Net CVS.
Thanks, Garvin.
-
Garvin Hicking -
Marc Delisle -
Marc Delisle