Hi all
our continuous integration server now follows 4.0 branch as well:
http://ci.phpmyadmin.net/job/phpMyAdmin%204.0/
The builds are currently run nightly, just let me know if more frequent builds would be needed.
Also translation server provides 4.0 branch for translations (though there are no differences yet):
https://l10n.cihar.com/projects/phpmyadmin/4-0/
For now I plan to keep 3.5 enabled in both as well, just in case we will need another release in 3.5 series.
2013/4/4 Michal Čihař michal@cihar.com:
Hi all
our continuous integration server now follows 4.0 branch as well:
http://ci.phpmyadmin.net/job/phpMyAdmin%204.0/
The builds are currently run nightly, just let me know if more frequent builds would be needed.
I noticed that not all classes are covered in the coverage report (fe. no plugins are listed at the moment). Only the onces that are instanciated in the tests, are listed. It is possible to change this behaviour in the config settings of clover, but enabling this, takes a lot of extra memory and CPU. Is your server powerfull enough to handle this?
Also translation server provides 4.0 branch for translations (though there are no differences yet):
https://l10n.cihar.com/projects/phpmyadmin/4-0/
For now I plan to keep 3.5 enabled in both as well, just in case we will need another release in 3.5 series.
-- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
Hi
Dne Tue, 9 Apr 2013 10:46:52 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
2013/4/4 Michal Čihař michal@cihar.com:
Hi all
our continuous integration server now follows 4.0 branch as well:
http://ci.phpmyadmin.net/job/phpMyAdmin%204.0/
The builds are currently run nightly, just let me know if more frequent builds would be needed.
I noticed that not all classes are covered in the coverage report (fe. no plugins are listed at the moment). Only the onces that are instanciated in the tests, are listed. It is possible to change this behaviour in the config settings of clover, but enabling this, takes a lot of extra memory and CPU. Is your server powerfull enough to handle this?
Well if I understand the docs [1] correctly, the only way to do that is list files we want to cover in phpunit.xml.dist (some wildcards are possible though). I'm not sure if doing this is better than current approach...
[1]:http://www.phpunit.de/manual/3.6/en/code-coverage-analysis.html#code-coverag...
2013/4/9 Michal Čihař michal@cihar.com:
Hi
Dne Tue, 9 Apr 2013 10:46:52 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
2013/4/4 Michal Čihař michal@cihar.com:
Hi all
our continuous integration server now follows 4.0 branch as well:
http://ci.phpmyadmin.net/job/phpMyAdmin%204.0/
The builds are currently run nightly, just let me know if more frequent builds would be needed.
I noticed that not all classes are covered in the coverage report (fe. no plugins are listed at the moment). Only the onces that are instanciated in the tests, are listed. It is possible to change this behaviour in the config settings of clover, but enabling this, takes a lot of extra memory and CPU. Is your server powerfull enough to handle this?
Well if I understand the docs [1] correctly, the only way to do that is list files we want to cover in phpunit.xml.dist (some wildcards are possible though). I'm not sure if doing this is better than current approach...
Well, it seems that
<whitelist addUncoveredFilesFromWhitelist="true">
is needed to include the files that are not covered by a test. But when reading the doc you mentioned [1], it seems that by adding the whitelist config option, blacklisting is ignored. I would test it, but the machines I have available at the moment don't have enough memory to easily do this, at least not for phpMyAdmin, for one of my other projects it works fine with the 'addUncoveredFilesFromWhitelist' option : all files/classes are included in the coverage report, not only the ones that are already used in a test.
I think that having this option is better, because it gives a better view of the current coverage. At this moment only some classes and files are mentioned in the coverage report, giving a false idea of how much files/classes are tested.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
Hi
Dne Wed, 10 Apr 2013 10:32:57 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
2013/4/9 Michal Čihař michal@cihar.com:
Well if I understand the docs [1] correctly, the only way to do that is list files we want to cover in phpunit.xml.dist (some wildcards are possible though). I'm not sure if doing this is better than current approach...
Well, it seems that
<whitelist addUncoveredFilesFromWhitelist="true">
is needed to include the files that are not covered by a test. But when reading the doc you mentioned [1], it seems that by adding the whitelist config option, blacklisting is ignored. I would test it, but the machines I have available at the moment don't have enough memory to easily do this, at least not for phpMyAdmin, for one of my other projects it works fine with the 'addUncoveredFilesFromWhitelist' option : all files/classes are included in the coverage report, not only the ones that are already used in a test.
I think that having this option is better, because it gives a better view of the current coverage. At this moment only some classes and files are mentioned in the coverage report, giving a false idea of how much files/classes are tested.
Indeed it gives much better overview, actually I'd expect this would be the default behavior.
Feel free to make needed changes in master.
2013/4/10 Michal Čihař michal@cihar.com:
Hi
Dne Wed, 10 Apr 2013 10:32:57 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
2013/4/9 Michal Čihař michal@cihar.com:
Well if I understand the docs [1] correctly, the only way to do that is list files we want to cover in phpunit.xml.dist (some wildcards are possible though). I'm not sure if doing this is better than current approach...
Well, it seems that
<whitelist addUncoveredFilesFromWhitelist="true">
is needed to include the files that are not covered by a test. But when reading the doc you mentioned [1], it seems that by adding the whitelist config option, blacklisting is ignored. I would test it, but the machines I have available at the moment don't have enough memory to easily do this, at least not for phpMyAdmin, for one of my other projects it works fine with the 'addUncoveredFilesFromWhitelist' option : all files/classes are included in the coverage report, not only the ones that are already used in a test.
I think that having this option is better, because it gives a better view of the current coverage. At this moment only some classes and files are mentioned in the coverage report, giving a false idea of how much files/classes are tested.
Indeed it gives much better overview, actually I'd expect this would be the default behavior.
Feel free to make needed changes in master.
Done, see commit [0] and [1]. At this moment, only php files are tested and covered.
Should we have js (unit) tests as well?
[0] https://github.com/phpmyadmin/phpmyadmin/commit/104c99a7c9c11190608a7058911a... [1] https://github.com/phpmyadmin/phpmyadmin/commit/43cce027a918a07d7201d9413272....
2013/4/12 Dieter Adriaenssens dieter.adriaenssens@gmail.com:
2013/4/10 Michal Čihař michal@cihar.com:
Hi
Dne Wed, 10 Apr 2013 10:32:57 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
2013/4/9 Michal Čihař michal@cihar.com:
Well if I understand the docs [1] correctly, the only way to do that is list files we want to cover in phpunit.xml.dist (some wildcards are possible though). I'm not sure if doing this is better than current approach...
Well, it seems that
<whitelist addUncoveredFilesFromWhitelist="true">
is needed to include the files that are not covered by a test. But when reading the doc you mentioned [1], it seems that by adding the whitelist config option, blacklisting is ignored. I would test it, but the machines I have available at the moment don't have enough memory to easily do this, at least not for phpMyAdmin, for one of my other projects it works fine with the 'addUncoveredFilesFromWhitelist' option : all files/classes are included in the coverage report, not only the ones that are already used in a test.
I think that having this option is better, because it gives a better view of the current coverage. At this moment only some classes and files are mentioned in the coverage report, giving a false idea of how much files/classes are tested.
Indeed it gives much better overview, actually I'd expect this would be the default behavior.
Feel free to make needed changes in master.
Done, see commit [0] and [1]. At this moment, only php files are tested and covered.
The fix seems to break codecoverage on our Jenkins server. I noticed it has PHPUnit 3.6.11. I have phpunit 3.7.19
Michal, could you upgrade PHPUnit on the Jenkins server?
It shouldn't make a difference, as the used directives are present in PHPUnit 3.6, but maybe there is some bug.
Kind regards,
Dieter
Should we have js (unit) tests as well?
[0] https://github.com/phpmyadmin/phpmyadmin/commit/104c99a7c9c11190608a7058911a... [1] https://github.com/phpmyadmin/phpmyadmin/commit/43cce027a918a07d7201d9413272....
-- Kind regards,
Dieter Adriaenssens
Hi
Dne Mon, 15 Apr 2013 09:50:44 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
The fix seems to break codecoverage on our Jenkins server. I noticed it has PHPUnit 3.6.11. I have phpunit 3.7.19
Michal, could you upgrade PHPUnit on the Jenkins server?
I've upgraded now, new coverage report is here:
http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp/
Dne Mon, 15 Apr 2013 09:50:44 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
The fix seems to break codecoverage on our Jenkins server. I noticed it has PHPUnit 3.6.11. I have phpunit 3.7.19
Michal, could you upgrade PHPUnit on the Jenkins server?
I've upgraded now, new coverage report is here:
Hi, From the code coveage page: http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp/
some render php pages are counted too. tbl_ .php
should I also also add UT to these files too if I try to do the Automatic testing GSOC project? In my mind, I want to add functional test case to cover these files: Benefit of Functional testing, we can guarantee phpmyadmin can work well on GradeA browsers. 1. Check the page is loaded correctly 2. Check the page is working well o GradeA browsers. 3. Check the css/js is working well
Thanks, Adam
Hi
Dne Mon, 15 Apr 2013 16:41:11 +0800 adam adamgsoc2013@gmail.com napsal(a):
Hi, From the code coveage page: http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp/
some render php pages are counted too. tbl_ .php
should I also also add UT to these files too if I try to do the Automatic testing GSOC project? In my mind, I want to add functional test case to cover these files: Benefit of Functional testing, we can guarantee phpmyadmin can work well on GradeA browsers.
- Check the page is loaded correctly
- Check the page is working well o GradeA browsers.
- Check the css/js is working well
Please note that ci server does not run Selenium tests right now, so it does not show coverage for these tests.
Anyway I think we should first focus on unit tests for the libraries, and once this is done, move on to Selenium tests, as these will be much more complex.
PS: It is enough to reply to the list, you don't have to explicitly list other recipients.
Hi,
Dne Mon, 15 Apr 2013 16:41:11 +0800 adam adamgsoc2013@gmail.com napsal(a):
Hi, From the code coveage page: http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp/
some render php pages are counted too. tbl_ .php
should I also also add UT to these files too if I try to do the Automatic testing GSOC project? In my mind, I want to add functional test case to cover these files: Benefit of Functional testing, we can guarantee phpmyadmin can work well on GradeA browsers.
- Check the page is loaded correctly
- Check the page is working well o GradeA browsers.
- Check the css/js is working well
Please note that ci server does not run Selenium tests right now, so it does not show coverage for these tests.
Anyway I think we should first focus on unit tests for the libraries, and once this is done, move on to Selenium tests, as these will be much more complex.
Thanks, I agree with you that we should first focus on unit tests for the logic codes. I post some pull requests about unit tests on Github, please help me to review, thanks
Adam
Hi all
our continuous integration server now follows 4.0 branch as well:
http://ci.phpmyadmin.net/job/phpMyAdmin%204.0/
The builds are currently run nightly, just let me know if more frequent builds would be needed.
As I remembered, Jenkin (Hudson) have an opition that can build when code check in. If our 4.0 branch is not locked, why not build when code check in.
Thanks, Adam
Also translation server provides 4.0 branch for translations (though there are no differences yet):
https://l10n.cihar.com/projects/phpmyadmin/4-0/
For now I plan to keep 3.5 enabled in both as well, just in case we will need another release in 3.5 series.
-- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Hi
Dne Tue, 9 Apr 2013 23:58:09 +0800 adam adamgsoc2013@gmail.com napsal(a):
Hi all
our continuous integration server now follows 4.0 branch as well:
http://ci.phpmyadmin.net/job/phpMyAdmin-4.0/
The builds are currently run nightly, just let me know if more frequent builds would be needed.
As I remembered, Jenkin (Hudson) have an opition that can build when code check in. If our 4.0 branch is not locked, why not build when code check in.
The problem is that full testsuite with coverage reports and CPD takes about 12-14 minutes. When this was run on code checkin for master, it quite often happened that there were several checkins to test and it anyway groupped them together, loosing ability to see regressions in individual checkins.
That's why there are two projects following master, one being run on checkin and doing only testsuite and phpcs and second one on night doing also all the lengthy stuff as coverage and cpd:
https://ci.phpmyadmin.net/job/phpMyAdmin/
https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/
Anyway I don't think there will be that much of changes in these branches, so I've enabled build on checkin for 4.0, let's see how it will behave.
Hi
Dne Tue, 9 Apr 2013 23:58:09 +0800 adam adamgsoc2013@gmail.com napsal(a):
Hi all
our continuous integration server now follows 4.0 branch as well:
http://ci.phpmyadmin.net/job/phpMyAdmin-4.0/
The builds are currently run nightly, just let me know if more frequent builds would be needed.
As I remembered, Jenkin (Hudson) have an opition that can build when code check in. If our 4.0 branch is not locked, why not build when code check in.
The problem is that full testsuite with coverage reports and CPD takes about 12-14 minutes. When this was run on code checkin for master, it quite often happened that there were several checkins to test and it anyway groupped them together, loosing ability to see regressions in individual checkins.
That's why there are two projects following master, one being run on checkin and doing only testsuite and phpcs and second one on night doing also all the lengthy stuff as coverage and cpd:
https://ci.phpmyadmin.net/job/phpMyAdmin/
https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/
Anyway I don't think there will be that much of changes in these branches, so I've enabled build on checkin for 4.0, let's see how it will behave.
OK. Thanks Michal. For trunk build, It is better to keep build when checkin, that will help our developers to avoid some build error. For release branches, if the code changes is little, I think we can keep the way you did.
but the Root guarantee is the test case coverage of Unit test and Functional test cases. that is the issues that I try to address on GSOC. [Automated testing]
Thanks Adam
-
adam -
Dieter Adriaenssens -
Michal Čihař