[Phpmyadmin-devel] FAO Chanaka: Error in master
Hi Chanaka, Just spotted the below error when clicking on "Create Version" after selecting the "Tracking" tab at table level. Fatal error: Call to undefined function PMA_getPlugin() in /home/www/pma/libraries/Tracker.class.php on line 270 I'm surprised that you didn't grep for every function that you have renamed to ensure that there are no more occurrences of the old function names before merging with upstream o_O Bye, Rouslan
-------- Original Message -------- Subject: FAO Chanaka: Error in master Date: Mon, 02 Jul 2012 18:31:32 +0100 From: Rouslan Placella <rouslan@placella.com> To: phpmyadmin-devel@lists.sourceforge.net
Hi Chanaka,
Just spotted the below error when clicking on "Create Version" after selecting the "Tracking" tab at table level.
Fatal error: Call to undefined function PMA_getPlugin() in /home/www/pma/libraries/Tracker.class.php on line 270
I'm surprised that you didn't grep for every function that you have renamed to ensure that there are no more occurrences of the old function names before merging with upstream o_O
Actually I must apologise for not grepping the code myself before sending that previous email, I thought that PMA_getPlugin() came from common.lib.php. The problem anyway seems to be a missing include in one of Alex's changesets instead. Bye, Rouslan
Le 2012-07-02 13:40, Rouslan Placella a écrit :
-------- Original Message -------- Subject: FAO Chanaka: Error in master Date: Mon, 02 Jul 2012 18:31:32 +0100 From: Rouslan Placella <rouslan@placella.com> To: phpmyadmin-devel@lists.sourceforge.net
Hi Chanaka,
Just spotted the below error when clicking on "Create Version" after selecting the "Tracking" tab at table level.
Fatal error: Call to undefined function PMA_getPlugin() in /home/www/pma/libraries/Tracker.class.php on line 270
I'm surprised that you didn't grep for every function that you have renamed to ensure that there are no more occurrences of the old function names before merging with upstream o_O
Actually I must apologise for not grepping the code myself before sending that previous email, I thought that PMA_getPlugin() came from common.lib.php. The problem anyway seems to be a missing include in one of Alex's changesets instead.
Bye, Rouslan
ff930b788ad5f066e34d1e0a214963ba143d6b3a is the first bad commit commit ff930b788ad5f066e34d1e0a214963ba143d6b3a Author: Alex Marin <alex.ukf@gmail.com> Date: Sat Jun 9 12:38:44 2012 +0300 oop: modify PMA_getTableDef and PMA_getTableDefStandIn usage -- Marc Delisle http://infomarc.info
Le 2012-07-02 13:40, Rouslan Placella a écrit :
Actually I must apologise for not grepping the code myself before sending that previous email, I thought that PMA_getPlugin() came from common.lib.php. The problem anyway seems to be a missing include in one of Alex's changesets instead.
Sorry for that, I sent a fix in the pull request. -- Alex
Hi Rouslan, Just spotted the below error when clicking on "Create Version" after
selecting the "Tracking" tab at table level.
Fatal error: Call to undefined function PMA_getPlugin() in /home/www/pma/libraries/Tracker.class.php on line 270
Yes, I'm also getting this error. But if you can see, PMA_getPlugin() function is already exist in libraries/plugin_interface.lib.php file. The error is due to not include that file before calling that function.
I'm surprised that you didn't grep for every function that you have renamed to ensure that there are no more occurrences of the old function names before merging with upstream o_O
I have renamed the functions inside common.lib.php and now that file is appeared as CommonFunctions.class.php . Seems you have misunderstood. Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________
Hi Rouslan, I got several mails. Sorry, I just see your next mail. :-| Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________
participants (4)
-
Alex Marin -
Chanaka Dharmarathna -
Marc Delisle -
Rouslan Placella