Hi all
with new GitHub feature to have templates for pull requests and issues [1], I've added ones for phpMyAdmin:
https://github.com/phpmyadmin/phpmyadmin/tree/master/.github
I've tried to document most frequent problems for the reports, but improvements are welcome :-).
[1]:https://github.com/blog/2111-issue-and-pull-request-templates
On Thu, Feb 18, 2016 at 9:32 AM, Michal Čihař michal@cihar.com wrote:
Hi all
with new GitHub feature to have templates for pull requests and issues [1], I've added ones for phpMyAdmin:
https://github.com/phpmyadmin/phpmyadmin/tree/master/.github
I've tried to document most frequent problems for the reports, but improvements are welcome :-).
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Hello,
For pull requests, would it be better if we included some link to guide lines for submitting pull requests? Something like [1], [2] or maybe give a few tips? For example, to use --signoff when committing.
[1] https://wiki.phpmyadmin.net/pma/Developer_guidelines [2] https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO
Best regards, Dan Ungureanu
Hi
Dne 18.2.2016 v 19:10 Dan Ungureanu napsal(a):
For pull requests, would it be better if we included some link to guide lines for submitting pull requests? Something like [1], [2] or maybe give a few tips? For example, to use --signoff when committing.
[1] https://wiki.phpmyadmin.net/pma/Developer_guidelines [2] https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO
Probably makes sense to add links. I just wanted to include most info directly in the text as it will be in the textarea, so the links are not clickable...
On Fri, Feb 19, 2016 at 12:51 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne 18.2.2016 v 19:10 Dan Ungureanu napsal(a):
For pull requests, would it be better if we included some link to guide lines for submitting pull requests? Something like [1], [2] or maybe give a few tips? For example, to use --signoff when committing.
[1] https://wiki.phpmyadmin.net/pma/Developer_guidelines [2] https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO
Probably makes sense to add links. I just wanted to include most info directly in the text as it will be in the textarea, so the links are not clickable...
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Hello,
I was thinking of adding these templates to other repositories (error-reporting-server and sql-parser) as well. Do you agree?
Best regards, Dan Ungureanu
Hi
Dne 21.2.2016 v 23:37 Dan Ungureanu napsal(a):
I was thinking of adding these templates to other repositories (error-reporting-server and sql-parser) as well. Do you agree?
Yes, probably makes sense, but we do not have DCO for those...
-
Dan Ungureanu -
Michal Čihař