2012/5/7 Marc Delisle <marc@infomarc.info>:

Le 2012-05-06 15:34, Rouslan Placella a écrit :

...

Hi all,

Just a quick question about the printing-related CSS files that we have in the code base. We have "print.css" which is globally included and then we also have a "theme_print.css.php" file in each theme. So couldn't we just drop the latter? Or am I missing something?

Bye, Rouslan

Hi Rouslan, The only place I could find where theme_print.css.php would be loaded, is when someone clicks on "Print view". When this happens, phpmyadmin.css.php, via a "js_frame=print" parameter, loads this file.

However, I'm not sure what effect is has, because there is no media="print" when invoking this file.

media="print" causes it to be used only for print. No media attribute means that it's used always, also on screen - which is good in this case as it gives some picture of how it will look printed. -- Regards, Piotr Przybylski

On 09/05/12 10:23, Michal Čihař wrote:

Hi

Dne Sun, 06 May 2012 20:34:05 +0100 Rouslan Placella<rouslan@placella.com> napsal(a):

...

Just a quick question about the printing-related CSS files that we have in the code base. We have "print.css" which is globally included and then we also have a "theme_print.css.php" file in each theme. So couldn't we just drop the latter? Or am I missing something?

Having only one definitely makes sense. I don't think it's needed for themes to override print CSS, so I would go for removing this file from themes.

Just filed a pull request for this [0]. Bye, Rouslan [0]: https://github.com/phpmyadmin/phpmyadmin/pull/62