[Phpmyadmin-devel] ready for QA_3_4 branch? - Developers - phpmyadmin.net

List overview All Threads
Download

[Phpmyadmin-devel] ready for QA_3_4 branch?

[Phpmyadmin-devel] Demo server for...

[Phpmyadmin-devel] Charts colors...

Marc Delisle

2 May 2011 2 May '11

3:05 p.m.

Hi, Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate. -- Marc Delisle http://infomarc.info

Reply

Show replies by date

Dieter Adriaenssens

2 May 2 May

6:26 p.m.

2011/5/2 Marc Delisle <marc(a)infomarc.info>fo>:

Hi, Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate.

Hi, Fine by me. Just to be clear, does this mean that master will become 3.5-dev? And patches scheduled for 3.5.* can be merged with master? Kind regards, Dieter

Reply

Marc Delisle

6:28 p.m.

Dieter Adriaenssens a écrit :

2011/5/2 Marc Delisle <marc(a)infomarc.info>fo>:

Hi, Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate.

Hi, Fine by me. Just to be clear, does this mean that master will become 3.5-dev? And patches scheduled for 3.5.* can be merged with master?

Yes and yes. -- Marc Delisle http://infomarc.info

Reply

Michal Čihař

3 May 3 May

12:28 p.m.

Hi Dne Mon, 02 May 2011 08:05:11 -0400 Marc Delisle <marc(a)infomarc.info> napsal(a):

Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate.

Fine for me. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

Reply

Marc Delisle

4 May 4 May

12:44 p.m.

Le 2011-05-03 05:28, Michal Čihař a écrit :

Hi Dne Mon, 02 May 2011 08:05:11 -0400 Marc Delisle <marc(a)infomarc.info> napsal(a):

Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate.

Fine for me.

Will do it on May 6. -- Marc Delisle http://infomarc.info

Reply

Piotr Przybylski

4:34 p.m.

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Le 2011-05-03 05:28, Michal Čihař a écrit :

Hi Dne Mon, 02 May 2011 08:05:11 -0400 Marc Delisle <marc(a)infomarc.info> napsal(a):

Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate.

Fine for me.

Will do it on May 6.

If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly. -- Piotr Przybylski

Reply

Marc Delisle

7:24 p.m.

Piotr Przybylski a écrit :

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Le 2011-05-03 05:28, Michal Čihař a écrit :

Hi Dne Mon, 02 May 2011 08:05:11 -0400 Marc Delisle <marc(a)infomarc.info> napsal(a):

Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate.

Fine for me.

Will do it on May 6.

If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly.

Only if you're sure that they don't disturb anything. Drizzle support is not official for 3.4. -- Marc Delisle http://infomarc.info

Reply

Dieter Adriaenssens

8:17 p.m.

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Piotr Przybylski a écrit :

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Le 2011-05-03 05:28, Michal Čihař a écrit :

Hi Dne Mon, 02 May 2011 08:05:11 -0400 Marc Delisle <marc(a)infomarc.info> napsal(a): > Some can disagree but looking at the bug tracker, I don't find bugs > major enough to block the 3.4.0 release. > > I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there > only the fixes about which we are sure, with the goal of preparing > 3.4.0-rc3 which should be the last candidate. Fine for me.

Will do it on May 6.

If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly.

Only if you're sure that they don't disturb anything. Drizzle support is not official for 3.4.

Hi, I suggest to introduce these commits in 3.5, together with the merge of the rest of the GSoC Drizzle project. It's not a good idea to apply new things so close to a new release, even if they seem harmless. As Marc says, Drizzle is not supported officially in 3.4, so I think it's best to wait, until we can fully support Drizzle in the next release cycle. Kind regards, Dieter

Reply

Piotr Przybylski

8:38 p.m.

W dniu 4 maja 2011 19:17 użytkownik Dieter Adriaenssens <dieter.adriaenssens(a)gmail.com> napisał:

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Piotr Przybylski a écrit :

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Le 2011-05-03 05:28, Michal Čihař a écrit : > Hi > > Dne Mon, 02 May 2011 08:05:11 -0400 > Marc Delisle <marc(a)infomarc.info> napsal(a): > >> Some can disagree but looking at the bug tracker, I don't find bugs >> major enough to block the 3.4.0 release. >> >> I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there >> only the fixes about which we are sure, with the goal of preparing >> 3.4.0-rc3 which should be the last candidate. > Fine for me. Will do it on May 6.

If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly.

Only if you're sure that they don't disturb anything. Drizzle support is not official for 3.4.

Hi, I suggest to introduce these commits in 3.5, together with the merge of the rest of the GSoC Drizzle project. It's not a good idea to apply new things so close to a new release, even if they seem harmless. As Marc says, Drizzle is not supported officially in 3.4, so I think it's best to wait, until we can fully support Drizzle in the next release cycle.

I was thinking about introducing something that would allow Drizzle to work at all, not official support for it. I believe these changes are harmless, especially if one or two more people look at them . -- Piotr Przybylski

Reply

Marc Delisle

8:45 p.m.

Piotr Przybylski a écrit :

W dniu 4 maja 2011 19:17 użytkownik Dieter Adriaenssens <dieter.adriaenssens(a)gmail.com> napisał:

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Piotr Przybylski a écrit :

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>: > Le 2011-05-03 05:28, Michal Čihař a écrit : >> Hi >> >> Dne Mon, 02 May 2011 08:05:11 -0400 >> Marc Delisle <marc(a)infomarc.info> napsal(a): >> >>> Some can disagree but looking at the bug tracker, I don't find bugs >>> major enough to block the 3.4.0 release. >>> >>> I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there >>> only the fixes about which we are sure, with the goal of preparing >>> 3.4.0-rc3 which should be the last candidate. >> Fine for me. > Will do it on May 6. > If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly.

Only if you're sure that they don't disturb anything. Drizzle support is not official for 3.4.

Hi, I suggest to introduce these commits in 3.5, together with the merge of the rest of the GSoC Drizzle project. It's not a good idea to apply new things so close to a new release, even if they seem harmless. As Marc says, Drizzle is not supported officially in 3.4, so I think it's best to wait, until we can fully support Drizzle in the next release cycle.

I was thinking about introducing something that would allow Drizzle to work at all, not official support for it. I believe these changes are harmless, especially if one or two more people look at them .

I am concerned about the mixed signal it would send to users. If Drizzle partly works, won't this raise expectations about version 3.4 ? -- Marc Delisle http://infomarc.info

Reply

Tyron Madlener

10:10 p.m.

2011/5/4 Dieter Adriaenssens <dieter.adriaenssens(a)gmail.com>om>:

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Piotr Przybylski a écrit :

2011/5/4 Marc Delisle <marc(a)infomarc.info>fo>:

Le 2011-05-03 05:28, Michal Čihař a écrit : > Hi > > Dne Mon, 02 May 2011 08:05:11 -0400 > Marc Delisle <marc(a)infomarc.info> napsal(a): > >> Some can disagree but looking at the bug tracker, I don't find bugs >> major enough to block the 3.4.0 release. >> >> I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there >> only the fixes about which we are sure, with the goal of preparing >> 3.4.0-rc3 which should be the last candidate. > Fine for me. Will do it on May 6.

If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly.

Only if you're sure that they don't disturb anything. Drizzle support is not official for 3.4.

Hi, I suggest to introduce these commits in 3.5, together with the merge of the rest of the GSoC Drizzle project. It's not a good idea to apply new things so close to a new release, even if they seem harmless. As Marc says, Drizzle is not supported officially in 3.4, so I think it's best to wait, until we can fully support Drizzle in the next release cycle.

I would suggest so too, rather go for stability than features.

Kind regards, Dieter ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Reply

Michal Čihař

5 May 5 May

10:11 a.m.

Hi Dne Wed, 4 May 2011 15:34:59 +0200 Piotr Przybylski <piotr.prz(a)gmail.com> napsal(a):

If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly.

Even with your patches, it throws quite lot of errors, so I think it's safer to postpone Drizzle support for later. I tried show database, table and browse it and all of them threw error: Notice in ./db_structure.php#169 Undefined index: TABLE_ROWS Notice in ./tbl_structure.php#387 Undefined index: Extra Notice in ./libraries/dbi/mysqli.dbi.lib.php#556 Undefined offset: 15 Backtrace ./sql.php#849: PMA_DBI_get_fields_meta(object) -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

Reply

Piotr Przybylski

12:09 p.m.

W dniu 5 maja 2011 09:11 użytkownik Michal Čihař <michal(a)cihar.com> napisał:

Hi Dne Wed, 4 May 2011 15:34:59 +0200 Piotr Przybylski <piotr.prz(a)gmail.com> napsal(a):

If possible, I would like to get 3 latest commits ("Set DisableIS = false for Drizzle" and two newer) from http://repo.or.cz/w/phpmyadmin/crack.git to 3.4 - they make basic work with Drizzle possible - basic browsing, queries and inserts work correctly.

Even with your patches, it throws quite lot of errors, so I think it's safer to postpone Drizzle support for later. I tried show database, table and browse it and all of them threw error: Notice in ./db_structure.php#169 Undefined index: TABLE_ROWS Notice in ./tbl_structure.php#387 Undefined index: Extra Notice in ./libraries/dbi/mysqli.dbi.lib.php#556 Undefined offset: 15 Backtrace ./sql.php#849: PMA_DBI_get_fields_meta(object)

Ok -- Piotr Przybylski

Reply

4883

days inactive

4886

days old

developers@phpmyadmin.net

Manage subscription

12 comments

5 participants

tags (0)

participants (5)

Dieter Adriaenssens
Marc Delisle
Michal Čihař
Piotr Przybylski
Tyron Madlener