Re: [Phpmyadmin-devel] [Phpmyadmin-team] ci.phpmyadmin.net and checkstyle warnings
Hi answering to -devel as it IMHO really belongs there. Dne Mon, 08 Sep 2014 08:21:21 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
something must be wrong, the number of warnings just went from about 300 to over 34000.
Looking at https://ci.phpmyadmin.net/job/phpMyAdmin/violations/ it checks also vendor directory with installed third party libraries... -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Michal Čihař a écrit :
Hi
answering to -devel as it IMHO really belongs there.
Dne Mon, 08 Sep 2014 08:21:21 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
something must be wrong, the number of warnings just went from about 300 to over 34000.
Looking at https://ci.phpmyadmin.net/job/phpMyAdmin/violations/ it checks also vendor directory with installed third party libraries...
And is this a new behavior? Was there a Jenkins upgrade on this server that could explain that? -- Marc Delisle (phpMyAdmin)
On Mon, Sep 8, 2014 at 6:08 PM, Marc Delisle <marc@infomarc.info> wrote:
Michal Čihař a écrit :
Hi
answering to -devel as it IMHO really belongs there.
Dne Mon, 08 Sep 2014 08:21:21 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
something must be wrong, the number of warnings just went from about 300 to over 34000.
Looking at https://ci.phpmyadmin.net/job/phpMyAdmin/violations/ it checks also vendor directory with installed third party libraries...
And is this a new behavior? Was there a Jenkins upgrade on this server that could explain that?
IIRC, earlier Jenkins was failing as there was no vendor directory with phpunit and other third party libraries. As now Michal have updated build configuration to install third party libraries using composer in vendor directory so that it builds successfully this is happening. I wonder if there is way if we can ignore that directory.
-- Marc Delisle (phpMyAdmin)
------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Regards, Chirayu Chiripal https://chirayuchiripal.wordpress.com/
Hi Dne Mon, 8 Sep 2014 18:35:01 +0530 Chirayu Chiripal <chirayu.chiripal@gmail.com> napsal(a):
IIRC, earlier Jenkins was failing as there was no vendor directory with phpunit and other third party libraries. As now Michal have updated build configuration to install third party libraries using composer in vendor directory so that it builds successfully this is happening. I wonder if there is way if we can ignore that directory.
Sure there is, we're ignoring many stuff already: https://github.com/phpmyadmin/phpmyadmin/commit/e7b0530fdb65e0085efa61f0df8f... -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Hi Dne Mon, 08 Sep 2014 08:38:29 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Michal Čihař a écrit :
Hi
answering to -devel as it IMHO really belongs there.
Dne Mon, 08 Sep 2014 08:21:21 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
something must be wrong, the number of warnings just went from about 300 to over 34000.
Looking at https://ci.phpmyadmin.net/job/phpMyAdmin/violations/ it checks also vendor directory with installed third party libraries...
And is this a new behavior? Was there a Jenkins upgrade on this server that could explain that?
The new behavior is that we use composer to install phpunit on Jenkins as well, see other thread on this mailing list. I've just changed the exclude list to skip those as well. -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
participants (3)
-
Chirayu Chiripal -
Marc Delisle -
Michal Čihař