While working on the Status page monitor I noticed some bugs in the current master demo:
- In table structure and table browse, the functions you can use on multiple rows ( Check All / Uncheck all With selected: [ the links here ]) are not marked as links anymore. The cursor doesn't turn into a hand either when hovering over. Also there's lots of unnecessary horizontal space between the links.
- Create following table: CREATE TABLE IF NOT EXISTS `test` ( `test` datetime NOT NULL, `idx` int(11) NOT NULL ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
then go to the SQL tab and execute the following:
INSERT INTO `test` VALUES('0000-00-00 00:00:00', 1); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 2); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 3); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 4); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 5);
This will cause the loading message to appear and disappear a second later with no feedback of whether the query was successful
- On my thinkpad with a resolution of 1024x768 its almost impossible to create a table, since both 'create table' links now open a jquery dialog. We really need to fix that create table dialog.
- On the table structure page: Maybe there should be a bit of vertical space between the table links and the "table structure html table". And the oversize "Indexes" Title seems very out of place there. "show/hide indexes" should also hide the create index box. Why does the 'create index' need that big empty box anyway? This could be replaced with a 'Create index' link altogether, that opens up a jquery dialog containing a link "add another index" that adds another row to the html table there. But yea, that's not a bug :D
By the way. I would like to improve that index part and the create table dialog but it takes away time for my original proposal.
Does this work still count as work for the gsoc project, to some degree? I would not like to fail the mid-term/end-term evaluations because of that :(
On Fri, Jul 8, 2011 at 3:49 PM, Tyron Madlener tyronx@gmail.com wrote:
While working on the Status page monitor I noticed some bugs in the current master demo:
- In table structure and table browse, the functions you can use on
multiple rows ( Check All / Uncheck all With selected: [ the links here ]) are not marked as links anymore. The cursor doesn't turn into a hand either when hovering over. Also there's lots of unnecessary horizontal space between the links.
- Create following table:
CREATE TABLE IF NOT EXISTS `test` ( `test` datetime NOT NULL, `idx` int(11) NOT NULL ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
then go to the SQL tab and execute the following:
INSERT INTO `test` VALUES('0000-00-00 00:00:00', 1); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 2); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 3); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 4); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 5);
This will cause the loading message to appear and disappear a second later with no feedback of whether the query was successful
- On my thinkpad with a resolution of 1024x768 its almost impossible
to create a table, since both 'create table' links now open a jquery dialog. We really need to fix that create table dialog.
- On the table structure page: Maybe there should be a bit of vertical
space between the table links and the "table structure html table". And the oversize "Indexes" Title seems very out of place there. "show/hide indexes" should also hide the create index box. Why does the 'create index' need that big empty box anyway? This could be replaced with a 'Create index' link altogether, that opens up a jquery dialog containing a link "add another index" that adds another row to the html table there. But yea, that's not a bug :D
2011/7/8 Tyron Madlener tyronx@gmail.com:
By the way. I would like to improve that index part and the create table dialog but it takes away time for my original proposal.
Does this work still count as work for the gsoc project, to some degree? I would not like to fail the mid-term/end-term evaluations because of that :(
If you have enough time to implement your project properly, why not - improving code quality and fixing bugs is always welcome. That way maybe we will leave the codebase with fewer bugs than it originally had, after all our projects are always introducing new ones :)
Hi
Dne Fri, 8 Jul 2011 15:52:16 +0300 Tyron Madlener tyronx@gmail.com napsal(a):
By the way. I would like to improve that index part and the create table dialog but it takes away time for my original proposal.
Does this work still count as work for the gsoc project, to some degree? I would not like to fail the mid-term/end-term evaluations because of that :(
You should primarily focus on planned project. However any extra involvement is welcome and you won't surely fail at the evaluation because of it if you meet your planned deliverables.
On Fri, Jul 8, 2011 at 3:49 PM, Tyron Madlener tyronx@gmail.com wrote:
While working on the Status page monitor I noticed some bugs in the current master demo:
- In table structure and table browse, the functions you can use on
multiple rows ( Check All / Uncheck all With selected: [ the links here ]) are not marked as links anymore. The cursor doesn't turn into a hand either when hovering over. Also there's lots of unnecessary horizontal space between the links.
- Create following table:
CREATE TABLE IF NOT EXISTS `test` ( `test` datetime NOT NULL, `idx` int(11) NOT NULL ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
then go to the SQL tab and execute the following:
INSERT INTO `test` VALUES('0000-00-00 00:00:00', 1); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 2); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 3); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 4); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 5);
This will cause the loading message to appear and disappear a second later with no feedback of whether the query was successful
Please file a bug for this :-)
- On my thinkpad with a resolution of 1024x768 its almost impossible
to create a table, since both 'create table' links now open a jquery dialog. We really need to fix that create table dialog.
Middle click (open in new tab) works, but I also hate this.
And one more suggestion:
Counting rows in big tables that use CSV as Engine (such as the general_log) seem very slow. Maybe rows should not be counted automatically for CSV Tables and only done upon user request. In my test I counted 36k rows on the demo server, that takes around 250ms, so imagine the general_log running all day. Then you will have 1mil+ rows, which then requires ~6-8 seconds to count.
On Fri, Jul 8, 2011 at 3:49 PM, Tyron Madlener tyronx@gmail.com wrote:
While working on the Status page monitor I noticed some bugs in the current master demo:
- In table structure and table browse, the functions you can use on
multiple rows ( Check All / Uncheck all With selected: [ the links here ]) are not marked as links anymore. The cursor doesn't turn into a hand either when hovering over. Also there's lots of unnecessary horizontal space between the links.
- Create following table:
CREATE TABLE IF NOT EXISTS `test` ( `test` datetime NOT NULL, `idx` int(11) NOT NULL ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
then go to the SQL tab and execute the following:
INSERT INTO `test` VALUES('0000-00-00 00:00:00', 1); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 2); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 3); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 4); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 5);
This will cause the loading message to appear and disappear a second later with no feedback of whether the query was successful
- On my thinkpad with a resolution of 1024x768 its almost impossible
to create a table, since both 'create table' links now open a jquery dialog. We really need to fix that create table dialog.
- On the table structure page: Maybe there should be a bit of vertical
space between the table links and the "table structure html table". And the oversize "Indexes" Title seems very out of place there. "show/hide indexes" should also hide the create index box. Why does the 'create index' need that big empty box anyway? This could be replaced with a 'Create index' link altogether, that opens up a jquery dialog containing a link "add another index" that adds another row to the html table there. But yea, that's not a bug :D
Hi
Dne Tue, 12 Jul 2011 13:08:37 +0300 Tyron Madlener tyronx@gmail.com napsal(a):
And one more suggestion:
Counting rows in big tables that use CSV as Engine (such as the general_log) seem very slow. Maybe rows should not be counted automatically for CSV Tables and only done upon user request. In my test I counted 36k rows on the demo server, that takes around 250ms, so imagine the general_log running all day. Then you will have 1mil+ rows, which then requires ~6-8 seconds to count.
There is already similar logic for InnoDB or views, so only another engine should be added here.
-
Michal Čihař -
Piotr Przybylski -
Tyron Madlener