[Phpmyadmin-devel] sqlparser.lib.php#392 ($c == '.') && ($c == '0') ???
Hi, just curious about $is_hex_digit = ($is_digit) && ($c == '.') && ($c == '0') && ($count2 < $len) && (PMA_substr($sql, $count2, 1) == 'x'); on line #392 how can $c be '.' AND '0' ??? -- Sebastian Mendel www.sebastianmendel.de
Sebastian Mendel schrieb:
Hi,
just curious about
$is_hex_digit = ($is_digit) && ($c == '.') && ($c == '0') && ($count2 < $len) && (PMA_substr($sql, $count2, 1) == 'x');
on line #392
how can $c be '.' AND '0' ???
Revision: 7554 Author: nijel Date: 20:50:45, Freitag, 14. Oktober 2005 Message: Handle correctly float like .01 (bug #1252713). ---- Modified : /trunk/phpMyAdmin/ChangeLog Modified : /trunk/phpMyAdmin/libraries/sqlparser.lib.php -- Sebastian Mendel www.sebastianmendel.de
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Hi,
just curious about
$is_hex_digit = ($is_digit) && ($c == '.') && ($c == '0') && ($count2 < $len) && (PMA_substr($sql, $count2, 1) == 'x');
on line #392
how can $c be '.' AND '0' ???
Revision: 7554 Author: nijel Date: 20:50:45, Freitag, 14. Oktober 2005 Message: Handle correctly float like .01 (bug #1252713). ---- Modified : /trunk/phpMyAdmin/ChangeLog Modified : /trunk/phpMyAdmin/libraries/sqlparser.lib.php
This would do a better job: $is_hex_digit = ($is_digit) && ($c == '0') && ($count2 < $len) && (PMA_substr($sql, $count2, 1) == 'x'); even if not all cases of hex are catched with this logic, see http://dev.mysql.com/doc/refman/5.0/en/hexadecimal-values.html
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Hi,
just curious about
$is_hex_digit = ($is_digit) && ($c == '.') && ($c == '0') && ($count2 < $len) && (PMA_substr($sql, $count2, 1) == 'x');
on line #392
how can $c be '.' AND '0' ??? Revision: 7554 Author: nijel Date: 20:50:45, Freitag, 14. Oktober 2005 Message: Handle correctly float like .01 (bug #1252713).
Modified : /trunk/phpMyAdmin/ChangeLog Modified : /trunk/phpMyAdmin/libraries/sqlparser.lib.php
This would do a better job:
$is_hex_digit = ($is_digit) && ($c == '0') && ($count2 < $len) && (PMA_substr($sql, $count2, 1) == 'x');
yes - this is the original code - i do not know why this was changed - possible micha could make it clear -- Sebastian Mendel www.sebastianmendel.de
Hi On Wed, 07 Feb 2007 15:19:01 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:
yes - this is the original code - i do not know why this was changed - possible micha could make it clear
Sorry I don't have that good memory. Anyway feel free to change it, my code looks really weird.. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (3)
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel