[Phpmyadmin-devel] GSOC- Refactoring
Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit :
Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know.
Thilina, in user_password.php there is a long "if" that starts with if (isset($_REQUEST['nopass'])) { can you improve some parts of it? -- Marc Delisle http://infomarc.info
On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit :
Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know.
Thilina, in user_password.php there is a long "if" that starts with
if (isset($_REQUEST['nopass'])) {
can you improve some parts of it?
Hi Marc, Ok, I'll do. -- Regards.
Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit :
Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know.
Thilina, in user_password.php there is a long "if" that starts with
if (isset($_REQUEST['nopass'])) {
can you improve some parts of it?
Hi Marc, Ok, I'll do.
Hi Marc, I have tried to do some refactoring for user_password.php script which you mentioned earlier. please review that and give me some advice to improve my refactoring skill, because I'm new to code refactpring. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
On Sun, Apr 8, 2012 at 12:20 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit :
Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know.
Thilina, in user_password.php there is a long "if" that starts with
if (isset($_REQUEST['nopass'])) {
can you improve some parts of it?
Hi Marc, Ok, I'll do.
Hi Marc, I have tried to do some refactoring for user_password.php script which you mentioned earlier. please review that and give me some advice to improve my refactoring skill [0], because I'm new to code refactoring.
[0] - https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid...
-- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
On Sun, Apr 8, 2012 at 12:40 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Sun, Apr 8, 2012 at 12:20 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit :
Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know.
Thilina, in user_password.php there is a long "if" that starts with
if (isset($_REQUEST['nopass'])) {
can you improve some parts of it?
Hi Marc, Ok, I'll do.
Hi Marc, I have tried to do some refactoring for user_password.php script which you mentioned earlier. please review that and give me some advice to improve my refactoring skill [0], because I'm new to code refactoring.
[0] - https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid...
Hi Marc, I have updated the patch [0]. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
On Tue, Apr 10, 2012 at 12:01 PM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Sun, Apr 8, 2012 at 12:40 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Sun, Apr 8, 2012 at 12:20 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna@gmail.com> wrote:
On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle <marc@infomarc.info>wrote:
Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit :
Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know.
Thilina, in user_password.php there is a long "if" that starts with
if (isset($_REQUEST['nopass'])) {
can you improve some parts of it?
Hi Marc, Ok, I'll do.
Hi Marc, I have tried to do some refactoring for user_password.php script which you mentioned earlier. please review that and give me some advice to improve my refactoring skill [0], because I'm new to code refactoring.
[0] - https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid...
Hi Marc, I have updated the patch [0].
Hi Marc, Can you review my second patch which is regarding to refactoring [1]. I have fixed previous bug. [1] - https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid... -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.
participants (2)
-
Marc Delisle -
Thilina Buddika Abeyrathna