On 2/28/14 7:52 AM, Marc Delisle wrote: ticket request Of the three choices proposed, I most prefer "New search bookmark" and "Saved search bookmarks". Using the word "query" instead of "search" also fits nicely.

A few things I noticed while testing this feature: 1) When attempting to save a bookmark without providing a name, instead of "Missing information to save the search." we should be more specific and instead say "Please provide a name for this bookmarked query."

In an ideal world, IMO, the proper field should then get focus and have a light red background until the user starts to type. I don't believe we do that anywhere, but it is a good way to draw the user's attention to the blank and required field.

2) I think we should we prompt the user before saving over an existing bookmark.

Otherwise, very nice job Hugues.

2014-03-03 18:47 GMT+01:00 Hugues Peccatte <hugues.peccatte(a)gmail.com>om>: Hi, I changed it, locally. I used "bookmarked search". Is it ok ? Done. > >> >> In an ideal world, IMO, the proper field should then get focus and have >> a light red background until the user starts to type. I don't believe we >> do that anywhere, but it is a good way to draw the user's attention to >> the blank and required field. >> I agree also. I'll try to see if I can do something about this. > I did it, but there is a "problem"... The field is focused, but behind the "PMA_ajaxShowMessage". So I click on the popin to close it... and lose the focus... The only thing that I can do is to add a red border to the field. As the content of the page is reloaded when submitting the form, the field won't stay red too long. I'm working at the same time and I did something: - when having an error, I receive the id of a field (already done to focus the element) - I remove the class "error" of all inputs in the page - I had the class "error" to the field So even if there are many errors on different fields without reload, only one field will stay with the "error" class. What do you think about this please? >> >> 2) I think we should we prompt the user before saving over an existing >> bookmark. >> Currently, you can't use a bookmark name already used by this user on > this DB. Do you mean that we should authorize to overwrite a name if the > user agree? Hugues.

Hi Hugues, very nice work on this. I have a few comments below: On 3/3/14 3:14 PM, Hugues Peccatte wrote: Yes, this seems good to me now. I think you may be using the wrong dialog here; it is saying "MySQL said" and has a link to the MySQL documentation. Otherwise I like this. It's an interesting problem and I'm not thrilled with the results (because of the limitations you mention above). Perhaps it's something we should leave alone for now and I'll open a feature request with a list of everywhere that could benefit from this.

I can only speak about how I expect it to work, and I now understand how it is meant to work, but it seems a bit confusing. You're allowing the user to rename their search by typing in a new name to "searchName", but to create a modified copy of an existing query a user would have to select "New bookmark" from the "searchId" dropdown. As a user, I expected it to create a new bookmark with the new name, leaving the old one intact. Yes, I realize the submit button says "Save bookmark" which is a clue, but I ignored the label and pressed on, convinced I knew better :-D I believe people are more likely to want to create a copy of a bookmark than rename one (renaming can essentially be done by creating a copy and removing the old one, which isn't ideal but I think is pretty well understood). I'd appreciate some other thoughts about this, especially if I'm wrong here :) > > Hugues. > > > ------------------------------------------------------------------------------ > Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. > With Perforce, you get hassle-free workflows. Merge that actually works. > Faster operations. Version large binaries. Built-in WAN optimization and the > freedom to use Git, Perforce or both. Make the move to Perforce. > http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.c… > > > > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >

Hi, 2014-03-05 16:54 GMT+01:00 Isaac Bennetch &lt;bennetch(a)gmail.com <mailto:bennetch@gmail.com>>: On 3/4/14 6:38 PM, Isaac Bennetch wrote: &lt;hugues.peccatte(a)gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com>>>: <mailto:bennetch@gmail.com> "Saved understandable of "search" Couldn't it name, more bookmarked query." this. I replaced it by the good popup (I hope…). focus behind the lose the As the Take a look at the "Create database" form by clicking the Databases tab of the main page. Attempting to create a database with no name gives a nice red highlight and "Please fill out this field" popup. Hopefully that clears up what I meant; but we can simply add this form to the list at https://sourceforge.net/p/phpmyadmin/feature-requests/1513/ if you'd like. I think this is a browser design. On Chrome, the field only has a tip. This is displayed by the attribute "required". I don't think that I can use it because there are some cases where we don't need to set a name. user a name understand how "searchName", but the old which bookmark copy and I believe that I don't understand one part… […] Oh… I read it again. Maybe I understood this time… After loading a search and setting a new name, you expect to have the first one and the new one with the new name. I think that I got it ! I wait for other feedbacks before changing the behavior, but it could be interesting too. :) Hugues.

How about adding a "Rename bookmark" button? Then, if I change the name and hit "Save bookmark", I get a copy (which is what I also expect from the UI). Won't we have too much button here ? If you think that the "Save button" shouldn't rename but save another one, I could change the behavior. But imagine that you just want to update a search without changing the name (and without implementing the "Rename" button), then you should: - load a search "MySearch" - change the filters - save the search with a new name "MyNewSearch" - delete the old one "MySearch" - load the new search "MyNewSearch" - save the search with the old name "MySearch" - delete the intermidiate search "MyNewSearch" Could I suggest to add a confirmation alert when trying to rename a search ? "Do you really want to rename the bookmarked search «MySearch» as «MyNewSearch»? To create a new one, please select «New bookmark»." (Please correct if needed.) Another minor modifications could be to add a "as" between the select input and the text input. "Saved bookmarked search: «New bookmark» as «SortByName»" "Saved bookmarked search: «SortByName» as «SortByNameDesc»"

After your decision, I'll try to implement it. The choices: - new button "Rename bookmark" - new alert to warn the user (my favorite) - add a minor text to be clearer Hugues.

2014-03-09 20:53 GMT+01:00 Marc Delisle &lt;marc(a)infomarc.info&gt;fo>: Le 2014-03-09 11:52, Hugues Peccatte a écrit : You're right... I thought to this and I didn't know how to translate it in French. Ok. So I'll add a button. So we'll have: - Create bookmark - Update bookmark (visible only when a bookmark is selected) - Delete bookmark (visible only when a bookmark is selected - currently always displayed) If we have an "inactive" display for buttons, instead of hidding them, I could just use this display. Please tell me which one you prefer. I used "Update" instead of "Rename" because the work to save both (the new name and the new filters) is already done. And when changing the selected item to "New bookmark", I'll reload the page and empty all the fields. Do you agree with all these changes? Is it closer than the behavior you expect? Hugues.

2014-03-09 20:53 GMT+01:00 Marc Delisle &lt;marc(a)infomarc.info&gt;fo>: You're right... I thought to this and I didn't know how to translate it in French. Ok. So I'll add a button. So we'll have: - Create bookmark - Update bookmark (visible only when a bookmark is selected) - Delete bookmark (visible only when a bookmark is selected - currently always displayed) If we have an "inactive" display for buttons, instead of hidding them, I could just use this display. Please tell me which one you prefer. I used "Update" instead of "Rename" because the work to save both (the new name and the new filters) is already done. And when changing the selected item to "New bookmark", I'll reload the page and empty all the fields. Do you agree with all these changes? Is it closer than the behavior you expect? Hugues.