Hi, I would like to reopen the discussion about this issue. I know you're tired of it, but there are lots of problems for users.
I noticed at least one distro that just copy our libraries/config.default.php into ../config.inc.php!
Unfortunately, many users do not read the doc about installation, and even for some who did read it, there are still problems: https://sourceforge.net/tracker/index.php?func=detail&aid=1471501&gr...
Having to close all browser windows is another thing that is not evident for many.
For some reasons, the setup script is not as popular as we hoped (probably due to the directory manipulations related to its use).
My opinion is that we have to think about was it "normal" and expected for the configuration of OSS products.
Is it too late to revert to our old way of keeping BC by compensating with code for missing options?
If it's too late, what about having a config-dist.inc.php that would contain the minimum lines (one server section connecting to localhost with root and no password). People could copy it into config.inc.php and be more happy.
Marc
Hi all
On Sun, 25 Jun 2006 08:10:51 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I would like to reopen the discussion about this issue. I know you're tired of it, but there are lots of problems for users.
I noticed at least one distro that just copy our libraries/config.default.php into ../config.inc.php!
I also got lost in Debian way of configuring phpMyAdmin, which has only some wrapper instead of config.inc.php and includes other pieces from various places.
Unfortunately, many users do not read the doc about installation, and even for some who did read it, there are still problems: https://sourceforge.net/tracker/index.php?func=detail&aid=1471501&gr...
Having to close all browser windows is another thing that is not evident for many.
This is bug and should be fixed. There is IMHO no technical reason why this should be needed it's only something broken in caching code.
For some reasons, the setup script is not as popular as we hoped (probably due to the directory manipulations related to its use).
Maybe documentation should be simplified as you can use setup script without any directory manipulation, you only can not save file then. I'm open to ideas to make it simple and at least a bit secure.
My opinion is that we have to think about was it "normal" and expected for the configuration of OSS products.
Mantis has setup script which requires write permissions for writing config, Mediawiki has installer which needs similar amount of manual work as ours (it IMHO can not be done different safely). Both don't provide default config file. I don't know others...
Is it too late to revert to our old way of keeping BC by compensating with code for missing options?
I don't see how BC code is related to first setup. The BC code is IMHO independant to config.
Michal Čihař a écrit :
Hi all
On Sun, 25 Jun 2006 08:10:51 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I would like to reopen the discussion about this issue. I know you're tired of it, but there are lots of problems for users.
I noticed at least one distro that just copy our libraries/config.default.php into ../config.inc.php!
I also got lost in Debian way of configuring phpMyAdmin, which has only some wrapper instead of config.inc.php and includes other pieces from various places.
Unfortunately, many users do not read the doc about installation, and even for some who did read it, there are still problems: https://sourceforge.net/tracker/index.php?func=detail&aid=1471501&gr...
Having to close all browser windows is another thing that is not evident for many.
This is bug and should be fixed. There is IMHO no technical reason why this should be needed it's only something broken in caching code.
OK I'll have a look at this bug.
For some reasons, the setup script is not as popular as we hoped (probably due to the directory manipulations related to its use).
Maybe documentation should be simplified as you can use setup script without any directory manipulation, you only can not save file then. I'm open to ideas to make it simple and at least a bit secure.
My opinion is that we have to think about was it "normal" and expected for the configuration of OSS products.
Mantis has setup script which requires write permissions for writing config, Mediawiki has installer which needs similar amount of manual work as ours (it IMHO can not be done different safely). Both don't provide default config file. I don't know others...
I checked some other products:
gallery 2: no default config file.
moodle: config-dist.php present but creates config.php if this file is not found; then attempts to save it, otherwise offers to download it
mambo,joomla: in manual installation, they ask to rename configuration.php-dist to configuration.php
serendipity: creates serendipity_config_local.inc.php based on web configuration form
egroupware: generates a downloadable config file
postnuke: config.php present
fudforum: install script that must be deleted after installation and that generates the config file
phpBB: an empty config.php!
phorum: config.php.sample for db preferences
The main argument in favor of having a config.inc.php is probably that there has been a config.inc.php in phpMyAdmin since 1998, so in general people expect it.
Is it too late to revert to our old way of keeping BC by compensating with code for missing options?
I don't see how BC code is related to first setup. The BC code is IMHO independant to config.
One of the reasons to stop having config.inc.php in the kit was to avoid having to keep the BC code up to date.
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&da...
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi
On Tue, 27 Jun 2006 09:02:11 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
The main argument in favor of having a config.inc.php is probably that there has been a config.inc.php in phpMyAdmin since 1998, so in general people expect it.
I would prefer to make some changes to setup script to make it easier to use. If connection with empty config fails, we point user to setup script, he configures everything and then it attempts to save config. If that fails, we can offer it for download.
One of the reasons to stop having config.inc.php in the kit was to avoid having to keep the BC code up to date.
The "BC" code is now used everytime, having full config.inc.php only does not allow us to change things that most users won't change like function defitions. Maybe it's time to move these things out of config as we do modify them anyway later according to MySQL version.
Michal Čihař a écrit :
Hi
On Tue, 27 Jun 2006 09:02:11 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
The main argument in favor of having a config.inc.php is probably that there has been a config.inc.php in phpMyAdmin since 1998, so in general people expect it.
I would prefer to make some changes to setup script to make it easier to use. If connection with empty config fails, we point user to setup script, he configures everything and then it attempts to save config. If that fails, we can offer it for download.
I'm not 100% convinced about not having a config.inc.php but I agree with your idea for the moment. Do you want to split this work with me?
We'll also have to make sure that this bug http://sourceforge.net/tracker/index.php?func=detail&aid=1471501&gro... is fixed. Maybe Sebastian has an idea about this?
One of the reasons to stop having config.inc.php in the kit was to avoid having to keep the BC code up to date.
The "BC" code is now used everytime, having full config.inc.php only does not allow us to change things that most users won't change like function defitions. Maybe it's time to move these things out of config as we do modify them anyway later according to MySQL version.
So, in libraries/config.default.php, everything starting from "MySQL settings" would be moved somewhere else, like in libraries/common.lib.php just after $_SESSION['PMA_Config'] = new PMA_Config('./config.inc.php');
?
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&da...
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Tue, 27 Jun 2006 10:34:37 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I'm not 100% convinced about not having a config.inc.php but I agree with your idea for the moment. Do you want to split this work with me?
I can do it, but not in next two weeks.
So, in libraries/config.default.php, everything starting from "MySQL settings" would be moved somewhere else, like in libraries/common.lib.php just after $_SESSION['PMA_Config'] = new PMA_Config('./config.inc.php');
Maybe it could be even moved out of cfg array...
Michal Čihař a écrit :
On Tue, 27 Jun 2006 10:34:37 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I'm not 100% convinced about not having a config.inc.php but I agree with your idea for the moment. Do you want to split this work with me?
I can do it, but not in next two weeks.
Ok, I'll concentrate on other bug fixes meanwhile. In 4 weeks we can start talking about the 2.9.0 release.
So, in libraries/config.default.php, everything starting from "MySQL settings" would be moved somewhere else, like in libraries/common.lib.php just after $_SESSION['PMA_Config'] = new PMA_Config('./config.inc.php');
Maybe it could be even moved out of cfg array...
Then we would have to change more code. Why are you suggesting this?
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&da...
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Tue, 27 Jun 2006 10:44:27 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Michal Čihař a écrit :
On Tue, 27 Jun 2006 10:34:37 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I'm not 100% convinced about not having a config.inc.php but I agree with your idea for the moment. Do you want to split this work with me?
I can do it, but not in next two weeks.
Ok, I'll concentrate on other bug fixes meanwhile. In 4 weeks we can start talking about the 2.9.0 release.
So, in libraries/config.default.php, everything starting from "MySQL settings" would be moved somewhere else, like in libraries/common.lib.php just after $_SESSION['PMA_Config'] = new PMA_Config('./config.inc.php');
Maybe it could be even moved out of cfg array...
Then we would have to change more code. Why are you suggesting this?
Because I don't see reason for storing this in session.
Marc Delisle schrieb:
Michal Čihař a écrit :
Hi
On Tue, 27 Jun 2006 09:02:11 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
The main argument in favor of having a config.inc.php is probably that there has been a config.inc.php in phpMyAdmin since 1998, so in general people expect it.
I would prefer to make some changes to setup script to make it easier to use. If connection with empty config fails, we point user to setup script, he configures everything and then it attempts to save config. If that fails, we can offer it for download.
I'm not 100% convinced about not having a config.inc.php but I agree with your idea for the moment. Do you want to split this work with me?
We'll also have to make sure that this bug http://sourceforge.net/tracker/index.php?func=detail&aid=1471501&gro... is fixed. Maybe Sebastian has an idea about this?
sounds wired, i dont know how why the config file is not being read even after browser shutdown (session cookies have always zero lifetime and will be deleted with browser shutdown), whether the browser was not shutdown completely or he has some permission errors with his config file ... possible we/i can add some code to always check if config.onc.php exists if the current file is config.default.php and also check permissions ... but i think i remember that permissions already checked?!? ... will look into this, ... have some wired problems with sf.net authorization at the moment ...
Michal Čihař schrieb:
Hi
On Tue, 27 Jun 2006 09:02:11 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
The main argument in favor of having a config.inc.php is probably that there has been a config.inc.php in phpMyAdmin since 1998, so in general people expect it.
I would prefer to make some changes to setup script to make it easier to use. If connection with empty config fails, we point user to setup script, he configures everything and then it attempts to save config. If that fails, we can offer it for download.
or offer to try again. meanwhile the user can make the config.inc.php or the folder writable ... in phpMyAdmin we can check the folder and config-file and display some warning if it is still writable
Michal Čihař a écrit :
Hi all
On Sun, 25 Jun 2006 08:10:51 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I would like to reopen the discussion about this issue. I know you're tired of it, but there are lots of problems for users.
I noticed at least one distro that just copy our libraries/config.default.php into ../config.inc.php!
I also got lost in Debian way of configuring phpMyAdmin, which has only some wrapper instead of config.inc.php and includes other pieces from various places.
Unfortunately, many users do not read the doc about installation, and even for some who did read it, there are still problems: https://sourceforge.net/tracker/index.php?func=detail&aid=1471501&gr...
Having to close all browser windows is another thing that is not evident for many.
This is bug and should be fixed. There is IMHO no technical reason why this should be needed it's only something broken in caching code.
Based on my tests, Sebastian just fixed this bug today.
Marc
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Marc Delisle schrieb:
Michal ?iha? a écrit :
Hi all
On Sun, 25 Jun 2006 08:10:51 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I would like to reopen the discussion about this issue. I know you're tired of it, but there are lots of problems for users.
I noticed at least one distro that just copy our libraries/config.default.php into ../config.inc.php!
I also got lost in Debian way of configuring phpMyAdmin, which has only some wrapper instead of config.inc.php and includes other pieces from various places.
Unfortunately, many users do not read the doc about installation, and even for some who did read it, there are still problems: https://sourceforge.net/tracker/index.php?func=detail&aid=1471501&gr...
Having to close all browser windows is another thing that is not evident for many.
This is bug and should be fixed. There is IMHO no technical reason why this should be needed it's only something broken in caching code.
Based on my tests, Sebastian just fixed this bug today.
i was not 100% sure if my change fixes this problem also, as i could never reproduce the reported problems ... the fix was mainly for recognizing a removed config.inc.php and reload default configuration
- -- Sebastian Mendel
www.sebastianmendel.de
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel