I was looking at some of the deprecation notices we're getting from jQuery after #12447 [1], and, while we can fix a lot of them ourselves, some seem to be in libraries we're using.
After a quick grep of the code, I see jqplot, several jquery files, and openlayers seem to be affected.
One of the deprecated functions is bind(). We're using jquery-migrate right now, so how much of a concern are these issues? I suppose we should fix the deprecated uses in our code, but should we worry about the libraries? Is this something I should look at before 4.7 or should we target 4.8 for these fixes, since nothing is technically broken right now?
Isaac
Hi
Isaac Bennetch píše v Pá 20. 01. 2017 v 10:19 -0500:
I was looking at some of the deprecation notices we're getting from jQuery after #12447 [1], and, while we can fix a lot of them ourselves, some seem to be in libraries we're using.
After a quick grep of the code, I see jqplot, several jquery files, and openlayers seem to be affected.
One of the deprecated functions is bind(). We're using jquery-migrate right now, so how much of a concern are these issues? I suppose we should fix the deprecated uses in our code, but should we worry about the libraries? Is this something I should look at before 4.7 or should we target 4.8 for these fixes, since nothing is technically broken right now?
I'd not care about deprecation notices for 4.7 (we can disable them in QA_4_7 later). However there might be some other breakages with jQuery 3.0 which will force us to downgrade back to 2.x.
On Fri, Jan 20, 2017 at 10:36 AM, Michal Čihař michal@cihar.com wrote:
Hi
Isaac Bennetch píše v Pá 20. 01. 2017 v 10:19 -0500:
I was looking at some of the deprecation notices we're getting from jQuery after #12447 [1], and, while we can fix a lot of them ourselves, some seem to be in libraries we're using.
After a quick grep of the code, I see jqplot, several jquery files, and openlayers seem to be affected.
One of the deprecated functions is bind(). We're using jquery-migrate right now, so how much of a concern are these issues? I suppose we should fix the deprecated uses in our code, but should we worry about the libraries? Is this something I should look at before 4.7 or should we target 4.8 for these fixes, since nothing is technically broken right now?
I'd not care about deprecation notices for 4.7 (we can disable them in QA_4_7 later). However there might be some other breakages with jQuery 3.0 which will force us to downgrade back to 2.x.
I've been trying hard to find something that's broken, but I have not yet seen anything.
-- Michal Čihař | https://cihar.com/ | https://weblate.org/
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
-
Isaac Bennetch -
Michal Čihař