[Phpmyadmin-devel] trunk and $GLOBALS['charset_connection']

Hi, in this revision: http://phpmyadmin.svn.sourceforge.net/viewvc/phpmyadmin/trunk/phpMyAdmin/lib... the code that sets $GLOBALS['charset_connection'] was removed. However this variable is still used. Marc

Marc Delisle schrieb:
Hi, in this revision: http://phpmyadmin.svn.sourceforge.net/viewvc/phpmyadmin/trunk/phpMyAdmin/lib...
the code that sets $GLOBALS['charset_connection'] was removed. However this variable is still used.
i see, my fault IMHO this occurrences can just be removed, their is no need for CONVERT(), this should all be done with SET NAMES by MySQL itself any conclusions? -- Sebastian

Sebastian Mendel schrieb:
Marc Delisle schrieb:
Hi, in this revision: http://phpmyadmin.svn.sourceforge.net/viewvc/phpmyadmin/trunk/phpMyAdmin/lib...
the code that sets $GLOBALS['charset_connection'] was removed. However this variable is still used.
i see, my fault
IMHO this occurrences can just be removed, their is no need for CONVERT(), this should all be done with SET NAMES by MySQL itself
any conclusions?
at least i have no working testcase where i get different results whether i use CONVERT() or not -- Sebastian

Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Hi, in this revision: http://phpmyadmin.svn.sourceforge.net/viewvc/phpmyadmin/trunk/phpMyAdmin/lib...
the code that sets $GLOBALS['charset_connection'] was removed. However this variable is still used. i see, my fault
IMHO this occurrences can just be removed, their is no need for CONVERT(), this should all be done with SET NAMES by MySQL itself
any conclusions?
at least i have no working testcase where i get different results whether i use CONVERT() or not
Ok then, thanks.
participants (2)
-
Marc Delisle
-
Sebastian Mendel