Hi Mac,
I think all the options in "*Table maintenance*" section need ajax
behavior (process without reloading the page). If you find any of the above mentioned options need changes can you please comment on those. I'll work with ajaxifying the "*Table maintenance*" section and update you as soon as possible.
In Table maintenance's current non-Ajax behavior, the results page contains unneeded parts.
For example, choosing "Check table" does this:
- display the generated query (ok)
- show the results containing status (ok)
- show Query results operations (unneeded)
- show Bookmark section (unneeded)
This is because tbl_operations.php calls sql.php when $_REQUEST['table_maintenance'] is set.
Try to remove the unneeded parts, at least for the new Ajax bahavior.
I worked with this feature and pushed my changes to the repo. Since I'm not very much familiar with the back end logic related with these features can you please check the operations and comment on the results. Thank you.
Regards, Thilanka.
Le 2011-08-07 06:59, Thilanka Kaushalya a écrit :
Hi Mac,
I think all the options in "*Table maintenance*" section need ajax
behavior (process without reloading the page). If you find any of the above mentioned options need changes can you please comment on those. I'll work with ajaxifying the "*Table maintenance*" section and update you as soon as possible.
In Table maintenance's current non-Ajax behavior, the results page contains unneeded parts.
For example, choosing "Check table" does this:
- display the generated query (ok)
- show the results containing status (ok)
- show Query results operations (unneeded)
- show Bookmark section (unneeded)
This is because tbl_operations.php calls sql.php when $_REQUEST['table_maintenance'] is set.
Try to remove the unneeded parts, at least for the new Ajax bahavior.
I worked with this feature and pushed my changes to the repo. Since I'm not very much familiar with the back end logic related with these features can you please check the operations and comment on the results. Thank you.
Regards, Thilanka.
Thilanka,
You removed unneeded parts but I believe you removed one needed part.
Let's take the case of CHECK TABLE. Looking at [0] this statement can return useful information (Msg_type, Msg_text).
When I try it without Ajax, I get such information so I believe that with Ajax I should also see it.
[0] http://dev.mysql.com/doc/refman/5.5/en/check-table.html
Hi Marc,
You removed unneeded parts but I believe you removed one needed part.
Let's take the case of CHECK TABLE. Looking at [0] this statement can return useful information (Msg_type, Msg_text).
When I try it without Ajax, I get such information so I believe that with Ajax I should also see it.
I'll work with this and update you soon. Thanks for instructions and testing the feature.
Regards, Thilanka.
Hi Marc,
You removed unneeded parts but I believe you removed one needed part.
Let's take the case of CHECK TABLE. Looking at [0] this statement can return useful information (Msg_type, Msg_text).
When I try it without Ajax, I get such information so I believe that with Ajax I should also see it.
I fixed this issue and pushed the changes to the repo. Can you please check that. Thank you.
Regards, Thilanka.
Le 2011-08-12 13:27, Thilanka Kaushalya a écrit :
Hi Marc,
You removed unneeded parts but I believe you removed one needed part.
Let's take the case of CHECK TABLE. Looking at [0] this statement can return useful information (Msg_type, Msg_text).
When I try it without Ajax, I get such information so I believe that with Ajax I should also see it.
I fixed this issue and pushed the changes to the repo. Can you please check that. Thank you.
Regards, Thilanka.
Thilanka, this issue is fixed but I found another one. Clicking on the icon to get documentation about each table maintenance action, executes the action instead of showing the doc.
Hi Marc,
this issue is fixed but I found another one. Clicking on the icon to get
documentation about each table maintenance action, executes the action instead of showing the doc
I fixed this issue and pushed the changes to the repo. Can you please check that. Thank you.
Regards, Thilanka.
Thilanka Kaushalya a écrit :
Hi Marc,
this issue is fixed but I found another one. Clicking on the icon to get documentation about each table maintenance action, executes the action instead of showing the doc
I fixed this issue and pushed the changes to the repo. Can you please check that. Thank you.
Regards, Thilanka.
Fix confirmed and merged.