[Phpmyadmin-devel] GSOC Interesting
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements . There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am. Best regards, Andreas Lundquist
Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it?
That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Well I am too new to this community. In my case I first wrote the patch and added it to the patch tracker. It was followed by suggestions and discussions and then got accepted and merged with the main repository :-D Samiran Raj Boro SF username: srajbr IRC nickname: samiran
2011/3/19 Lunkan <andreas.lunkan@gmail.com>:
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements. There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Hi Andreas, Thanks for the elaborate introduction. Welcome on the mailing list. To answer your question about the bug/feature tracker : it is always a good idea to let others know you are working on a patch, to avoid that two or more people are working on the same patch. But I guess before you start working on a patch, you reviewed the bug, tried to reproduce it and looked for the problem in order to get an idea on how to solve it, so by that time you should know if you will be able to fix it. ;) In the case you stop working on it, or don't plan to finish it, add another comment that you're not working on it anymore, so that others can work on it. Good luck with GSoC (and submitting your proposal). Kind regards, Dieter
Hi Dieter, Thanks. Don't know if this is the right place but I think I found a bug in inline editing of rows. The save button don't work like it should and when I looked through the code I found a strange looking line. sql_query += ' `' + field_name + "`='" + this_field_params[field_name].replace(/'/g, "''") + "' , "; This is line 842 in js/sql.js. I don't know how the end on that line should look but it's definitely not right with the quotations. Should I add a bug to the tracker about this and try to fix it? Kind regards, Andreas 2011/3/19 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>
2011/3/19 Lunkan <andreas.lunkan@gmail.com>:
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements . There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Hi Andreas,
Thanks for the elaborate introduction. Welcome on the mailing list.
To answer your question about the bug/feature tracker : it is always a good idea to let others know you are working on a patch, to avoid that two or more people are working on the same patch.
But I guess before you start working on a patch, you reviewed the bug, tried to reproduce it and looked for the problem in order to get an idea on how to solve it, so by that time you should know if you will be able to fix it. ;)
In the case you stop working on it, or don't plan to finish it, add another comment that you're not working on it anymore, so that others can work on it.
Good luck with GSoC (and submitting your proposal).
Kind regards,
Dieter
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2011/3/19 Andreas Lundquist <andreas.lunkan@gmail.com>:
Hi Dieter, Thanks. Don't know if this is the right place but I think I found a bug in inline editing of rows. The save button don't work like it should and when I looked through the code I found a strange looking line. sql_query += ' `' + field_name + "`='" + this_field_params[field_name].replace(/'/g, "''") + "' , "; This is line 842 in js/sql.js. I don't know how the end on that line should look but it's definitely not right with the quotations. Should I add a bug to the tracker about this and try to fix it?
Hi Andreas, Go ahead, submit the bug description on the bug tracker, mention you will work on it and if you have patch, submit that to the patch tracker. (as mentioned in the FAQ : http://www.phpmyadmin.net/documentation/#faq7_3) Kind regards, Dieter
Kind regards, Andreas
2011/3/19 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>
2011/3/19 Lunkan <andreas.lunkan@gmail.com>:
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page
at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements. There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Hi Andreas,
Thanks for the elaborate introduction. Welcome on the mailing list.
To answer your question about the bug/feature tracker : it is always a good idea to let others know you are working on a patch, to avoid that two or more people are working on the same patch.
But I guess before you start working on a patch, you reviewed the bug, tried to reproduce it and looked for the problem in order to get an idea on how to solve it, so by that time you should know if you will be able to fix it. ;)
In the case you stop working on it, or don't plan to finish it, add another comment that you're not working on it anymore, so that others can work on it.
Good luck with GSoC (and submitting your proposal).
Kind regards,
Dieter
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Groetjes, Dieter Adriaenssens
On Sat, Mar 19, 2011 at 11:19 PM, Andreas Lundquist < andreas.lunkan@gmail.com> wrote:
Hi Dieter,
Thanks. Don't know if this is the right place but I think I found a bug in inline editing of rows. The save button don't work like it should and when I looked through the code I found a strange looking line. sql_query += ' `' + field_name + "`='" + this_field_params[field_name].replace(/'/g, "''") + "' , "; This is line 842 in js/sql.js.
I don't know how the end on that line should look but it's definitely not right with the quotations. Should I add a bug to the tracker about this and try to fix it?
Kind regards, Andreas
Hi, What's wrong with the quotes, it loops over and collects all the fields, then trims the sql query for the additional "," that is appended for the last column. -- Rohit Sharma CSE IIIT-Hyderabad <http://iiit.net/>
2011/3/19 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>
2011/3/19 Lunkan <andreas.lunkan@gmail.com>:
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements . There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Hi Andreas,
Thanks for the elaborate introduction. Welcome on the mailing list.
To answer your question about the bug/feature tracker : it is always a good idea to let others know you are working on a patch, to avoid that two or more people are working on the same patch.
But I guess before you start working on a patch, you reviewed the bug, tried to reproduce it and looked for the problem in order to get an idea on how to solve it, so by that time you should know if you will be able to fix it. ;)
In the case you stop working on it, or don't plan to finish it, add another comment that you're not working on it anymore, so that others can work on it.
Good luck with GSoC (and submitting your proposal).
Kind regards,
Dieter
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- *Baby, Why not smile? *
Hi, If you say so, I just thought it looked weird but I don't know how replace() works. Could you describe what the replace function do? replace(/ '/g, " ' ' ") + " ' , "; I think the first start quotation just before the /g doesn't have any end quotation. Either way, I'm looking for a solution because I get an internal server error 500 for my inline editing ajax call to tbl_replace.php when saving. I think it's my environment as it works on the latest demo from the wiki but I don't know. Maybe someone else has got the same problem. Regards, Andreas 2011/3/19 rohit sharma <rsedwardian@gmail.com>
On Sat, Mar 19, 2011 at 11:19 PM, Andreas Lundquist < andreas.lunkan@gmail.com> wrote:
Hi Dieter,
Thanks. Don't know if this is the right place but I think I found a bug in inline editing of rows. The save button don't work like it should and when I looked through the code I found a strange looking line. sql_query += ' `' + field_name + "`='" + this_field_params[field_name].replace(/'/g, "''") + "' , "; This is line 842 in js/sql.js.
I don't know how the end on that line should look but it's definitely not right with the quotations. Should I add a bug to the tracker about this and try to fix it?
Kind regards, Andreas
Hi,
What's wrong with the quotes, it loops over and collects all the fields, then trims the sql query for the additional "," that is appended for the last column.
-- Rohit Sharma CSE IIIT-Hyderabad <http://iiit.net/>
2011/3/19 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>
2011/3/19 Lunkan <andreas.lunkan@gmail.com>:
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements . There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Hi Andreas,
Thanks for the elaborate introduction. Welcome on the mailing list.
To answer your question about the bug/feature tracker : it is always a good idea to let others know you are working on a patch, to avoid that two or more people are working on the same patch.
But I guess before you start working on a patch, you reviewed the bug, tried to reproduce it and looked for the problem in order to get an idea on how to solve it, so by that time you should know if you will be able to fix it. ;)
In the case you stop working on it, or don't plan to finish it, add another comment that you're not working on it anymore, so that others can work on it.
Good luck with GSoC (and submitting your proposal).
Kind regards,
Dieter
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- *Baby, Why not smile? *
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-03-19 16:26, Andreas Lundquist a écrit :
Hi,
If you say so, I just thought it looked weird but I don't know how replace() works. Could you describe what the replace function do? replace(/ '/g, " ' ' ") + " ' , "; I think the first start quotation just before the /g doesn't have any end quotation.
Either way, I'm looking for a solution because I get an internal server error 500 for my inline editing ajax call to tbl_replace.php when saving. I think it's my environment as it works on the latest demo from the wiki but I don't know. Maybe someone else has got the same problem.
(Please avoid top-posting). Please give a test case of what you are trying to inline edit. Server error 500 is at the server level (a level below phpMyAdmin) and not related to it. Anyway if there were an error in the generated Javascript, it would be seen at the browser's js console level, not at the server level.
Regards, Andreas
2011/3/19 rohit sharma <rsedwardian@gmail.com>
On Sat, Mar 19, 2011 at 11:19 PM, Andreas Lundquist < andreas.lunkan@gmail.com> wrote:
Hi Dieter,
Thanks. Don't know if this is the right place but I think I found a bug in inline editing of rows. The save button don't work like it should and when I looked through the code I found a strange looking line. sql_query += ' `' + field_name + "`='" + this_field_params[field_name].replace(/'/g, "''") + "' , "; This is line 842 in js/sql.js.
I don't know how the end on that line should look but it's definitely not right with the quotations. Should I add a bug to the tracker about this and try to fix it?
Kind regards, Andreas
Hi,
What's wrong with the quotes, it loops over and collects all the fields, then trims the sql query for the additional "," that is appended for the last column.
-- Rohit Sharma CSE IIIT-Hyderabad <http://iiit.net/>
2011/3/19 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>
2011/3/19 Lunkan <andreas.lunkan@gmail.com>:
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements . There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Hi Andreas,
Thanks for the elaborate introduction. Welcome on the mailing list.
To answer your question about the bug/feature tracker : it is always a good idea to let others know you are working on a patch, to avoid that two or more people are working on the same patch.
But I guess before you start working on a patch, you reviewed the bug, tried to reproduce it and looked for the problem in order to get an idea on how to solve it, so by that time you should know if you will be able to fix it. ;)
In the case you stop working on it, or don't plan to finish it, add another comment that you're not working on it anymore, so that others can work on it.
Good luck with GSoC (and submitting your proposal).
Kind regards,
Dieter
-- Marc Delisle http://infomarc.info
2011/3/19 Marc Delisle <marc@infomarc.info>
Please give a test case of what you are trying to inline edit. Server error 500 is at the server level (a level below phpMyAdmin) and not related to it.
Anyway if there were an error in the generated Javascript, it would be seen at the browser's js console level, not at the server level.
Say we have a table with any columns. 1. Then I go to Browse tab. 2. Click on Inline edit on a row. 3. Edit something or not, no difference. 4. Click on Save. 5. Nothing happen instantly as it should. I get an 500 Internal Server Error on the POST request to tbl_replace.php if I look in the console of firebug. 6. If I refresh the page the data has been saved to db. This is the information of the POST request. Response Headers: Date Sat, 19 Mar 2011 20:45:16 GMT Server Apache/2.2.15 (Linux/SUSE) X-Powered-By PHP/5.3.3 Expires Thu, 19 Nov 1981 08:52:00 GMT Cache-Control no-cache Last-Modified Sat, 19 Mar 2011 13:56:38 GMT Set-Cookie pma_collation_connection=deleted; expires=Fri, 19-Mar-2010 20:45:15 GMT; path=/dev/phpmyadmin/; httponly Content-Length 0 Connection close Content-Type application/json Request Headersview source Host localhost User-Agent Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101203 SUSE/3.6.13-0.2.1 Firefox/3.6.13 Accept */* Accept-Language en-us,en;q=0.5 Accept-Encoding gzip,deflate Accept-Charset ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive 115 Connection keep-alive Content-Type application/x-www-form-urlencoded; charset=UTF-8 X-Requested-With XMLHttpRequest Referer http://localhost/dev/phpmyadmin/sql.php?target=sql.php&token=64bf55643b883a9... Content-Length 385 Cookie pma_lang=en; pma_mcrypt_iv=vAABnpGDcJE%3D; pmaUser-1=kAtkNtgOL2Y%3D; pma_navi_width=200; phpMyAdmin=5g1ro8fuo6ndm2jj4ra1n0b8l33400hv; pmaPass-1=57Nm6BuuBU8%3D Parameters: ajax_request true clause_is_unique 1 db test disp_direction horizontal do_transformations false goto sql.php rel_fields_list sql_query UPDATE `editing` SET `id`='1' , `name`='hej' WHERE `editing`.`id` = 1 submit_type save table editing token 64bf55643b883a9f0d50ac20c98cce7f transform_fields_list where_clause %60editing%60.%60id%60+%3D+1
Le 2011-03-19 16:56, Andreas Lundquist a écrit :
2011/3/19 Marc Delisle <marc@infomarc.info>
Please give a test case of what you are trying to inline edit. Server error 500 is at the server level (a level below phpMyAdmin) and not related to it.
Anyway if there were an error in the generated Javascript, it would be seen at the browser's js console level, not at the server level.
Say we have a table with any columns. 1. Then I go to Browse tab. 2. Click on Inline edit on a row. 3. Edit something or not, no difference. 4. Click on Save. 5. Nothing happen instantly as it should. I get an 500 Internal Server Error on the POST request to tbl_replace.php if I look in the console of firebug. 6. If I refresh the page the data has been saved to db.
This is the information of the POST request.
Response Headers: Date Sat, 19 Mar 2011 20:45:16 GMT Server Apache/2.2.15 (Linux/SUSE) X-Powered-By PHP/5.3.3 Expires Thu, 19 Nov 1981 08:52:00 GMT Cache-Control no-cache Last-Modified Sat, 19 Mar 2011 13:56:38 GMT Set-Cookie pma_collation_connection=deleted; expires=Fri, 19-Mar-2010 20:45:15 GMT; path=/dev/phpmyadmin/; httponly Content-Length 0 Connection close Content-Type application/json Request Headersview source Host localhost User-Agent Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101203 SUSE/3.6.13-0.2.1 Firefox/3.6.13 Accept */* Accept-Language en-us,en;q=0.5 Accept-Encoding gzip,deflate Accept-Charset ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive 115 Connection keep-alive Content-Type application/x-www-form-urlencoded; charset=UTF-8 X-Requested-With XMLHttpRequest Referer http://localhost/dev/phpmyadmin/sql.php?target=sql.php&token=64bf55643b883a9... Content-Length 385 Cookie pma_lang=en; pma_mcrypt_iv=vAABnpGDcJE%3D; pmaUser-1=kAtkNtgOL2Y%3D; pma_navi_width=200; phpMyAdmin=5g1ro8fuo6ndm2jj4ra1n0b8l33400hv; pmaPass-1=57Nm6BuuBU8%3D
Parameters: ajax_request true clause_is_unique 1 db test disp_direction horizontal do_transformations false goto sql.php rel_fields_list sql_query UPDATE `editing` SET `id`='1' , `name`='hej' WHERE `editing`.`id` = 1 submit_type save table editing token 64bf55643b883a9f0d50ac20c98cce7f transform_fields_list where_clause %60editing%60.%60id%60+%3D+1
Are you using phpMyAdmin 3.4.0-beta4 or the git master version? Is your PHP compiled with JSON support? (it's possible to disable JSON at compile time). -- Marc Delisle http://infomarc.info
Are you using phpMyAdmin 3.4.0-beta4 or the git master version?
Is your PHP compiled with JSON support? (it's possible to disable JSON at compile time).
Thanks, I'm so sorry for this. It looks like I don't have any JSON support. I looked in the apache error log and it say Undefined function json_encode(). Hopefully it works when I install it. Thanks again.
On Sun, Mar 20, 2011 at 1:56 AM, Andreas Lundquist <andreas.lunkan@gmail.com
wrote:
Hi,
If you say so, I just thought it looked weird but I don't know how replace() works. Could you describe what the replace function do? replace(/ '/g, " ' ' ") + " ' , "; I think the first start quotation just before the /g doesn't have any end quotation.
Either way, I'm looking for a solution because I get an internal server error 500 for my inline editing ajax call to tbl_replace.php when saving. I think it's my environment as it works on the latest demo from the wiki but I don't know. Maybe someone else has got the same problem.
Regards, Andreas
Hi, The replace call does nothing wrong, it's just the correct way to include quote characters within a string in mysql. -- Regards Rohit Sharma CSE IIIT-Hyderabad <http://iiit.net/>
2011/3/19 rohit sharma <rsedwardian@gmail.com>
On Sat, Mar 19, 2011 at 11:19 PM, Andreas Lundquist < andreas.lunkan@gmail.com> wrote:
Hi Dieter,
Thanks. Don't know if this is the right place but I think I found a bug in inline editing of rows. The save button don't work like it should and when I looked through the code I found a strange looking line. sql_query += ' `' + field_name + "`='" + this_field_params[field_name].replace(/'/g, "''") + "' , "; This is line 842 in js/sql.js.
I don't know how the end on that line should look but it's definitely not right with the quotations. Should I add a bug to the tracker about this and try to fix it?
Kind regards, Andreas
Hi,
What's wrong with the quotes, it loops over and collects all the fields, then trims the sql query for the additional "," that is appended for the last column.
-- Rohit Sharma CSE IIIT-Hyderabad <http://iiit.net/>
2011/3/19 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>
2011/3/19 Lunkan <andreas.lunkan@gmail.com>:
Hi pma developing community! First of all, a small presentation, my name is Andreas Lundquist and is a pre-graduate student from Sweden. I have been using phpmyadmin a lot when doing things like small websites and so. It's always been my first choice when doing web development. I'm interested in the idea of improving the browse-mode like said on the idea page at http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements . There were quite many users who have sent in requests about this topic and many of them I think are possible to implement. Sadly I have never contributed to any open-source projects before so this mailinglist and stuff like git is quite new for me. However I have been using svn on some projects so I'm not to blown away of the idea. I have managed to get the source code to a local git repository and will create a repository on the site recommended by the git guide in the wiki. I will look through the source code and hopefully understand the structure and try to fix some bugs or requests from the bug tracker so I get the idea of sending in code to be reviewed. Just one question though just to be clear, am I supposed to write a line in the bug tracker before I start try to implement it even if I'm not sure I could do it? That's all for now, just thought I should present myself to the community so you know who I am.
Best regards, Andreas Lundquist
Hi Andreas,
Thanks for the elaborate introduction. Welcome on the mailing list.
To answer your question about the bug/feature tracker : it is always a good idea to let others know you are working on a patch, to avoid that two or more people are working on the same patch.
But I guess before you start working on a patch, you reviewed the bug, tried to reproduce it and looked for the problem in order to get an idea on how to solve it, so by that time you should know if you will be able to fix it. ;)
In the case you stop working on it, or don't plan to finish it, add another comment that you're not working on it anymore, so that others can work on it.
Good luck with GSoC (and submitting your proposal).
Kind regards,
Dieter
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- *Baby, Why not smile? *
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
participants (6)
-
Andreas Lundquist -
Dieter Adriaenssens -
Lunkan
-
Marc Delisle -
rohit sharma -
Samiran Raj Boro