Hi On Tue, 20 Mar 2007 13:24:54 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:

i would also drop the

if (!defined('PMA_MINIMUM_COMMON')) {

arround the functions, as i cannot think and do not detect any speed improvements upon this

the only thing where this would help if this 'not so' common function would be in another sperate file what is include if (!defined('PMA_MINIMUM_COMMON'))

common.inc.php:

require_once 'core.lib.php'; if (! defined('PMA_MINIMUM_COMMON')) { require_once 'common.lib.php' }

Okay for me. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

On Tue, 20 Mar 2007 13:45:35 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:

so you think split on core and common, or just remove if (!defined('PMA_MINIMUM_COMMON'))?

I meant the split to core and common. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

Marc Delisle schrieb:

Sebastian Mendel a écrit :

...

Sebastian Mendel schrieb:

...

Hi,

any odds against splitting common.lib.php into .lib.php and .inc.php?

common.lib.php

holding all functions

common.inc.php

including common.lib.php holding all procedural code

(easier testing of function) i would also drop the

if (!defined('PMA_MINIMUM_COMMON')) {

arround the functions, as i cannot think and do not detect any speed improvements upon this

the only thing where this would help if this 'not so' common function would be in another sperate file what is include if (!defined('PMA_MINIMUM_COMMON'))

common.inc.php:

require_once 'core.lib.php'; if (! defined('PMA_MINIMUM_COMMON')) { require_once 'common.lib.php' }

Take care, I tested removing define('PMA_MINIMUM_COMMON', true);

in phpmyadmin.css.php and it messes the display.

but this 'messed display' is affected by the procedural code, not the function definitions, IMHO -- Sebastian Mendel www.sebastianmendel.de

Michal Čihař schrieb:

On Tue, 20 Mar 2007 15:24:51 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:

...

there is no way of copieng a file in SVN? just like moving/renaming a file

to not lose history?

svn cp oldfile newfile

uh, oh, i am such a windows gui lamer ... ;-) tried to restore log, should have worked is all ok now? -- Sebastian Mendel www.sebastianmendel.de