Voila, commited my update to the cvs just a minute ago... Now there will be a lot of work to improve it... :)
Here a small TODO: - better fonts & html, code cleanup - add lang strings for leftlight.php specific messages - javascript: update both frames on DB selection - give the user the possibility to choose between the "standard" and the "light" view.
Comments of course welcome... Olivier
Olivier,
wow very cool! I also like the fact that table names are bigger (I suppose they could be a little smaller, but I hope not as small as in 2.2.3).
About "update both frames", which operations leave the user with non-synchronised frames?
I could do the lang strings if you want.
As we said, the view mode should be light by default. Could the choice of modes be integrated in the new db-based config/preferences module on which Robin is working?
Marc
"Olivier M." a écrit :
Voila, commited my update to the cvs just a minute ago... Now there will be a lot of work to improve it... :)
Here a small TODO: - better fonts & html, code cleanup - add lang strings for leftlight.php specific messages - javascript: update both frames on DB selection - give the user the possibility to choose between the "standard" and the "light" view.
Comments of course welcome... Olivier
On Fri, 11 Jan 2002, Marc Delisle wrote:
As we said, the view mode should be light by default. Could the choice of modes be integrated in the new db-based config/preferences module on which Robin is working?
Put it in the configuration file in the mean time. Using a database for all of the configuration options is not on the immediate list for the database module.
After I have come up with the basics of the database module, the immediate uses for it are: Per server/database configuration items. Host allow/deny rules. Column documentation
In any case, the lightleft stuff needs to be in the configuration file for those that are not using the new db system i'm working on.
For the lightleft modes, I would propose that it is an option in the configuration file that is disabled by default, as the average user of phpMyAdmin really only runs one or two databases. But there should still be a link in the main user interface to flip between the two views anyway.
hi Robin,
On Fri, Jan 11, 2002 at 10:55:51AM -0800, Robin Johnson wrote:
On Fri, 11 Jan 2002, Marc Delisle wrote:
As we said, the view mode should be light by default. Could the choice of modes be integrated in the new db-based config/preferences module on which Robin is working?
Put it in the configuration file in the mean time. Using a database for all of the configuration options is not on the immediate list for the database module.
sounds ok. thinks like this lightleft on/off should probably better be saved in a cookie on client's side.
After I have come up with the basics of the database module, the immediate uses for it are: Per server/database configuration items. Host allow/deny rules. Column documentation
So as replacement for the $cfgServers[2]['host'] = ''; $cfgServers[2]['port'] = ''; $cfgServers[2]['socket'] = ''; $cfgServers[2]['connect_type'] = 'tcp'; $cfgServers[2]['stduser'] = ''; [..] part of the db?
For the lightleft modes, I would propose that it is an option in the configuration file that is disabled by default, as the average user of phpMyAdmin really only runs one or two databases. But there should still be a link in the main user interface to flip between the two views anyway.
well, the config file is valid for both "normal" users and superuser, and superuser will probably prefer the light version. Mmm, maybe we could add an array in the config file to define the default view on a per-user base:
$defaultLight = array( "root"=>TRUE, "mysql"=>TRUE, "alberto"=>TRUE, "jo"=>FALSE );
Everything is possible :) Good evening, Olivier
Robin Johnson a écrit :
On Fri, 11 Jan 2002, Marc Delisle wrote:
As we said, the view mode should be light by default. Could the choice of modes be integrated in the new db-based config/preferences module on which Robin is working?
Put it in the configuration file in the mean time. Using a database for all of the configuration options is not on the immediate list for the database module.
After I have come up with the basics of the database module, the immediate uses for it are: Per server/database configuration items. Host allow/deny rules. Column documentation
Ok I understand. Maybe we don't need per-user column documentation :)
In any case, the lightleft stuff needs to be in the configuration file for those that are not using the new db system i'm working on.
Right!
For the lightleft modes, I would propose that it is an option in the configuration file that is disabled by default, as the average user of phpMyAdmin really only runs one or two databases. But there should still be a link in the main user interface to flip between the two views anyway.
With Olivier's patch, a user that only has one db does not see leftlight.
Marc
On Fri, Jan 11, 2002 at 04:26:38PM -0500, Marc Delisle wrote:
For the lightleft modes, I would propose that it is an option in the configuration file that is disabled by default, as the average user of phpMyAdmin really only runs one or two databases. But there should still be a link in the main user interface to flip between the two views anyway.
With Olivier's patch, a user that only has one db does not see leftlight.
well, it still use the leftlight.php3, but the code is exactely the same as in left.php3, which is maybe not so nice.
Maybe it would be better to keep everything in a single file (left.php3). Would simplify the choice, and the selection between both mode would only occur in this file, and not at every place where left.php is called...
Olivier
Hi Marc & rest of the world :)
On Fri, Jan 11, 2002 at 01:00:03PM -0500, Marc Delisle wrote:
wow very cool! I also like the fact that table names are bigger (I suppose they could be a little smaller, but I hope not as small as in 2.2.3).
that is most probably a CSS/html side effect: for example in opera the table names are very big, and in netscape4/linux the font is wrong (small, and times instead of arial). I'll try to find the bugs, but I guess our XHTML & JS guru Loic will find that before I will :)
About "update both frames", which operations leave the user with non-synchronised frames?
I'll also have to open my O'Reilly JS-reference book... But that is most probably a small issue.
I could do the lang strings if you want.
If you think the displayed strings are fine, ok :) Otherwise we can wait a bit more...
As we said, the view mode should be light by default.
that is currently the case in the cvs config file.
Could the choice of modes be integrated in the new db-based config/preferences module on which Robin is working?
probably... now the question is: do we want to let the user be able to switch between both modes?
other idea: we could also add a "leftlightdual.php3" which would display 2 independent pull down menus, and would work the same as the other -> would be usefull for DB comparaison...
Voila, au boulot... :) Olivier
PS: have you (or loic) created the phpmyadmin-translators mailing list ? If yes could you send me the ML admin password? Mine is not working, and I get a reminder mail every night since about 3 months because of a problematic posting... Merci!
On Friday, January 11, 2002, at 09:01 PM, Olivier M. wrote:
About "update both frames", which operations leave the user with non-synchronised frames?
I'll also have to open my O'Reilly JS-reference book... But that is most probably a small issue.
What about that js-function:
/** * Changes the content of 2 frames simultaneously * * @param string the target URI for the 1st frame * @param string the name of the 1st frame * @param string the target URI for the 2nd frame * @param string the name of the 2nd frame * * @return boolean always true */ function twoFrames(URI1,frame1,URI2,frame2) { frame1 = eval("parent." + frame1); frame2 = eval("parent." + frame2); frame1.location.href = URI1; frame2.location.href = URI2;
return true; }
Greetings,
Joachim
"Olivier M." a écrit :
I could do the lang strings if you want.
If you think the displayed strings are fine, ok :) Otherwise we can wait a bit more...
You are right, it's too early in the development cycle!
other idea: we could also add a "leftlightdual.php3" which would display 2 independent pull down menus, and would work the same as the other -> would be usefull for DB comparaison...
Well, I still think that this need could be filled by opening another browser window.
PS: have you (or loic) created the phpmyadmin-translators mailing list ? If yes could you send me the ML admin password? Mine is not working, and I get a reminder mail every night since about 3 months because of a problematic posting... Merci!
Sorry, I did not create this list.
Marc
-
Joachim Fornallaz -
Marc Delisle -
Olivier M. -
Robin Johnson