Hi,
I'm working on "Refactoring: Displaying query results" [0] project idea under GSoC 2012.
In my demo server project [1] the configurations for extended features like "Creation of PDFs", "Browser transformation", "Bookmarked SQL query" etc are already done *without "User preferences".* As well a new user "pma" is already created there, but with a different password instead of general "pmapass".
In my local machine I just enable these all extended features and "error displaying" by introducing "config.inc.php" file. And set the control user (pma) password to general one (pmapass).
If I commit this configuration file, the demo server project configurations will be override. ("error displaying" , "User preferences", "control user password" will change) So is it a good idea to commit these changes ? Your suggestions are welcome.
[0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka77... [1] : http://demo.phpmyadmin.net/gsoc-chanaka/
Regards !
2012/5/7 Chanaka Dharmarathna pe.chanaka.ck@gmail.com:
Hi,
I'm working on "Refactoring: Displaying query results" [0] project idea under GSoC 2012.
In my demo server project [1] the configurations for extended features like "Creation of PDFs", "Browser transformation", "Bookmarked SQL query" etc are already done without "User preferences". As well a new user "pma" is already created there, but with a different password instead of general "pmapass".
In my local machine I just enable these all extended features and "error displaying" by introducing "config.inc.php" file. And set the control user (pma) password to general one (pmapass).
If I commit this configuration file, the demo server project configurations will be override. ("error displaying" , "User preferences", "control user password" will change) So is it a good idea to commit these changes ? Your suggestions are welcome.
[0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka77... [1] : http://demo.phpmyadmin.net/gsoc-chanaka/
You should never commit your own configuration file, only the template should be in repository - if you need some changes made on demo server just ask for it.
On Mon, May 7, 2012 at 1:17 PM, Piotr Przybylski piotr.prz@gmail.comwrote:
2012/5/7 Chanaka Dharmarathna pe.chanaka.ck@gmail.com:
Hi,
I'm working on "Refactoring: Displaying query results" [0] project idea under GSoC 2012.
In my demo server project [1] the configurations for extended features
like
"Creation of PDFs", "Browser transformation", "Bookmarked SQL query" etc are already done without "User preferences". As well a new user "pma" is already created there, but with a different password instead of general "pmapass".
In my local machine I just enable these all extended features and "error displaying" by introducing "config.inc.php" file. And set the control
user
(pma) password to general one (pmapass).
If I commit this configuration file, the demo server project
configurations
will be override. ("error displaying" , "User preferences", "control user password" will change) So is it a good idea to commit these changes ? Your suggestions are welcome.
[0] :
http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka77...
You should never commit your own configuration file, only the template should be in repository - if you need some changes made on demo server just ask for it.
-- Regards, Piotr Przybylski
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Piotr,
Thanks for you quick reply. I got it. I'll ask my mentor, the needed changes in configurations.
Regards !
Hi
Dne Mon, 7 May 2012 09:17:26 +0530 Chanaka Dharmarathna pe.chanaka.ck@gmail.com napsal(a):
In my demo server project [1] the configurations for extended features like "Creation of PDFs", "Browser transformation", "Bookmarked SQL query" etc are already done *without "User preferences".* As well a new user "pma" is already created there, but with a different password instead of general "pmapass".
Well the password is different, but that should not matter as all demos are configured to use it.
User preferences are not configured for single reason - there would be thousands of users sharing one configuration if it would be stored on server, what would be quite confusing. Currently the configuration is stored in client or session giving consistent behavior to every user.
In my local machine I just enable these all extended features and "error displaying" by introducing "config.inc.php" file. And set the control user (pma) password to general one (pmapass).
If I commit this configuration file, the demo server project configurations will be override. ("error displaying" , "User preferences", "control user password" will change) So is it a good idea to commit these changes ?
No, never commit configuration file.
On Wed, May 9, 2012 at 5:47 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Mon, 7 May 2012 09:17:26 +0530 Chanaka Dharmarathna pe.chanaka.ck@gmail.com napsal(a):
In my demo server project [1] the configurations for extended features
like
"Creation of PDFs", "Browser transformation", "Bookmarked SQL query" etc are already done
*without
"User preferences".* As well a new user "pma" is already created there, but with a different password instead of general "pmapass".
Well the password is different, but that should not matter as all demos are configured to use it.
User preferences are not configured for single reason - there would be thousands of users sharing one configuration if it would be stored on server, what would be quite confusing. Currently the configuration is stored in client or session giving consistent behavior to every user.
In my local machine I just enable these all extended features and "error displaying" by introducing "config.inc.php" file. And set the control
user
(pma) password to general one (pmapass).
If I commit this configuration file, the demo server project
configurations
will be override. ("error displaying" , "User preferences", "control user password" will change) So is it a good idea to commit these changes ?
No, never commit configuration file.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Michal,
Thanks for replying. I understand the situation. Hope "error displaying" has already enabled in the demo server.
Regards !
Hi
Dne Thu, 10 May 2012 01:14:55 +0530 Chanaka Dharmarathna pe.chanaka.ck@gmail.com napsal(a):
Thanks for replying. I understand the situation. Hope "error displaying" has already enabled in the demo server.
Indeed it is. But still you should test your changes locally before pushing them out.
On Thu, May 10, 2012 at 12:51 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Thu, 10 May 2012 01:14:55 +0530 Chanaka Dharmarathna pe.chanaka.ck@gmail.com napsal(a):
Thanks for replying. I understand the situation. Hope "error displaying" has already enabled
in
the demo server.
Indeed it is. But still you should test your changes locally before pushing them out.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Marc,
You are extremely correct. I usually pay my attention on the code again and test them in UI before pushing them out.
Regards !
-
Chanaka Dharmarathna -
Michal Čihař -
Piotr Przybylski