Hi Benjamin & all!
Once a day, Benjamin wrote:
>- one stripSlashes() that should not be done when executing SQL
> queries an a database. The query displayed in the textarea after
> execution has slashes stripped off, and that should not be done.
Should be fixed in the CVS.
>- tbl_properties.php3: there is no link to "empty" the table. this
> feature is only available in db_details.php3. why not putting it in
> tbl_properties.php3?
Added after "Browse - Select - Insert" links and merged into the CVS.
Cheers,
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi All!
Here it is: I'm back and up to date with the new code. So I may start to
work on
bugs now (just after I've finished to update 'users_details.php3').
BTW I've done some little updates on the CVS today. Note that I've removed
some annoying ^M EOL from 4 files.
Greets,
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi,
three big bugs:
- if you change a row with a 'set' field,
phpMyAdmin saves : 'Array$' instead of the
field values
- on 'enum' fields tbl_change.php3 lose the
enum state
- the binary field protection
binary varchars is not working if the
$cfgProtectBlob=true.
In RC3 it works fine.
Regards,
--
Steve
I forgot one more thing:
- lib.inc.php3: the function remove_remarks() is bugged because
if a string contains a '#' in a string, it is considered as a
comment. As stated in bug #444279.
I already said that comments need not being stripped off queries.
Mysql works just fine if you give it all the comments. No need
removing them (as is was in my 2.1.0.1 version).
I made tests and removing the call to remove_remarks() does not
affect queries that have comments *at all*. The call to
remove_remarks() is *really* useless in db_readdump.php3.
PS: sorry for double posting one of my previous messages.
> No, because a single newline after the closing tag is
> silently ignored. I
> propose the following:
>
> <textarea name="fields[<?php echo urlencode($field); ?>]"
> rows="<?php echo $cfgTextareaRows; ?>"
> cols="<?php echo $cfgTextareaCols; ?>"
> ><?php if
> (!empty($special_chars)) echo $special_chars . "\n"; ?>
> </textarea>
Ok, but I didn't see anywhere in php documentation that
trailing newlines are silently ignored. We should also be
careful that problems may arise with editors using other
end of lines than unix ones (dos' \r\n and mac's \r).
If somebody editing the code with an editor that doesn't
preserve end of lines may break it, the code becomes "text
editor dependant" which is not exactly our goal... :)
Benjamin
