> If anyone is interested in seeing it all in action, or wants
> to get some
> ideas about what I came up with, check out
>
> http://65.5.154.16/phpMyAdmin/
Wouch! You don't like original colors and display, do you ? :)
If it were not written, it would be hard to say it's really
phpMyAdmin!
Anyway, templates like in phpGroupWare would be the best way
to provide easy customization, but the current design is not
suitable for that. We should choose between some customization
with some cfg variables and a better design allowing themes.
In defines.inc.php in rc4 it tries to get the mysql version, even if the
$server variable is set to 0, as it is if no default server is set to
start with...simply add an if($server) around this last part of
defines.inc.php
Dan
I really think that phpMyAdmin needs more configuration variables...It
is fine to go ahead and give them defaults which many people will not
change, but if someone does want to tune the look, it is really
difficult now. Here is a general suggestion to start out...
Everytime a table is used with this code
<table border="<?php echo $cfgBorder; ?>">
It should instead be
<table border="<?php echo $cfgBorder; ?>" cellspacing="<?php echo
$cfgSpacing; ?>" cellpadding="<?php echo $cfgPadding; ?>">
Here are my other suggestions:
- Have a variable for font size (and since windows and unix handle font
sizes so differently there should be OS sniffing to scale the size)
- Like W3C recommends, font-sizes should be in em and not in pt
- There should be more color preferences...such as link color
backgrounds for hover and all that
I have patches for most of this stuff, but phpMyAdmin is changing so
fast I just can't get a patch made that will work with the
version...obviously I need to learn CVS, but at least I can make
suggestions while I am learning. Please comment on the ideas.
Dan Allen
Hi!
I've replied to this message in the forum. Please do not post the same
message
on two places, just be patient ;)
Regards,
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
On Thu, Aug 09, 2001 at 01:39:24PM -0700, Dan Allen wrote:
> I hope that you don't mind that I am e-mailing you. I had posted some
no problem. the best for your patches would be that
you upload them on the sourceforge feature or bugs tracker,
and post a short note to the devel-ml.
> patches yesterday and they were from the old version...I didn't even
> think about cvs, but since the new version rc4 just came out, I reedited
> the files and created patches from that version. In addition to the
> patches I listed about socket and permission I also have a NULL patch,
> which, when an number cell has a value of empty string, it shouldn't
> show empty string but NULL, since it is impossible for a number cell to
> just be blank (try it in mysql terminal client). Also, when you entered
> the editor, the fields that were numbers and NULL showed up as blank and
> when you inserted the data, the blanks would fill in as the default
> (either 0 or the value set)...so, if the field is empty when going into
> the editor (when you click on Edit) it auto fills in NULL where the
> number cell is blank. I was also thinking about adding this for new
> cells...so when you go to insert new data, number fields start out as
> either NULL (if the parameter is NULL) or 0 (if the parameter is
> NOT_NULL). If you reply, I will send you those diffs and you can throw
> out what you don't like and keep what you like.
>
> Dan Allen
--
_________________________________________________________________
Olivier Mueller - om(a)8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch
This post is simply a request for clarification. What does the function
out_buffer_pre($ob_mode) do? I am a bit confused, and all I know is
that if I use galeon the main.php is not rendered at all (and the source
is empty). Now, I realize that this is not a phpMyAdmin bug, but
perhaps if I knew what it did, I could go over to the guys and gals at
galeon and let them know what is cause the browser to break. Thanks for
the time!
Dan Allen
I have a phpMyAdmin installed on the web server.
When I try to delete any row (entry) in the database, I click on delete link
to the right of the entry. Then I click on yes. The following string
appears:
Warning: Cannot add header information - headers already sent by (output
started at config.inc.php3:118) in /usr/local/web/data/sql/sql.php3 on line
94
Here's part of sql.php3:
if (!$result)
{
$error = mysql_error();
include("header.inc.php3");
mysql_die($error);
}
$num_rows = @mysql_num_rows($result);
if ($num_rows < 1)
{
// PATCH ADDITION BEGINS
// if (file_exists($goto))
if(file_exists("./$goto"))
// PATCH ADDITION ENDS
{
include("header.inc.php3");
if (isset($zero_rows) && !empty($zero_rows))
$message = $zero_rows;
else
$message = $strEmptyResultSet;
// PATCH ADDITION BEGINS
// include($goto);
include(preg_replace('/\.\.*/', '.', $goto));
// PATCH ADDITION ENDS
}
else
{
$message = $zero_rows;
Header("Location: $goto");
}
exit;
}
else
{
include("header.inc.php3");
display_table($result);
if (!eregi("SHOW VARIABLES|SHOW PROCESSLIST|SHOW STATUS", $sql_query))
echo "<p><a href=\"tbl_change.php3?server=$server&db=$db&table=$tab
le&goto=sql.php3?".urlencode($GLOBALS['QUERY_STRING'])."\">
$strInsertNewRow</a>
</p>";
}
}
require ("footer.inc.php3");
?>
What does this mean, and how to prevent that error from ocurring?
__________________
Dmitry Kashlev
Webmaster
Bronx Science Computing
Good morning, Salut!
The 4th Release Candidate for phpMyAdmin version 2.2.0 is
available from: http://phpmyadmin.sourceforge.net/
As usual, too many fixes to all be listed here, so please simply
have look at the ChangeLog (huge!):
http://phpmyadmin.sourceforge.net/ChangeLog.txt
Regards,
Olivier/swix, for the devel team.
--
_________________________________________________________________
Olivier Mueller - om(a)8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch
Hi Marc & all!
>Should we check if the function extension_loaded exists before calling
>it? Or is the @ enough?
'@' is not enough, you have to use "if
(@function_exists('extension_loaded'))"
to do the work.
>And should we do this for every PHP4-specific function we find in the
>code?
Well, this could be a good idea but in the case of the bug report we're
talking
about, the problem is a bit more annoying: lots of the functions that exists
in
php3.0.10+ and php4.0.0 are not implemented in php4.0 beta releases. It
means that you have to test each function (even php3 ones) before to use
them.... Really painfull.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Marc voted yes, and I also think it would soon be time to
release something again. So, Loic & other developpers, you have
10 hours to answer :) If I don't get a negative answer, it
will prepare everything tomorrow morning.
Regards,
Olivier
--
_________________________________________________________________
Olivier Mueller - om(a)8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch
