March 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Automated Testing - GSoC Project Proposal 2012
by yasitha pandithawatta 31 Mar '12

31 Mar '12

Hi Michal, I have submitted my project proposal for the automated testing project under GSoC. If you can review it and give me a feed back and show me the improvements to done, it will be highly appreciated. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka

1 0

Re: [Phpmyadmin-devel] Phpmyadmin-devel Digest, Vol 68, Issue 52
by G R Lewis 31 Mar '12

31 Mar '12

I recently contributed a bit of code in a message to this list. It created a new transformation "Append" that just appended the specified text to a field for display. I don't know if any developer actually captured my contribution for incorporation into the code base. I'm not a serious developer and have no wish to become one. In fact I plan to unsubscribe from this list soon. If anybody wants to pursue this, let me know. On Mar 28, 2012, at 12:29 PM, phpmyadmin-devel-request(a)lists.sourceforge.net wrote: > Send Phpmyadmin-devel mailing list submissions to > phpmyadmin-devel(a)lists.sourceforge.net > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > or, via email, send a message with subject or body 'help' to > phpmyadmin-devel-request(a)lists.sourceforge.net > > You can reach the person managing the list at > phpmyadmin-devel-owner(a)lists.sourceforge.net > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Phpmyadmin-devel digest..." > Today's Topics: > > 1. Re: guidelines for avoiding security pitfalls (Marc Delisle) > 2. phpMyAdmin at Percona MySQL Live Conference & Expo 2012 > (Michal ?iha?) > 3. phpMyAdmin 3.4.10.2 is released (Marc Delisle) > 4. Re: Automated Testing - GSoC Project Idea 2012 > (yasitha pandithawatta) > > From: Marc Delisle <marc(a)infomarc.info> > Subject: Re: [Phpmyadmin-devel] guidelines for avoiding security pitfalls > Date: March 28, 2012 5:37:54 AM PDT > To: phpmyadmin-devel(a)lists.sourceforge.net > Reply-To: phpmyadmin-devel(a)lists.sourceforge.net > > > Le 2012-03-28 04:53, Michal Čihař a écrit : >> Hi >> >> Dne Tue, 27 Mar 2012 22:01:05 +0200 >> Dieter Adriaenssens <dieter.adriaenssens(a)gmail.com> napsal(a): >> >>> As discussed on the team meeting in February, I started creating a >>> wiki page with some guidelines for avoiding security bugs [0]. >>> The page is not finished yet, I just set out some ideas, that I will >>> work out in the next few days. Feel free to comment, improve or add >>> guidelines as you see fit. >>> >>> [0] http://wiki.phpmyadmin.net/pma/Security_pitfalls >> >> Thanks, looks great so far! > > Yes, thanks. I'm wondering, are there places where we really use > htmlentities() for protection? > > Also I think we should talk about PMA_sanitize(). > > -- > Marc Delisle > http://infomarc.info > > > > > From: Michal Čihař <michal(a)cihar.com> > Subject: [Phpmyadmin-devel] phpMyAdmin at Percona MySQL Live Conference & Expo 2012 > Date: March 28, 2012 6:44:57 AM PDT > To: phpmyadmin-devel(a)lists.sourceforge.net, phpmyadmin-users(a)lists.sf.net, phpmyadmin-news(a)lists.sf.net > Reply-To: phpmyadmin-devel(a)lists.sourceforge.net > > > Hi, > > phpMyAdmin will be participating in the Percona MySQL Live Conference & > Expo, April 10-12, 2012, in Santa Clara, California. > > Be sure to stop by and visit us at the Dot Org Pavilion! > > Need a discount code? "PHP-PL12" will save you 10%. > > For more information see > http://www.percona.com/live/mysql-conference-2012/ > > -- > Michal Čihař for the phpMyAdmin team > > > > > > From: Marc Delisle <marc(a)infomarc.info> > Subject: [Phpmyadmin-devel] phpMyAdmin 3.4.10.2 is released > Date: March 28, 2012 9:58:46 AM PDT > To: phpmyadmin-news(a)lists.sf.net, phpmyadmin-users(a)lists.sf.net, phpmyadmin-devel(a)lists.sf.net > Reply-To: phpmyadmin-devel(a)lists.sourceforge.net > > > Welcome to phpMyAdmin 3.4.10.2, a minor security release. > > Please refer to the upcoming PMASA-2012-2 announcement on > http://www.phpmyadmin.net/home_page/security. > > Details will appear on http://phpmyadmin.net. In a hurry? you can visit > http://sourceforge.net/projects/phpmyadmin to download. > > Marc Delisle, for the team > > > > > From: yasitha pandithawatta <yasitha4(a)gmail.com> > Subject: Re: [Phpmyadmin-devel] Automated Testing - GSoC Project Idea 2012 > Date: March 28, 2012 12:29:34 PM PDT > To: phpmyadmin-devel(a)lists.sourceforge.net > Reply-To: phpmyadmin-devel(a)lists.sourceforge.net > > > > > 2012/3/21 yasitha pandithawatta <yasitha4(a)gmail.com> > > > 2012/3/17 yasitha pandithawatta <yasitha4(a)gmail.com> > > On Wed, Mar 14, 2012 at 11:04 PM, yasitha pandithawatta <yasitha4(a)gmail.com> wrote: > > > On Tue, Mar 13, 2012 at 2:22 AM, Marc Delisle <marc(a)infomarc.info> wrote: > Le 2012-03-12 15:23, Michal Čihař a écrit : > > Hi > > > > Dne Tue, 6 Mar 2012 08:53:13 +0530 > > yasitha pandithawatta <yasitha4(a)gmail.com> napsal(a): > > > >> I have set up the the testing environment. I tried to run some test suits. > >> I have found most of the test suits have some fatal errors. Test classes > >> under test/libraries/ are working fine. > >> I went through the AllTest.php. The required paths have some conflicts with > >> the real paths. > >> > >> Most of the cases I'll getting the following fatal error. > >> > >> PHP Fatal error: require_once(): Failed opening required > >> './test/PMA_get_real_size_test.php' > >> (include_path='.:/usr/share/php:/usr/share/pear:') in > >> /var/www/phpmyadmin-dev/test/AllTests.php on line 32 > >> (File path for an example) > >> > >> And required require_once './test/FailTest.php' is not found in the package. > >> > >> What can I do for these issues? > > > > Well AllTests.php is not really used for testing. To run complete > > testsuite, running phpunit in phpMyAdmin's directory should do the job. > > I think AllTests.php is pretty much outdated and probably should be > > rather dropped... > > Done, along with AllSeleniumTests.php. > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > Try before you buy = See our experts in action! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-dev2 > > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > > Hi, > > I went through the AllSeleniumTests.php and found the tests are outdated. I started to re write the PmaSeleniumTestCase.php and I updated the PmaSeleniumLoginTest.php. I just add the login test to the AllSeleniumTest suit. If I can get a feed back I can write the test cases for the remaining two suits. Patch was attached to the source forge patch tracker.[1] > Add a README file under /test/selenium which contains testing configuration guide. > > Regards, > > -- > Yasitha Pandithawatta > Undergraduate > Computer Science and Engineering Department > University of Moratuwa > Sri Lanka > > [1] - https://sourceforge.net/tracker/?func=detail&aid=3504536&group_id=23067&ati… > > Hi Michal, > > I wrote some selenium test cases for login. I updated the AllSeleniumTests.php and add I add a Helper class and TestConfig class which can be use when writing other test cases. I attached the changes as patch in source forge patch tracker.[1] Meanwhile Mark has removed the AllTests.php along with AllSeleniumTests.php. Since AllSeleniumTests.php class is no longer there patch will give some errors. He suggested some one familiar with selenium should involved with this. ch willCan you look for this. Adding old AllSeleniumTests.php and merge my patch will do the job. > > Regards, > -- > Yasitha Pandithawatta > Undergraduate > Computer Science and Engineering Department > University of Moratuwa > Sri Lanka > > [1] - https://sourceforge.net/tracker/?func=detail&aid=3504536&group_id=23067&ati… > > > Hi, > > I updated the patch and attached to the patch traker. [1]. It can be directly merged into the current master branch. > > Regards, > -- > Yasitha Pandithawatta > Undergraduate > Computer Science and Engineering Department > University of Moratuwa > Sri Lanka > > [1] - https://sourceforge.net/tracker/?func=detail&aid=3504536&group_id=23067&ati… > > Hi, > > I fixed the PmaSeleniumPrivilegesTest and PmaSeleniumXssTest classes as well. I attached the patch in the source forge patch tracker.[0] > In PmaSeleniumXssTest class I added a method testQueryTabWithNullValue() to test the processing a null query. But there should be another method to handle the query with xss scripts. For this I need to call selenium.type() on the respective textarea. > But in the latest version the textarea is replaced with codemirror object. It doesn't have an id and cannot access via Xpath. Can you give any suggestion for this? > > Regards, > > -- > Yasitha Pandithawatta > Undergraduate > Computer Science and Engineering Department > University of Moratuwa > Sri Lanka > > [1] - https://sourceforge.net/tracker/?func=detail&aid=3512509&group_id=23067&ati… > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure__________________________________________… > Phpmyadmin-devel mailing list > Phpmyadmin-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

2 2

[Phpmyadmin-devel] htmlspecialchars in PMA_Error
by J.M. 30 Mar '12

30 Mar '12

The htmlspecialchars escaping of error messages in PMA_Error, introduced in https://github.com/phpmyadmin/phpmyadmin/commit/656809ac3bdc8ba61b84657b878…, causes problems with error messages containing links. See this photo for reference: http://cl.ly/FQ0H, read main.php, lines 293 and 329. Do we prefer using trigger_error() or the direct PMA_Message::display variant? -- mynetx

2 2

[Phpmyadmin-devel] Dead code?
by Madhura Jayaratne 30 Mar '12

30 Mar '12

Hi, I am wondering whether the following code segments are being used anywhere. These code segments were added during the last GSoC for the zoom search feature. But the zoom search uses Highcharts to generate the plot and works without these code. Am I missing anything? PMA_SVG_scatter_plot function in /libraries/tbl_select.lib.php PMA_Scatter_Plot class in /libraries/svg_plot/pma_scatter_plot.php PMA_SVG_Data_Element class in /libraries/svg_plot/pma_svg_data_element.php PMA_SVG_Data_Point class in /libraries/svg_plot/pma_svg_data_point.php -- Thanks and Regards, Madhura Jayaratne

3 3

[Phpmyadmin-devel] Refactoring: Insert/edit, Privileges, Operations, Structure
by Shameeha Pp 30 Mar '12

30 Mar '12

Sir, I have gone through the project "Refactoring:Insert/edit, Privileges, Operation,Structure". I think that refactoring means technique for restructuring an existing body of code, altering its internal structure without changing its external behavior. I worked out for some portion of the application tbl_structure.php. <table id="tablestructure" class="data"> <thead> <tr> <th id="th<?php echo ++$i; ?>"></th> <th id="th<?php echo ++$i; ?>">#</th> <th id="th<?php echo ++$i; ?>" class="column"><?php echo __('Column'); ?></th> <th id="th<?php echo ++$i; ?>" class="type"><?php echo __('Type'); ?></th> <th id="th<?php echo ++$i; ?>" class="length"><?php echo __('Length(bytes)'); ?></th> <th id="th<?php echo ++$i; ?>" class="precision"><?php echo __('Precesion'); ?></th> <th id="th<?php echo ++$i; ?>" class="Scale"><?php echo __('Scale'); ?></th> <th id="th<?php echo ++$i; ?>" class="null"><?php echo __('Null'); ?></th> <th id="th<?php echo ++$i; ?>" class="default"><?php echo __('Default'); ?></th> <th id="th<?php echo ++$i; ?>" class="extra"><?php echo __('Extra'); ?></th> <?php if ($db_is_information_schema || $tbl_is_view) { ?> <th id="th<?php echo ++$i; ?>" class="view"><?php echo __('View'); ?></th> <?php } I transform the above code into the following code. <?php $field=array("Name","Type","Collation","Attributes","Null","Default","Extra","View"); reset($field); foreach ($field as $key => $value) { echo "__('$value')\t"; } ?> Please give me your comments on this. I would like to continue this work as part of GSOC 2012 and I will be submitting the application soon. Thanking you.. Shameeha

2 1

[Phpmyadmin-devel] Broken "with selected" action in master
by Rouslan Placella 30 Mar '12

30 Mar '12

Hi there, Just noticed that in current master the "With selected -> delete" functionality when browsing a table is broken. According to git-bisect this commit[0] broke it. To reproduce the issue in current master: * Browse any table * Tick the checkbox near at least one row * Click on "with selected" -> "Delete" * Page is just reloaded Bye, Rouslan https://github.com/phpmyadmin/phpmyadmin/commit/ef95bce35bddf3f01c6c6ad73d1…

2 1

[Phpmyadmin-devel] Not translated translations
by Michal Čihař 29 Mar '12

29 Mar '12

Hi while looking at checks Weblate does on translation, I've noticed that there are quite a lot of strings, which are actually not translated. To name top four languages: Georgian 753 Bengali 481 Sinhala 259 Romanian 153 So yes, these strings in fact are not translated and simply copied from English. Indeed this might be valid for some short terms, though it can be hardly true for sentence. You can see yourself strings at: https://l10n.cihar.com/checks/same/phpmyadmin/3-5/ As I think this should be fixed, I've hacked script to remove such "translations". I tried to be as conservative as possible, trying to whitelist anything what could be possibly correct in different language and I came with following numbers to remove: Removed 367 in po/bn.po Removed 2 in po/ur.po Removed 3 in po/pt.po Removed 5 in po/ms.po Removed 6 in po/hi.po Removed 666 in po/ka.po Removed 15 in po/ug.po Removed 1 in po/hr.po Removed 42 in po/tt.po Removed 2 in po/it.po Removed 1 in po/eu.po Removed 5 in po/fa.po Removed 119 in po/ro.po Removed 42 in po/az.po Removed 3 in po/he.po Removed 236 in po/si.po Removed 23 in po/et.po Removed 9 in po/mn.po Removed 4 in po/da.po Removed 1 in po/th.po Removed 4 in po/af.po Removed 4 in po/ko.po If you are interested in complete diff against master, it is available here: http://tmp.cihar.com/pma-remove-po.patch Do you agree to make such cleanup (probably on all branches)? This just pollutes our translation statistics and does not bring anything to our users. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 5

[Phpmyadmin-devel] Automated Testing - GSoC Project Idea 2012
by yasitha pandithawatta 28 Mar '12

28 Mar '12

Hi All, I am Yasitha Chathuranga Pandithawatta, 4th year undergraduate of Department of Computer Science Engineering, University of Moratuwa, Sri Lanka. As an open source fan I would like to take part in GSoC this year. I am really interested about the project "Automated Testing" which is listed in your wiki page under "GSoC 2012 Ideas List". I would like to get to know more details about the project. I would like to contact the mentor if possible. Hope I can do my best for the organization and a reply will be highly appreciated. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka

4 13

[Phpmyadmin-devel] phpMyAdmin 3.4.10.2 is released
by Marc Delisle 28 Mar '12

28 Mar '12

Welcome to phpMyAdmin 3.4.10.2, a minor security release. Please refer to the upcoming PMASA-2012-2 announcement on http://www.phpmyadmin.net/home_page/security. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] phpMyAdmin at Percona MySQL Live Conference & Expo 2012
by Michal Čihař 28 Mar '12

28 Mar '12

Hi, phpMyAdmin will be participating in the Percona MySQL Live Conference & Expo, April 10-12, 2012, in Santa Clara, California. Be sure to stop by and visit us at the Dot Org Pavilion! Need a discount code? "PHP-PL12" will save you 10%. For more information see http://www.percona.com/live/mysql-conference-2012/ -- Michal Čihař for the phpMyAdmin team

1 0