September 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #2018
by michal＠cihar.com 18 Sep '12

18 Sep '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/2018/changes> Changes: [ruleant] improve coding style : fix indentation and function calls [ruleant] wrap long lines ------------------------------------------ Started by GitHub push by Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@2fd0a692 Using strategy: Default Last Built Revision: Revision 2d7c588c7d418f41b072ef8e1be7da52ead9ff19 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision a8f591c26b08ddb14f3c2108ec080c4294f42f47 (origin/master) Checking out Revision a8f591c26b08ddb14f3c2108ec080c4294f42f47 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson2743752550757694333.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] PHP Parse error: syntax error, unexpected '.', expecting ')' in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/DisplayResu…> on line 168 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 10 exact clones with 347 duplicated lines in 9 files: [exec] [exec] - /libraries/plugins/export/ExportLatex.class.php:133-142 [exec] /libraries/plugins/export/ExportOdt.class.php:99-108 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:630-656 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:678-704 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:278-296 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:426-447 [exec] /libraries/schema/Svg_Relation_Schema.class.php:393-414 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:474-483 [exec] /libraries/schema/Svg_Relation_Schema.class.php:443-452 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:609-659 [exec] /libraries/schema/Svg_Relation_Schema.class.php:590-640 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:426-447 [exec] /libraries/schema/Visio_Relation_Schema.class.php:224-245 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:609-665 [exec] /libraries/schema/Visio_Relation_Schema.class.php:377-433 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:758-779 [exec] /libraries/schema/Visio_Relation_Schema.class.php:579-600 [exec] [exec] - /themes/original/css/common.css.php:1215-1331 [exec] /themes/pmahomme/css/common.css.php:1574-1690 [exec] [exec] 0.25% duplicated lines out of 141126 total lines of code. [exec] [exec] Time: 6 seconds, Memory: 113.25Mb [exec] Result: 1 phpcs: [exec] Time: 01:38, Memory: 61.50Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 31 [exec] Files: 373 [exec] [exec] Lines of Code (LOC): 141126 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 43587 [exec] Non-Comment Lines of Code (NCLOC): 97539 [exec] [exec] Namespaces: 0 [exec] Interfaces: 2 [exec] Classes: 176 [exec] Abstract: 25 (14.20%) [exec] Concrete: 151 (85.80%) [exec] Average Class Length (NCLOC): 225 [exec] Methods: 1506 [exec] Scope: [exec] Non-Static: 1332 (88.45%) [exec] Static: 174 (11.55%) [exec] Visibility: [exec] Public: 1124 (74.63%) [exec] Non-Public: 382 (25.37%) [exec] Average Method Length (NCLOC): 26 [exec] Cyclomatic Complexity / Number of Methods: 4.21 [exec] [exec] Anonymous Functions: 1 [exec] Functions: 690 [exec] [exec] Constants: 158 [exec] Global constants: 104 [exec] Class constants: 54 BUILD SUCCESSFUL Total time: 1 minute 50 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 5717 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #2017 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 19 warnings. [DRY] Computing warning deltas based on reference build #2017 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 512 files to scan for tasks [TASKS] Found 210 open tasks. [TASKS] Computing warning deltas based on reference build #2017 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #2017 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 0

[Phpmyadmin-devel] Testsuite without errors
by Michal Čihař 17 Sep '12

17 Sep '12

Hi all I've finally managed to bring testsuite to state where there are no failures on ci.phpmyadmin.net. That means that whenever some failure appears with your changes you should fix that (or I will hunt you to fix that :-)). -- Michal Čihař | http://cihar.com | http://blog.cihar.com

1 0

[Phpmyadmin-devel] PMA_CommonFunctions
by Dieter Adriaenssens 17 Sep '12

17 Sep '12

Hi Chanaka, I stumbled upon this piece of code (random pick) : PMA_CommonFunctions::getInstance()->backquote($_REQUEST['view']['name']) and it made me wonder if using a singleton for PMA_CommonFunctions is necessary, because basicaly PMA_Commonfunctions is a collection of methods, not really a 'living' object. So then I had a look at the class, and I discovered that the class has no class variables (apart from the _instance variable) and an empty constructor. So basicly this should be a static class, with static methods, because no instance is needed for it to work. And the above piece of code will become : PMA_CommonFunctions::backquote($_REQUEST['view']['name']) BTW: If you convert it to a static class, don't forget to replace the $this->method() calls by the static equivalent self::method(). BTW2 : you forgot to add the if (! defined('PHPMYADMIN')), check in the beginning of the file, see [0]. [0] http://wiki.phpmyadmin.net/pma/File_template -- Kind regards, Dieter Adriaenssens

6 14

[Phpmyadmin-devel] jqplot last conversion step
by Marc Delisle 16 Sep '12

16 Sep '12

Atul, I have been exchanging mails with you, about the conversion, and I think we should go public on this. We are working on Status>Monitor. One of the features there, is to be able to select a time span and fetch the related queries from the slow log or the general log. After some research, it seems that the jqplotMouseDown and jqplotMouseUp events will be helpful to return the starting and ending positions for the time span; however, as you said, it would be interesting to change the color in the dragged region. This example [0] is promising, but I'm not sure it would work on a chart that is still moving. The jqplotMouseMove event could be used instead of .mousemove(), to get x/y coordinates relative to the chart itself. [0] http://motyar.blogspot.ca/2010/02/draw-rectangle-with-jquery.html -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] time span selection and rectangle
by Marc Delisle 16 Sep '12

16 Sep '12

Hi, starting from Atul's example, I added the rectangle-drawing code in [0]. Here you can draw many rectangles, but when this is integrated to js/server_status_monitor.js, the jqplotMouseUp() will show the "Log statistics" dialog and will erase the rectangle. [0] http://jsfiddle.net/lem9/N4Pst/3/ -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] SourceForge interview with Marc about GSoC
by Dieter Adriaenssens 10 Sep '12

10 Sep '12

Hi all, Marc was interviewed by SourceForge about GSoC : http://sourceforge.net/blog/phpmyadmin-gsoc/?utm_source=rss&utm_medium=rss&… -- Kind regards, Dieter Adriaenssens

1 0

[Phpmyadmin-devel] cleaning up mixed html and php
by Dieter Adriaenssens 06 Sep '12

06 Sep '12

Hi, When fixing coding style issues, I noticed a lot of mixed php and html, especially in the files in the rootdir of the pma. F.e. : <div id='<?php echo htmlentities($name); ?>' class='someclass'> or even worse : <?php if ($something) { ?>Some conditional text <?php } ?> Some unconditional text It generates a lot of codingstyle errors : too long lines, wrong indentation, ... it is badly structured and thus difficult to read and to be honest, is ugly. I'm thinking of starting to clean it up towards 4.0, using either echo's or assigning the output html to a string and add it to the appropriate Response class method. f.e. : <?php $response = PMA_Response::getInstance(); $output = ""; \\ some code in between if (something) { $output .= "Some conditional text"; } $output .= "Some unconditional text"; \\ some code in between $response->addHTML($output); ?> Any thoughts? -- Kind regards, Dieter Adriaenssens

3 3

[Phpmyadmin-devel] status merging GSoC code and code quality
by Dieter Adriaenssens 04 Sep '12

04 Sep '12

Hi all, I was wondering how much of the different GSoC projects is merged in master already? I know about Rouslan's project, not being completely merged. Regarding code quality. I noticed that some of the new code fails a lot of code quality tests (mainly from Code Sniffer). So please run PHPCS (Code Sniffer) [0] on your code and fix the issues. [0] http://wiki.phpmyadmin.net/pma/CodeSniffer -- Kind regards, Dieter Adriaenssens

4 6