Developers June 2013

developers@phpmyadmin.net

17 participants
55 discussions

[Phpmyadmin-devel] Turn off tree view?
by Marc Delisle 22 Aug '13

22 Aug '13

Hi, see this thread: https://sourceforge.net/p/phpmyadmin/discussion/Help/thread/ae8b9e05/ -- Marc Delisle http://infomarc.info

7 11

[Phpmyadmin-devel] Innodb and row exact count
by Marc Delisle 29 Jul '13

29 Jul '13

Hi, I don't find a winning solution so I'm seeking for advice. In this bug report [0], we see that it's annoying to have incorrect page navigation (page selector and arrows) for InnoDB. However, when I apply my proposed patch (which forces an exact count in sql.php), I see delays for larger InnoDB tables. For example, on MySQL 5.5.31, the first time I browse a table having one million rows, I wait for 9 seconds. I tried with 0.5 million and it was about 5 seconds. A few minutes afterwards, even after closing the browser, my big table starts to display in two seconds. I tend to find these delays acceptable and I propose to apply my patch. [0] https://sourceforge.net/p/phpmyadmin/bugs/3976/ -- Marc Delisle http://infomarc.info

3 9

[Phpmyadmin-devel] Renaming proxy credentials variables
by Mohamed Ashraf 05 Jul '13

05 Jul '13

Currently all variables that store proxy credentials have the prefix 'VersionCheck' assuming because this was the only part of phpmyadmin that uses these variables. However I also require those variables in my error reporting code and I did not want to use the same variable names since it is a misnomer at that point. I renamed the variables and removed all the VersionCheck prefixes so they became ProxyUrl, ProxyUser and ProxyPass. I made the changes in the version_check.php code and in the docs. I just wanted to inform you of this change since this may affect others once the error reporting system is merged with master

2 3

[Phpmyadmin-devel] unit testing errors
by Marc Delisle 02 Jul '13

02 Jul '13

Hi, I don't understand why I have different results when running phpunit on the ayushchd/unit_testing branch (5 failures) and on the master branch (with Michal's merge 10 minutes ago), which gives me 16 failures. -- Marc Delisle http://infomarc.info

4 15

[Phpmyadmin-devel] phpMyAdmin 4.0.4.1 is released
by Marc Delisle 30 Jun '13

30 Jun '13

phpMyAdmin 4.0.4.1 has been released to fix a security problem. For more details, see the upcoming PMASA-2013-7. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3741
by michal＠cihar.com 30 Jun '13

30 Jun '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3741/changes> Changes: [xmujay] fix the code style error for some server_view pages [weblate] Translated using Weblate (Italian) [xmujay] fix the syntax error [weblate] Translated using Weblate (Danish) ------------------------------------------ [...truncated 28 lines...] [exec] Not supported query: SHOW GRANTS [exec] PHPUnit 3.7.19 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.nocoverage> [exec] [exec] ............................................................[33;1mI[0m 61 / 1497 ( 4%) [exec] ........................................[41;37mF[0m.................... 122 / 1497 ( 8%) [exec] ............................................................. 183 / 1497 ( 12%) [exec] ............................................................. 244 / 1497 ( 16%) [exec] ............................................................. 305 / 1497 ( 20%) [exec] ............................................................. 366 / 1497 ( 24%) [exec] ............................................................. 427 / 1497 ( 28%) [exec] ............................................................. 488 / 1497 ( 32%) [exec] ............................................................. 549 / 1497 ( 36%) [exec] ............................................................. 610 / 1497 ( 40%) [exec] ............................[36;1mS[0m[36;1mS[0m[36;1mS[0m[36;1mS[0m............................. 671 / 1497 ( 44%) [exec] ............................................................. 732 / 1497 ( 48%) [exec] ............................................................. 793 / 1497 ( 52%) [exec] ............................................................. 854 / 1497 ( 57%) [exec] ............................................................. 915 / 1497 ( 61%) [exec] ............................................................. 976 / 1497 ( 65%) [exec] ............................................................. 1037 / 1497 ( 69%) [exec] ............................................................. 1098 / 1497 ( 73%) [exec] ............................................................. 1159 / 1497 ( 77%) [exec] ............................................................. 1220 / 1497 ( 81%) [exec] ............................................................. 1281 / 1497 ( 85%) [exec] ............................................................. 1342 / 1497 ( 89%) [exec] ............................................................. 1403 / 1497 ( 93%) [exec] ............................................................. 1464 / 1497 ( 97%) [exec] ................................[33;1mI[0m [exec] [exec] Time: 21 seconds, Memory: 77.75Mb [exec] [exec] There was 1 failure: [exec] [exec] 1) PMA_DisplayResults_Test::testGetTableNavigation with data set #0 (21, 41, '123', false, '333') [exec] Failed asserting that 310 matches expected '333'. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Disp…>:429 [exec] [exec] -- [exec] [exec] [exec] There were 2 incomplete tests: [exec] [exec] 1) PMA_ConfigTest::testCheckPermissions [exec] This test has not been implemented yet. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Conf…>:848 [exec] [exec] 2) Environment_Test::testSession [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/Environment_test…>:83 [exec] [exec] -- [exec] [exec] [exec] There were 4 skipped tests: [exec] [exec] 1) PMA_HeaderLocation_Test::testSendHeaderLocationWithSidUrlWithQuestionMark [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:232 [exec] [exec] 2) PMA_HeaderLocation_Test::testSendHeaderLocationWithSidUrlWithoutQuestionMark [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:252 [exec] [exec] 3) PMA_HeaderLocation_Test::testSendHeaderLocationWithoutSidWithIis [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:278 [exec] [exec] 4) PMA_HeaderLocation_Test::testSendHeaderLocationWithoutSidWithoutIis [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:294 [exec] [exec] [37;41m[2KFAILURES! [exec] [0m[37;41m[2KTests: 1497, Assertions: 2363, Failures: 1, Incomplete: 2, Skipped: 4. [exec] [0m[2K [exec] Result: 1 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 20 exact clones with 430 duplicated lines in 23 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-143 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2778-2789 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-215 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1871-1878 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:205-211 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:341-347 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:597-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:615-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-955 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:924-962 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-961 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:796-840 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:453-460 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:654-682 [exec] [exec] 0.30% duplicated lines out of 145023 total lines of code. [exec] [exec] Time: 9 seconds, Memory: 126.50Mb [exec] Result: 1 phpcs: [exec] Time: 01:50, Memory: 59.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 413 [exec] [exec] Lines of Code (LOC): 145023 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 45357 [exec] Non-Comment Lines of Code (NCLOC): 99666 [exec] [exec] Namespaces: 0 [exec] Interfaces: 3 [exec] Traits: 0 [exec] Classes: 204 [exec] Abstract: 26 (12.75%) [exec] Concrete: 178 (87.25%) [exec] Average Class Length (NCLOC): 222 [exec] Methods: 1750 [exec] Scope: [exec] Non-Static: 1467 (83.83%) [exec] Static: 283 (16.17%) [exec] Visibility: [exec] Public: 1356 (77.49%) [exec] Non-Public: 394 (22.51%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.22 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 653 [exec] [exec] Constants: 168 [exec] Global constants: 108 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 2 minutes 37 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2786 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3740 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 38 warnings. [DRY] Computing warning deltas based on reference build #3740 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 609 files to scan for tasks [TASKS] Found 196 open tasks. [TASKS] Computing warning deltas based on reference build #3740 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3740 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [INFO] - Check 'Failed Tests' threshold. [xUnit] [INFO] - Check 'Skipped Tests' threshold. [xUnit] [INFO] - Setting the build status to SUCCESS [xUnit] [INFO] - Stopping recording. ERROR: Publisher hudson.plugins.violations.ViolationsPublisher aborted due to exception java.io.EOFException: no more data available - expected end tags </issue></file></jslint> to close start tag <issue> from line 340 and start tag <file> from line 289 and start tag <jslint> from line 2, parser stopped on TEXT seen ..." reason="Bad line breaking before '&&'." evide\n... @341:1 at org.xmlpull.mxp1.MXParser.fillBuf(MXParser.java:3035) at org.xmlpull.mxp1.MXParser.more(MXParser.java:3046) at org.xmlpull.mxp1.MXParser.parseAttribute(MXParser.java:2003) at org.xmlpull.mxp1.MXParser.parseStartTag(MXParser.java:1799) at org.xmlpull.mxp1.MXParser.nextImpl(MXParser.java:1127) at org.xmlpull.mxp1.MXParser.next(MXParser.java:1093) at hudson.plugins.violations.parse.AbstractParser.skipToTag(AbstractParser.java:189) at hudson.plugins.violations.types.jslint.JsLintParser.parseFileElement(JsLintParser.java:42) at hudson.plugins.violations.types.jslint.JsLintParser.execute(JsLintParser.java:30) at hudson.plugins.violations.parse.AbstractTypeParser.parse(AbstractTypeParser.java:57) at hudson.plugins.violations.ViolationsCollector.doType(ViolationsCollector.java:187) at hudson.plugins.violations.ViolationsCollector.invoke(ViolationsCollector.java:114) at hudson.plugins.violations.ViolationsCollector.invoke(ViolationsCollector.java:25) at hudson.FilePath.act(FilePath.java:905) at hudson.FilePath.act(FilePath.java:878) at hudson.plugins.violations.ViolationsPublisher.perform(ViolationsPublisher.java:74) at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:36) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:804) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:776) at hudson.model.Build$BuildExecution.post2(Build.java:183) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:726) at hudson.model.Run.execute(Run.java:1618) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:242)

1 0

[Phpmyadmin-devel] Error stack trace on ajax navigate
by Mohamed Ashraf 29 Jun '13

29 Jun '13

I have been doing some tests to find places to improve my error collection strategy. It seems that all the browsers get confused as to where the error occurs, when the file containing the error is loaded using ajax navigation. The same error if it occurs in files loaded normally by the browser shows a proper stacktrace, however if it occurs in files that are loaded by the AJAX class it shows a useless stacktrace missing the actual part of the code where the error occurs. This occurs not due to my error reporting code since I removed it entirely during testing and it occurs consistently across browsers. I am not sure what is the best course of action here it seems that the problem occurs due to problems in how the browser handles stacktraces in javascript.

1 0

[Phpmyadmin-devel] Thought you'd find this interesting
by Gopi Ramena 29 Jun '13

29 Jun '13

Hi phpmyadmin-devel, I’ve just learned about the water crisis and thought you would be interested to check out this story: https://waterforward.charitywater.org/et/yfDqOQb Thanks, Gopi -- Sent via WaterForward, an initiative of charity: water WaterForward, 387 Tehama Street, San Francisco, CA 94103, USA. Click here to unsubscribe: https://waterforward.charitywater.org/opt_out?et=yfDqOQb

1 0

[Phpmyadmin-devel] About image sprites
by Isaac Bennetch 28 Jun '13

28 Jun '13

Hello, I'm reviewing Kasun's pull request for the search and replace functionality and realize I'm not sure what the procedure is for adding new images. The wiki documentation [1] is pretty thorough except for one question; when do we actually run the script? My understanding is that any time a new icon is added, the developer would run the generate-sprites script and commit the resulting sprite file. Is that correct? 1 - http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

3 4

[Phpmyadmin-devel] sqlAddSlashes
by Ayush Chaudhary 26 Jun '13

26 Jun '13

Hi, I was setting up some unit tests when I came across the function PMA_Util::sqlAddSlashes() Isn't it supposed to add slashes to single quotes? Because I tested this: echo PMA_Util::sqlAddSlashes("pma_'db"); And the output was pma_''db Is this the correct behaviour? -- Ayush Chaudhary

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers June 2013