Developers July 2013

developers@phpmyadmin.net

18 participants
66 discussions

[Phpmyadmin-devel] (no subject)
by Supun Nakandala 05 Jul '13

05 Jul '13

Hi Marc, I identified seven situations where the method PMA_sendResponseForNoResultsReturned runs. 1-> When browsing an empty table 2-> When executing a query on a non empty table which returns zero results 3-> When executing a query on an empty table 4-> When executing an INSERT, UPDATE, DELETE query from the SQL tab 5-> When deleting a row from BROWSE tab 6-> When searching using the SEARCH tab which returns zero results 7-> When changing the structure of the table except change operation In the first case the $goto variable is not initialized. But in the second, third and fourth cases it is initialized to tbl_sql.php. In the third, fourth and fifth cases the $goto variable is initialized with sql.php itself with certain other url parameters. In the 7 th case $goto variable is set to $tbl_structure.php But I identified all these cases send Ajax responses where $goto variable or sending header location were never used. I would like to know whether my test scenarios are comprehensive if so shall I remove the redundant code segments.

2 1

[Phpmyadmin-devel] (no subject)
by Ayush Chaudhary 03 Jul '13

03 Jul '13

Hi, Is there a reason why validation.lib.php is not a class with public static method? Is it okay to convert it to a class with all methods' access specifier as public static? -- Ayush Chaudhary

1 0

[Phpmyadmin-devel] Icons for Find and replace
by Isaac Bennetch 03 Jul '13

03 Jul '13

Hi, Kasun has implemented the Find and replace feature and since then, we have been discussing the icon to use. I've attached here the best we've come up with, which is basically the Edit and Search icons merged. If anyone has any comments or anything better, please feel free to speak up. Thanks

2 1

[Phpmyadmin-devel] unit testing errors
by Marc Delisle 02 Jul '13

02 Jul '13

Hi, I don't understand why I have different results when running phpunit on the ayushchd/unit_testing branch (5 failures) and on the master branch (with Michal's merge 10 minutes ago), which gives me 16 failures. -- Marc Delisle http://infomarc.info

4 15

[Phpmyadmin-devel] RFE tracker settings
by J. M. 02 Jul '13

02 Jul '13

In the RFE tracker, whats the difference between "Needs_decision, Needs_planning" and especially between "Next minor" and "Next release"? Do we not always add new features to A+1 or B+1, but not to C in Version A.b.c? And: How to handle priorities in RFE tracker? I know how we deal with them in bugs tracker. And: Do we not have "accepted" as status in RFEs? AFAIK we have it with bugs. Some insight and common guidelines appreciated. J.M.

3 2

[Phpmyadmin-devel] Dropping PHP 5.2 support
by Michal Čihař 02 Jul '13

02 Jul '13

Hi all I think it's time to raise requirements in master to PHP 5.3. Current master is not really compatible with PHP 5.2 as you can see here: https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/8618135 The alternative is to fix all variable objects usage (eg. $GLOBALS['PMA_String']::foo()). -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers July 2013