I pulled master lately and I found that Michal Čihař has refactored
the code that requests the latest version info. I needed to update a
few things specifically with the renaming of the proxy variable names.
Anyway I noticed a strange piece of code in the function:
if ($save) {
$_SESSION['cache']['version_check'] = array(
'response' => $response,
'timestamp' => time()
);
}
$data = json_decode($response);
if (is_object($data)
&& strlen($data->version)
&& strlen($data->date)
) {
if ($save) {
$_SESSION['cache']['version_check'] = array(
'response' => $response,
'timestamp' => time()
);
}
}
why is the part that saves the response in the cache written twice in
succession. I looked at the commit in question dcd8d12cf6c4a345 and
noticed that the first repetition did not exist in the original code.
I think that the first repetition should be removed but I thought I
should run it by you first
--
Mohamed Ashraf
I created a script to calculate the line counts of the javascript
files and output them in an array in a php file. I use this php file
in my calculations to calculate the line number where an exception
occurs. I call this script in the release script so that it would be
included in every release. My question is should I add the output php
file to the gitignore or no. I am thinking that I should since it is
generated but I am not sure if that is the correct way to go
--
Mohamed Ashraf
Currently souceforge does not offer an api to get the list of
milestones that are available to a bug ticket. So for the bug report
submission I have 3 choices. the first is just to leave the milestone
field blank and it appears as "milestone none" in the issue tracker.
the second is to allow the submitter to write down (not select) the
milestone at the time of submission. this milestone has to match one
of the milestones in the project otherwise a validation error is
returned. The third would be to submit a bogus report with a wrong
milestone. The error returned has within the message the list of
milestones available. I may be able to use regular expressions to get
the list of milestones.
The problems with the last approach is that one it is a hack, two is
that I would have to do a bogus ticket submission every time I need
the list of milestones which changes every release and three is that
if sourceforge changes the way the error string is returned there is
going to be a problem.
--
Mohamed Ashraf
Hi all
we currently list few appliances on our downloads page
<http://www.phpmyadmin.net/home_page/downloads.php#appliances> and we
occasionally get request to include some other. As phpMyAdmin is
probably included in most of LAMP appliances, the list can be expected
to grow in the future.
So the question is whether we want to list these appliances at all at
our download page.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi,
I don't find a winning solution so I'm seeking for advice. In this bug
report [0], we see that it's annoying to have incorrect page navigation
(page selector and arrows) for InnoDB.
However, when I apply my proposed patch (which forces an exact count in
sql.php), I see delays for larger InnoDB tables.
For example, on MySQL 5.5.31, the first time I browse a table having one
million rows, I wait for 9 seconds. I tried with 0.5 million and it was
about 5 seconds. A few minutes afterwards, even after closing the
browser, my big table starts to display in two seconds.
I tend to find these delays acceptable and I propose to apply my patch.
[0] https://sourceforge.net/p/phpmyadmin/bugs/3976/
--
Marc Delisle
http://infomarc.info
Hi,
since the merging of pull request 543, I guess that we should try to
port all remaining places that use the native corresponding string
functions, to the new syntax?
This way we can benefit, for example, from the multibyte version of
these functions.
--
Marc Delisle
http://infomarc.info
phpMyAdmin 3.5.8.2 and 4.0.4.2 have been released to fix security problems.
For more details, see the upcoming PMASA-2013-8 to PMASA-2013-15 (minus
PMASA-2013-10 which is reserved for a future advisory).
Details will appear on http://phpmyadmin.net. In a hurry? you can visit
https://sourceforge.net/projects/phpmyadmin/files to download.
Marc Delisle, for the team